From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 274FBC4360F for ; Thu, 4 Apr 2019 17:43:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5D47206DD for ; Thu, 4 Apr 2019 17:43:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Au5ToeJg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727152AbfDDRnj (ORCPT ); Thu, 4 Apr 2019 13:43:39 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:38595 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727212AbfDDRnj (ORCPT ); Thu, 4 Apr 2019 13:43:39 -0400 Received: by mail-lj1-f193.google.com with SMTP id p14so2863509ljg.5 for ; Thu, 04 Apr 2019 10:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WGSyyrPaPmnoL0ndsLJSTpVaKw/4YG9rkuv7M6qYYhI=; b=Au5ToeJge72gEP8ySm/G6J+etDoaulRBlzouu2chPh4Li9k0iZioDn3/ZZV9l1aZW/ Q3M/M2SCUo6l7mVZRRkWK3iffg4cEQRKuVr4DkvrXOcnLFnWitgWY+cN/AtA/o7eN0jU vLCRMyqo40ltkykuIGf3cAo8hmAh8fPa5f2Zfqpmp08lBMyiq5XtTajRvN8rD9mppAKi eSOjqhZ80Gh+qW8x3+7j/Mm1u16fMm9+gWJZzRHkyFR+4JaHMq86doabt5P9IVvtHVl3 9/Nznr6HPtZ1DY/Q2Xura1lYakyu5xlO+QpJGUJ5in/g7jHsMzk0HSCyC6nkf8/38Iiw Qimw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WGSyyrPaPmnoL0ndsLJSTpVaKw/4YG9rkuv7M6qYYhI=; b=HoRaWpdCBAk/TN2Zu9Br/I8ZeJFPWRL6dk5/sP6E7D+KHNRH1plZSNYI5YRsc3lJMw 2nGpwj7d6W8EEV7MkHPu6YvSr+YKBeyoPSsTnoUqB3lwdG9DuG76jAFvblP9ncngfWze BaF/loXdAJQSSd608/6YGLH1ggxJAAsEKWHJPa5nlcIbz9ntTb78NF0RPL2ksDuZ/rq8 8S/Z/Qf/CVG/+xcU970X/+FcGzRNc4ywRuAi9VVwre5se3z9yuJ9PN0G+ReYeR2ZNYL+ Wxv+LcopViHJBEN8UTR4Zo1cxtyoCSZ3/I2FHp90ea0ULugVvfvsOx6roHmn7OivQMY2 Drnw== X-Gm-Message-State: APjAAAW1JYkNRinpYYh+X1ajNxayKUr9MlHvbffLmuzmFVgzzgT46WOy WhEfpfTGnhTR2Yc+nR7UO6ZKy2vwQLdyyUmlRFKJ4yE5gOY= X-Google-Smtp-Source: APXvYqzAz8UwMxYGXOb1VpBU7/MY8ZPQKVNQcSUrYMp1CHxHYDE0dPh7xvmfoHgRrlNA5qrUTAuKdzuqNvvN0FmCyq4= X-Received: by 2002:a2e:7d19:: with SMTP id y25mr1717234ljc.126.1554399816638; Thu, 04 Apr 2019 10:43:36 -0700 (PDT) MIME-Version: 1.0 References: <20190404171007.160878-1-ncrews@chromium.org> <20190404171007.160878-3-ncrews@chromium.org> In-Reply-To: From: Dmitry Torokhov Date: Thu, 4 Apr 2019 10:43:24 -0700 Message-ID: Subject: Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name To: Guenter Roeck Cc: Nick Crews , Enric Balletbo i Serra , Benson Leung , linux-leds@vger.kernel.org, Jacek Anaszewski , Pavel Machek , alexandre.belloni@bootlin.com, Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel , Duncan Laurie , Simon Glass Content-Type: text/plain; charset="UTF-8" Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wrote: > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wrote: > > > > We want all backlights for the system keyboard to > > use a common name, so the name "platform::kbd_backlight" > > would be better than the current "chromeos::kbd_backlight" > > name. Normally this wouldn't be worth changing, but the new > > Wilco keyboard backlight driver uses the "platform" name. > > We want to make it so all Chrome OS devices are consistent, > > so we'll change the name here too. > > > > Wondering - who is the "we" you are talking about ? This also has a potential of breaking existing setups if somebody did happen to match on entire name instead of suffix. Such changes have to be considered very carefully; at this point I am against of doing this. Thanks. -- Dmitry