From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: liambeguin@gmail.com
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/3] rtc: pcf2127: add pca2129 device id
Date: Tue, 9 Jun 2020 22:48:30 +0200 [thread overview]
Message-ID: <CAH+2xPAb=468vj06NqkV+f0sE2RNaHBXiR0SC5NjHLw+D4AtZA@mail.gmail.com> (raw)
In-Reply-To: <20200607170610.24534-2-liambeguin@gmail.com>
Den søn. 7. jun. 2020 kl. 19.06 skrev <liambeguin@gmail.com>:
>
> From: Liam Beguin <lvb@xiphos.com>
>
> From: Liam Beguin <lvb@xiphos.com>
>
> The PCA2129 is the automotive grade version of the PCF2129.
> add it to the list of compatibles.
>
> Signed-off-by: Liam Beguin <lvb@xiphos.com>
> ---
> drivers/rtc/rtc-pcf2127.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c
> index 4e50d6768f13..396a1144a213 100644
> --- a/drivers/rtc/rtc-pcf2127.c
> +++ b/drivers/rtc/rtc-pcf2127.c
> @@ -546,6 +546,7 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap,
> static const struct of_device_id pcf2127_of_match[] = {
> { .compatible = "nxp,pcf2127" },
> { .compatible = "nxp,pcf2129" },
> + { .compatible = "nxp,pca2129" },
Remember to document new compatible string here:
Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
/Bruno
> {}
> };
> MODULE_DEVICE_TABLE(of, pcf2127_of_match);
> @@ -656,6 +657,7 @@ static int pcf2127_i2c_probe(struct i2c_client *client,
> static const struct i2c_device_id pcf2127_i2c_id[] = {
> { "pcf2127", 1 },
> { "pcf2129", 0 },
> + { "pca2129", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, pcf2127_i2c_id);
> @@ -720,6 +722,7 @@ static int pcf2127_spi_probe(struct spi_device *spi)
> static const struct spi_device_id pcf2127_spi_id[] = {
> { "pcf2127", 1 },
> { "pcf2129", 0 },
> + { "pca2129", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(spi, pcf2127_spi_id);
> --
> 2.27.0
>
next prev parent reply other threads:[~2020-06-09 20:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 17:06 [PATCH 0/3] rtc: pcf2127: add alarm support liambeguin
2020-06-07 17:06 ` [PATCH 1/3] rtc: pcf2127: add pca2129 device id liambeguin
2020-06-09 20:48 ` Bruno Thomsen [this message]
2020-06-07 17:06 ` [PATCH 2/3] rtc: pcf2127: add alarm support liambeguin
2020-06-09 20:42 ` Bruno Thomsen
2020-06-10 15:38 ` Liam Beguin
2020-06-09 21:05 ` Alexandre Belloni
2020-06-10 15:49 ` Liam Beguin
2020-06-10 16:32 ` Alexandre Belloni
2020-06-07 17:06 ` [PATCH 3/3] rtc: pcf2127: reset alarm interrupt at power on liambeguin
2020-06-09 21:07 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+2xPAb=468vj06NqkV+f0sE2RNaHBXiR0SC5NjHLw+D4AtZA@mail.gmail.com' \
--to=bruno.thomsen@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=liambeguin@gmail.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).