linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bruno Thomsen <bruno.thomsen@gmail.com>
To: linux-rtc@vger.kernel.org
Cc: alexandre.belloni@bootlin.com, a.zummo@towertech.it,
	bth@kamstrup.com, u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH 0/4] rtc: pcf2127: tamper timestamp and watchdog feature support
Date: Tue, 23 Jul 2019 16:13:12 +0200	[thread overview]
Message-ID: <CAH+2xPB7y703-WeiNBRoDXfWPKTRMzD=a5P+EYohYmV46BS2ZA@mail.gmail.com> (raw)
In-Reply-To: <20190722155811.11980-1-bruno.thomsen@gmail.com>

Hi all

> Patches has been tested on a pcf2127 chip using 2MHz SPI
> interface both as built-in and module including with and
> without watchdog feature.

I did some more testing as I could not understand this bugfix:

3769a375ab83 rtc: pcf2127: bulk read only date and time registers.

This fix seems to be incomplete as root cause is not auto-increment
read aka bulk read, but reading control register 2 triggers zero value
in WD_VAL resulting in stopped watchdog until systemd kick the dog
again :)

As the watchdog has 2 control registers I will do some more testing
to see if this also apply to the other register. But more importantly
this issue also affect timestamp0_{store,show} functions in tamper
detection support, and I will therefor send a v2 of the patch series.

/Bruno

  parent reply	other threads:[~2019-07-23 14:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 15:58 [PATCH 0/4] rtc: pcf2127: tamper timestamp and watchdog feature support Bruno Thomsen
2019-07-22 15:58 ` [PATCH 1/4] rtc: pcf2127: convert to devm_rtc_allocate_device Bruno Thomsen
2019-07-22 15:58 ` [PATCH 2/4] rtc: pcf2127: cleanup register and bit defines Bruno Thomsen
2019-07-23 18:42   ` Alexandre Belloni
2019-07-22 15:58 ` [PATCH 3/4] rtc: pcf2127: add tamper detection support Bruno Thomsen
2019-07-22 15:58 ` [PATCH 4/4] rtc: pcf2127: add watchdog feature support Bruno Thomsen
2019-07-23 18:48   ` Alexandre Belloni
2019-07-24  7:18     ` Bruno Thomsen
2019-07-24 13:00       ` Alexandre Belloni
2019-07-23 14:13 ` Bruno Thomsen [this message]
2019-07-23 18:40   ` [PATCH 0/4] rtc: pcf2127: tamper timestamp and " Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+2xPB7y703-WeiNBRoDXfWPKTRMzD=a5P+EYohYmV46BS2ZA@mail.gmail.com' \
    --to=bruno.thomsen@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=bth@kamstrup.com \
    --cc=linux-rtc@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).