From: Raul Rangel <rrangel@google.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
Pavel Machek <pavel@ucw.cz>,
Alessandro Zummo <a.zummo@towertech.it>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
alvin.zhuge@gmail.com, renzhamin@gmail.com, kelvie@kelvie.ca,
Mark Hasemeyer <markhas@chromium.org>
Subject: Re: [PATCH] rtc: cmos: Use ACPI alarm for non-Intel x86 systems too
Date: Fri, 17 Nov 2023 16:43:15 -0700 [thread overview]
Message-ID: <CAHQZ30AkayKxQkLajaY6gcFbGMWb=wu3Nqxzed5yFjLo8bX4hQ@mail.gmail.com> (raw)
In-Reply-To: <2023111722570552652970@mail.local>
On Fri, Nov 17, 2023 at 3:57 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> On 14/11/2023 18:15:02-0600, Mario Limonciello wrote:
> > On 11/14/2023 16:28, Alexandre Belloni wrote:
> > > On 14/11/2023 10:06:36+0100, Pavel Machek wrote:
> > > > On Mon 2023-11-13 23:38:19, Alexandre Belloni wrote:
> > > > > On 13/11/2023 15:36:28-0600, Mario Limonciello wrote:
> > > > > > Now that the merge window is over, can this be picked up?
> > > > > >
> > > > >
> > > > > I'd be happy to invoice AMD so they get a quick response time.
> > > >
> > > > That is a really bad joke.
> > >
> > > Why would it be a joke?
> > >
> > > From what I get this is an issue since 2021, I don't get how this is so
> > > urgent that I get a ping less than 24h after the end of the merge
> > > window.
> >
> > It's possibly longer; but I don't have a large enough sample to say that
> > it's safe that far back.
>
> Would this help this one:
> https://bugzilla.kernel.org/show_bug.cgi?id=68331
Honestly, the HPET_EMULATE_RTC code is what drove me to switch the AMD
chromebooks over to using the ACPI timer:
https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/2355073.
Ideally if the HPET was configured with proper IRQs by the firmware,
the kernel wouldn't enable the HPET legacy emulation bit. The HPET
spec defines that when the legacy replacement option bit is set, the
HPET takes control of the RTC (#8) and timer (#2) interrupts. Why it
takes over the RTC interrupt I've never understood. The HPET is not an
RTC, so it results in software having to emulate it which results in
extra complexity. If the kernel didn't set the HPET legacy emulation
bit when the HPET declared proper IRQs, then the RTC wake interrupt
would keep working as expected. I guess there's not much benefit to
fixing this anymore, now that this ACPI timer patch has landed. If a
platform were to release new firmware to define proper HPET IRQs, the
date would bump, and it would fall into the ACPI path.
>
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
next prev parent reply other threads:[~2023-11-17 23:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 16:23 [PATCH] rtc: cmos: Use ACPI alarm for non-Intel x86 systems too Mario Limonciello
2023-11-06 16:17 ` Raul Rangel
2023-11-13 21:36 ` Mario Limonciello
2023-11-13 22:38 ` Alexandre Belloni
2023-11-14 9:06 ` Pavel Machek
2023-11-14 22:28 ` Alexandre Belloni
2023-11-15 0:15 ` Mario Limonciello
2023-11-17 22:57 ` Alexandre Belloni
2023-11-17 23:00 ` Mario Limonciello
2023-11-17 23:43 ` Raul Rangel [this message]
2023-11-17 17:36 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQZ30AkayKxQkLajaY6gcFbGMWb=wu3Nqxzed5yFjLo8bX4hQ@mail.gmail.com' \
--to=rrangel@google.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=alvin.zhuge@gmail.com \
--cc=kelvie@kelvie.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=markhas@chromium.org \
--cc=pavel@ucw.cz \
--cc=renzhamin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).