From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE75C10F0C for ; Thu, 4 Apr 2019 18:41:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 021CD206B7 for ; Thu, 4 Apr 2019 18:41:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FhbBv0lm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729864AbfDDSlp (ORCPT ); Thu, 4 Apr 2019 14:41:45 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:43232 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729793AbfDDSlp (ORCPT ); Thu, 4 Apr 2019 14:41:45 -0400 Received: by mail-oi1-f196.google.com with SMTP id t81so2757937oig.10 for ; Thu, 04 Apr 2019 11:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ndF6e0KraTkIrYsDCv77TWOivEtX3C6Q0r0KXXhAAGk=; b=FhbBv0lmLayK3GkbHep6oA1XDZk8BzOJMoARldyTiIt6QuS0Ksq4xCArMLgytLOB9j PEmuaWbsb2h/hom+N3P23XWftbbsX0bWRGlb2Ww/GQqBIualupyQyLhxgjnleTVcMQUK XGrtSRqNLJynwfeuVd7fhGAa/0F6JYVpL1Lp4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ndF6e0KraTkIrYsDCv77TWOivEtX3C6Q0r0KXXhAAGk=; b=Pg79dqNHpwEIyjQjMYTYMf7fjyDiDEZtRzSTtaNYmaQ0GsVtrxVnPCOq6wZfpdLnmx mTUQSlEOsHDzVixXm8uj6XT6hWQDduEHITO4GsT9clOF8fn2YzjvMro1kYzAyy5tAiDi 8Je6cB9a6Z5nEASKxQShfyBgx8k89ONQNT6zKgDDuStcmrcwLX6pU3hUijtaecUE3QZy EMF8FMGsWCc00pZOPJJN7HpcJgaHNJHFMqU7vmedqgQN9qLNinOyts69WdOcBTZzctdM MxqbRWF+bEdEfUFo8YzMu50JgNB1/0UaEi27PHtozv5RZG6IEWnV6NUe14YrTBHXXOCt 011g== X-Gm-Message-State: APjAAAUCQ8owHkXPGCSV0kaBPGVlImD5gB+q08PxhMbz9uTJOgupS4mn a53DtB2nr0vdaDtsegPCl9H5YOj++i0= X-Google-Smtp-Source: APXvYqwugJPp2/ngnpuYmTQLtAVZbuaXpSefNURAPVbn+c9CY061ULEJRGOnpLpKEmroAnse2HFdSg== X-Received: by 2002:aca:5241:: with SMTP id g62mr4500745oib.103.1554403304540; Thu, 04 Apr 2019 11:41:44 -0700 (PDT) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com. [209.85.210.45]) by smtp.gmail.com with ESMTPSA id s23sm7824769otk.0.2019.04.04.11.41.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Apr 2019 11:41:43 -0700 (PDT) Received: by mail-ot1-f45.google.com with SMTP id 64so3288805otb.8 for ; Thu, 04 Apr 2019 11:41:42 -0700 (PDT) X-Received: by 2002:a9d:70cf:: with SMTP id w15mr5599304otj.304.1554403302149; Thu, 04 Apr 2019 11:41:42 -0700 (PDT) MIME-Version: 1.0 References: <20190404171007.160878-1-ncrews@chromium.org> <20190404171007.160878-3-ncrews@chromium.org> In-Reply-To: From: Nick Crews Date: Thu, 4 Apr 2019 12:41:30 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name To: Dmitry Torokhov Cc: Guenter Roeck , Enric Balletbo i Serra , Benson Leung , linux-leds@vger.kernel.org, Jacek Anaszewski , Pavel Machek , Alexandre Belloni , Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel , Duncan Laurie , Simon Glass Content-Type: text/plain; charset="UTF-8" Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Thu, Apr 4, 2019 at 11:43 AM Dmitry Torokhov wrote: > > On Thu, Apr 4, 2019 at 10:36 AM Guenter Roeck wrote: > > > > On Thu, Apr 4, 2019 at 10:11 AM Nick Crews wrote: > > > > > > We want all backlights for the system keyboard to > > > use a common name, so the name "platform::kbd_backlight" > > > would be better than the current "chromeos::kbd_backlight" > > > name. Normally this wouldn't be worth changing, but the new > > > Wilco keyboard backlight driver uses the "platform" name. > > > We want to make it so all Chrome OS devices are consistent, > > > so we'll change the name here too. > > > > > > > Wondering - who is the "we" you are talking about ? You're right, I should have been more precise. I was referring to Pavel, Enric, and myself. Pavel had this opinion here: https://lkml.org/lkml/2019/4/4/1040. I don't know what Pavel meant by "we" in that comment, but I would guess that could mean the other LED maintainers as well? I talked with Enric 1:1 and he didn't see the problem with changing it, though perhaps he was only considering our use of the LED via powerd, and not users in general. I'm guessing Pavel's and Enric's meanings though, excuse me if I am misinterpreting. > > This also has a potential of breaking existing setups if somebody did > happen to match on entire name instead of suffix. Such changes have to > be considered very carefully; at this point I am against of doing > this. Would it make sense to keep the old name as is, and only make the new Wilco name begin with "platform:"? What would you think is best? > > Thanks. > > -- > Dmitry