From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Claudius Heine <ch@denx.de>,
Alessandro Zummo <a.zummo@towertech.it>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Henning Schild <henning.schild@siemens.com>,
Johannes Hahn <johannes-hahn@siemens.com>
Subject: Re: [PATCH v2 1/3] rtc: rx6110: add i2c support
Date: Mon, 16 Nov 2020 19:58:40 +0200 [thread overview]
Message-ID: <CAHp75Vehwi8xzSBn_9Qa_SHF3ZCVGTBnsDmv6vix49vGt1wQhQ@mail.gmail.com> (raw)
In-Reply-To: <20201116173617.GV4556@piout.net>
On Mon, Nov 16, 2020 at 7:38 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 16/11/2020 16:43:43+0200, Andy Shevchenko wrote:
> > On Thu, Nov 12, 2020 at 02:07:32PM +0100, Claudius Heine wrote:
> > > The RX6110 also supports I2C, so this patch adds support for it to the
> > > driver.
> > >
> > > This also renames the SPI specific functions and variables to include
> > > `_spi_` in their names.
> >
> > As practice shows this is not the best approach. Can you ratqer split it to
> > three modules: core, spi, i2c like it's done in many other cases (esp. IIO)?
> >
>
> Actually, I'm fine with having everytihn in the same file because
> separating everything out means having 3 more files per rtc supporting
> both busses in an already very crowded folder. And I don't think being
> able to remove support for one or the other holds any actual value.
Good to know your opinion!
Since you are one who is looking after RTC stuff I'm not insisting on
my proposal.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-16 17:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 13:07 [PATCH v2 0/3] Adding I2C support to RX6110 RTC Claudius Heine
2020-11-12 13:07 ` [PATCH v2 1/3] rtc: rx6110: add i2c support Claudius Heine
2020-11-12 13:19 ` Claudius Heine
2020-11-16 14:43 ` Andy Shevchenko
2020-11-16 17:36 ` Alexandre Belloni
2020-11-16 17:58 ` Andy Shevchenko [this message]
2020-11-12 13:07 ` [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C Claudius Heine
2020-11-16 14:46 ` Andy Shevchenko
2020-11-16 15:30 ` Henning Schild
2020-11-16 16:05 ` Andy Shevchenko
2020-11-16 16:08 ` Andy Shevchenko
2020-11-17 7:37 ` AW: " johannes-hahn
2020-11-17 11:10 ` Andy Shevchenko
2020-11-17 11:17 ` Andy Shevchenko
2020-11-17 9:46 ` AW: " johannes-hahn
2020-11-17 11:33 ` Andy Shevchenko
2020-11-17 11:41 ` Andy Shevchenko
2020-11-18 10:04 ` Henning Schild
2020-11-18 10:58 ` AW: " werner.zeh
2021-03-16 10:08 ` [PATCH v3 0/1] add ACPI binding to RX6110 driver Claudius Heine
2021-03-16 14:48 ` [PATCH v4] rtc: rx6110: add ACPI bindings to I2C Claudius Heine
2021-03-16 16:55 ` Andy Shevchenko
2021-03-17 7:53 ` Claudius Heine
2021-03-16 19:04 ` kernel test robot
2021-03-16 20:44 ` Andy Shevchenko
2021-03-16 10:08 ` [PATCH v3 1/1] " Claudius Heine
2021-03-16 11:30 ` Andy Shevchenko
2021-03-16 11:33 ` Andy Shevchenko
2021-03-16 11:52 ` Henning Schild
2021-03-16 13:46 ` Andy Shevchenko
2020-11-12 13:07 ` [PATCH v2 3/3] rtc: Kconfig: Fix typo in help message of rx 6110 Claudius Heine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vehwi8xzSBn_9Qa_SHF3ZCVGTBnsDmv6vix49vGt1wQhQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@intel.com \
--cc=ch@denx.de \
--cc=henning.schild@siemens.com \
--cc=johannes-hahn@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).