From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A540C3A5A2 for ; Tue, 3 Sep 2019 07:58:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 155C521881 for ; Tue, 3 Sep 2019 07:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567497517; bh=UXh12NkSwZ12hWkXETNI+YE3LiuTShuDOHt89Jbh128=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=QcN2u1dY/2jqeoTMIiEcl03CIuXdUrw0QcL7gBIwnwwmf6aHBEgD+ZUe8+qVWGQFu lI9AtNMwdmWgRnlHM2b2bJQuL8JhSNM6jTJ8GbBimAuMJHkWnn7ooDplQASr9zVj2Y J/BLi+Y9xoae2zmlQ5zWKWm2kuN9V5q4wU2OEdL0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbfICH6g (ORCPT ); Tue, 3 Sep 2019 03:58:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:43714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbfICH6g (ORCPT ); Tue, 3 Sep 2019 03:58:36 -0400 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D827321881; Tue, 3 Sep 2019 07:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567497515; bh=UXh12NkSwZ12hWkXETNI+YE3LiuTShuDOHt89Jbh128=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=am7+Xbi2YfzdQSUw6p4YYdjuXFciTPcfw96UlPxdv1inY3pLUnYIUWWTTdp7gOu6j mbOKZWr7h3x4jVZ7l5VuM603tR4gC52GePWzV1gNGQzP/qU2s4yOLmczxTPXfsHYeP bsIivXjLkyEM2heVUy+enefLtMFc34vgtmnSlwbY= Received: by mail-lf1-f52.google.com with SMTP id u29so12081415lfk.7; Tue, 03 Sep 2019 00:58:34 -0700 (PDT) X-Gm-Message-State: APjAAAV73T5Ovkcgc1rE1XJcip6UUKUltD1FDhRq3L4+IJAmd2gUe7md LN2c3MfXKplbpkNgqz/eWw5MQmh3KOYphcZrHak= X-Google-Smtp-Source: APXvYqzrJeKyNEvczFZsfe2tgLAYBl9BS475I7A9xOTHksgZrFCcJ43dEFvCe2Ya4ROGp9gR8nfJe7d+AYReOk1iVIQ= X-Received: by 2002:a19:c649:: with SMTP id w70mr20083717lff.33.1567497513112; Tue, 03 Sep 2019 00:58:33 -0700 (PDT) MIME-Version: 1.0 References: <20190823145356.6341-1-krzk@kernel.org> <20190823145356.6341-5-krzk@kernel.org> In-Reply-To: From: Krzysztof Kozlowski Date: Tue, 3 Sep 2019 09:58:21 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 5/9] dt-bindings: arm: samsung: Convert Exynos PMU bindings to json-schema To: Rob Herring Cc: Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Alessandro Zummo , Alexandre Belloni , =?UTF-8?Q?Pawe=C5=82_Chmiel?= , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-samsung-soc , "linux-kernel@vger.kernel.org" , "open list:IIO SUBSYSTEM AND DRIVERS" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , notify@kernel.org, Arnd Bergmann , Olof Johansson , Marek Szyprowski , Tomasz Figa Content-Type: text/plain; charset="UTF-8" Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Mon, 26 Aug 2019 at 13:54, Rob Herring wrote: > > On Fri, Aug 23, 2019 at 9:54 AM Krzysztof Kozlowski wrote: > > > > Convert Samsung Exynos Power Management Unit (PMU) bindings to DT schema > > format using json-schema. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > .../devicetree/bindings/arm/samsung/pmu.txt | 72 -------------- > > .../devicetree/bindings/arm/samsung/pmu.yaml | 93 +++++++++++++++++++ > > 2 files changed, 93 insertions(+), 72 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt > > create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > new file mode 100644 > > index 000000000000..818c6f3488ef > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > @@ -0,0 +1,93 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/samsung/pmu.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung Exynos SoC series Power Management Unit (PMU) > > + > > +maintainers: > > + - Krzysztof Kozlowski > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - samsung,exynos3250-pmu > > + - samsung,exynos4210-pmu > > + - samsung,exynos4412-pmu > > + - samsung,exynos5250-pmu > > + - samsung,exynos5260-pmu > > + - samsung,exynos5410-pmu > > + - samsung,exynos5420-pmu > > + - samsung,exynos5433-pmu > > + - samsung,exynos7-pmu > > + - const: syscon > > + > > + reg: > > + maxItems: 1 > > + > > + '#clock-cells': > > + const: 1 > > + > > + clock-names: > > + description: > > + list of clock names for particular CLKOUT mux inputs > > + # TODO: what is the maximum number of elements (mux inputs)? > > + minItems: 1 > > + maxItems: 32 > > + items: > > + - enum: > > This isn't correct as you are only defining possible names for the > first item. Drop the '-' (making items a schema instead of a list) and > then it applies to all. However, doing that will cause a meta-schema > error which I need to fix to allow. Or if there's a small set of > possibilities of number of inputs, you can list them under a 'oneOf' > list. Mhmm, I cannot test it or I have an error in the schema. if I understand correctly, this would be: clock-names: description: List of clock names for particular CLKOUT mux inputs minItems: 1 maxItems: 16 items: clkout0 clkout1 clkout2 clkout3 clkout4 clkout5 clkout6 clkout7 clkout8 clkout9 clkout10 clkout11 clkout12 clkout13 clkout14 clkout15 clkout16 Now it produces the error "ignoring, error in schema 'items'" but maybe it is expected with current meta-schema? Best regards, Krzysztof