From: Rob Herring <robh@kernel.org>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"a.zummo@towertech.it" <a.zummo@towertech.it>,
"broonie@kernel.org" <broonie@kernel.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
linux-power <linux-power@fi.rohmeurope.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 06/17] dt_bindings: regulator: Add ROHM BD71815 PMIC regulators
Date: Tue, 9 Feb 2021 07:50:52 -0600 [thread overview]
Message-ID: <CAL_JsqJXWkBJKPYm0SwWp03pYbwXUBziBF5B5nZ1tX8TnK7W7g@mail.gmail.com> (raw)
In-Reply-To: <0534345fdba452baefed4ad740a51d394b2ac423.camel@fi.rohmeurope.com>
On Tue, Feb 9, 2021 at 7:10 AM Vaittinen, Matti
<Matti.Vaittinen@fi.rohmeurope.com> wrote:
>
> Hello Again Rob,
>
> And thanks for reviewing the bindings!
>
> On Mon, 2021-02-08 at 20:24 -0600, Rob Herring wrote:
> > On Tue, Jan 19, 2021 at 09:17:09AM +0200, Matti Vaittinen wrote:
> > > Add binding documentation for regulators on ROHM BD71815 PMIC.
> > > 5 bucks, 7 LDOs and a boost for LED.
> > >
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > ---
>
> snip
>
> > > +
> > > + rohm,dvs-run-voltage:
> >
> > Use standard unit suffix.
> >
> > > + description:
> > > + PMIC "RUN" state voltage in uV when PMIC HW states are
> > > used. See
> > > + comments below for bucks/LDOs which support this. 0
> > > means
> > > + regulator should be disabled at RUN state.
> > > + $ref: "/schemas/types.yaml#/definitions/uint32"
> >
> > And then drop this.
>
> Quote from v1 review:
>
> > > > > > > + rohm,dvs-run-voltage:
> > > > > >
> > > > > > These should have a unit suffix.
> > > > >
> > > > > I know but these are existing properties. I'd like to re-use
> them
> > > > > as
> > > > > they have exported parser helpers - and I am unsure what kind
> of
> > > > > breakages changing them would cause. (The BD71837/BD71847 which
> > > > > introduced these properties are one of the PMICs which are
> pretty
> > > > > widely used.)
> > > >
> > > > Okay. Hopefully I remember next time I see this...
> > >
> > > Actually, I think I can add support for rohm,dvs-run-microvolt and
> > > fellows to these same helpers so new devices can use appropriately
> > > named properties. That would mean there is duplicate properties for
> > > same purpose - but maybe it allows us to eventually deprecate the
> old
> > > ones... Which of these options would you prefer?
> >
> > Just keep the existing ones.
>
> Seem you predicted this XD If you still think it's Ok to keep the
> existing ones, then I'll take this an ack, Ok?
Ah right,
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-02-09 13:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 7:13 [PATCH v2 00/17] Support ROHM BD71815 PMIC Matti Vaittinen
2021-01-19 7:14 ` [PATCH v2 01/17] regulator: bd718x7, bd71828, Fix dvs voltage levels Matti Vaittinen
2021-01-19 7:14 ` [PATCH v2 02/17] rtc: bd70528: Do not require parent data Matti Vaittinen
2021-01-19 21:09 ` Alexandre Belloni
2021-01-20 6:37 ` Matti Vaittinen
2021-01-19 7:15 ` [PATCH v2 03/17] clk: BD718x7: Do not depend on parent driver data Matti Vaittinen
2021-01-19 7:15 ` [PATCH v2 04/17] mfd: bd718x7: simplify by cleaning unnecessary device data Matti Vaittinen
2021-01-25 13:56 ` Lee Jones
2021-01-19 7:16 ` [PATCH v2 05/17] dt_bindings: bd71828: Add clock output mode Matti Vaittinen
2021-02-09 2:22 ` Rob Herring
2021-01-19 7:17 ` [PATCH v2 06/17] dt_bindings: regulator: Add ROHM BD71815 PMIC regulators Matti Vaittinen
2021-02-09 2:24 ` Rob Herring
2021-02-09 13:10 ` Vaittinen, Matti
2021-02-09 13:50 ` Rob Herring [this message]
2021-01-19 7:21 ` [PATCH v2 07/17] dt_bindings: mfd: Add ROHM BD71815 PMIC Matti Vaittinen
2021-02-09 2:26 ` Rob Herring
2021-01-19 7:21 ` [PATCH v2 08/17] mfd: Add ROHM BD71815 ID Matti Vaittinen
2021-01-25 13:57 ` Lee Jones
2021-01-19 7:22 ` [PATCH v2 09/17] mfd: Support for ROHM BD71815 PMIC core Matti Vaittinen
2021-01-25 14:10 ` Lee Jones
2021-01-25 14:48 ` Matti Vaittinen
2021-01-26 8:29 ` Lee Jones
2021-01-19 7:23 ` [PATCH v2 10/17] gpio: support ROHM BD71815 GPOs Matti Vaittinen
2021-01-19 11:07 ` Bartosz Golaszewski
2021-01-19 13:01 ` Vaittinen, Matti
2021-03-23 9:57 ` Vaittinen, Matti
2021-03-26 14:44 ` Bartosz Golaszewski
2021-01-19 7:31 ` [PATCH v2 16/17] rtc: bd70528: Support RTC on ROHM BD71815 Matti Vaittinen
2021-01-19 21:10 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJXWkBJKPYm0SwWp03pYbwXUBziBF5B5nZ1tX8TnK7W7g@mail.gmail.com \
--to=robh@kernel.org \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux-rtc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).