From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D355CC3A5A2 for ; Tue, 3 Sep 2019 08:25:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8DCC23401 for ; Tue, 3 Sep 2019 08:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567499117; bh=f3ZXaegcsrrqhqRDRKGqx4s4cVnRArE7RmypILYd+g8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=fZVEadfj8vbVh0SjT5wpcTToI1evn6VKQrXk8ewqYNOmmO//9Sp7JvFNYI3DUbaLm BsbANgq/mmvhzMxB+cTNjaRjUgTY1A/vGYJL1mREAtj6WJEMwcKvM3tKBqHgJckQaq Cd9YTkjWF7uJqbzSwUD23Ub/WLk0CmMz5E4tZebg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728074AbfICIZR (ORCPT ); Tue, 3 Sep 2019 04:25:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:56394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726946AbfICIZR (ORCPT ); Tue, 3 Sep 2019 04:25:17 -0400 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4ACB23402; Tue, 3 Sep 2019 08:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567499115; bh=f3ZXaegcsrrqhqRDRKGqx4s4cVnRArE7RmypILYd+g8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=wabHV1k5dEyrX/7adpcLxEwW1MB7sdRxtSAl/Q+ixCo+poiVeI7wlb7c8pmEkomba VUBXX9c9bK4EcJ2Rh1xAjjOW6eeil29NeZmenL+Lv7/KjHckb3WHRxEYYillGkJ9G9 qLA7PMTnlMqUtaKofcpPZkOnAPIPUWPD0G9OlK5o= Received: by mail-qt1-f174.google.com with SMTP id k10so8458253qth.2; Tue, 03 Sep 2019 01:25:15 -0700 (PDT) X-Gm-Message-State: APjAAAXXEucNZGmWiG31cCd8kIkK9e5dmFN6bGl74op4stTEi8jdKATy z+vlJ7//HqgK0Y0xgKL4g/H5E7AvPNScXdbolw== X-Google-Smtp-Source: APXvYqwIM9DiXxim6rM127j/POM2TKvL5qYklc3Bu+DdP6aV4fnCf6MCR6CZRi7sMcNn4eza859i00dqzSkL7gf1mNo= X-Received: by 2002:ac8:28b6:: with SMTP id i51mr8990758qti.143.1567499114797; Tue, 03 Sep 2019 01:25:14 -0700 (PDT) MIME-Version: 1.0 References: <20190823145356.6341-1-krzk@kernel.org> <20190823145356.6341-5-krzk@kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 3 Sep 2019 09:25:03 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 5/9] dt-bindings: arm: samsung: Convert Exynos PMU bindings to json-schema To: Krzysztof Kozlowski Cc: Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Alessandro Zummo , Alexandre Belloni , =?UTF-8?Q?Pawe=C5=82_Chmiel?= , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-samsung-soc , "linux-kernel@vger.kernel.org" , "open list:IIO SUBSYSTEM AND DRIVERS" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , notify@kernel.org, Arnd Bergmann , Olof Johansson , Marek Szyprowski , Tomasz Figa Content-Type: text/plain; charset="UTF-8" Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Tue, Sep 3, 2019 at 8:58 AM Krzysztof Kozlowski wrote: > > On Mon, 26 Aug 2019 at 13:54, Rob Herring wrote: > > > > On Fri, Aug 23, 2019 at 9:54 AM Krzysztof Kozlowski wrote: > > > > > > Convert Samsung Exynos Power Management Unit (PMU) bindings to DT schema > > > format using json-schema. > > > > > > Signed-off-by: Krzysztof Kozlowski > > > --- > > > .../devicetree/bindings/arm/samsung/pmu.txt | 72 -------------- > > > .../devicetree/bindings/arm/samsung/pmu.yaml | 93 +++++++++++++++++++ > > > 2 files changed, 93 insertions(+), 72 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt > > > create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > new file mode 100644 > > > index 000000000000..818c6f3488ef > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > @@ -0,0 +1,93 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/arm/samsung/pmu.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Samsung Exynos SoC series Power Management Unit (PMU) > > > + > > > +maintainers: > > > + - Krzysztof Kozlowski > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - enum: > > > + - samsung,exynos3250-pmu > > > + - samsung,exynos4210-pmu > > > + - samsung,exynos4412-pmu > > > + - samsung,exynos5250-pmu > > > + - samsung,exynos5260-pmu > > > + - samsung,exynos5410-pmu > > > + - samsung,exynos5420-pmu > > > + - samsung,exynos5433-pmu > > > + - samsung,exynos7-pmu > > > + - const: syscon > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + '#clock-cells': > > > + const: 1 > > > + > > > + clock-names: > > > + description: > > > + list of clock names for particular CLKOUT mux inputs > > > + # TODO: what is the maximum number of elements (mux inputs)? > > > + minItems: 1 > > > + maxItems: 32 > > > + items: > > > + - enum: > > > > This isn't correct as you are only defining possible names for the > > first item. Drop the '-' (making items a schema instead of a list) and > > then it applies to all. However, doing that will cause a meta-schema > > error which I need to fix to allow. Or if there's a small set of > > possibilities of number of inputs, you can list them under a 'oneOf' > > list. > > Mhmm, I cannot test it or I have an error in the schema. if I > understand correctly, this would be: > > clock-names: > description: > List of clock names for particular CLKOUT mux inputs > minItems: 1 > maxItems: 16 > items: > clkout0 > clkout1 > clkout2 > clkout3 > clkout4 > clkout5 > clkout6 > clkout7 > clkout8 > clkout9 > clkout10 > clkout11 > clkout12 > clkout13 > clkout14 > clkout15 > clkout16 > > Now it produces the error "ignoring, error in schema 'items'" but > maybe it is expected with current meta-schema? 'make dt_binding_check' will give more detailed errors. Are the inputs always contiguous 0-N? If so, you want: items: - const: clkout0 - const: clkout1 - const: clkout2 ... If you want to express any number and order of strings is valid, then you need: items: enum: - clkout0 - clkout1 - clkout2 Doing that is discouraged for bindings though. Currently, it will generate an error from the meta-schema, but we could change that. Rob