From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC407C43140 for ; Fri, 6 Sep 2019 15:49:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACADF21670 for ; Fri, 6 Sep 2019 15:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567784953; bh=Jr5kgXqyWS7nh52NwJvOior0lys98UCdmbOdcfTtNDg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Yqv2l5v7uW8/qK9mSoclpLY2wV3woI3TG+pAhlbClbu+lM0bN8d5hHSOlqMnU9C1K SQhiMLFdwHFFH/fakjVByp6ZOOIA1bbiK0nX/kAy/xgmOM9Bis6ZvKjcBZgPEYOdz3 04zjWeQWuVlsCS9II2R32Xejn72oenTyMUdZe0Rs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393074AbfIFPtJ (ORCPT ); Fri, 6 Sep 2019 11:49:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:33128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732456AbfIFPtH (ORCPT ); Fri, 6 Sep 2019 11:49:07 -0400 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AED7821835; Fri, 6 Sep 2019 15:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567784945; bh=Jr5kgXqyWS7nh52NwJvOior0lys98UCdmbOdcfTtNDg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=CWy0XUtdMPK4ldm+ALO4hNc9NhMkC9KZQ0dMR1c4PcYhArloTT5P2R24zCBNE9WW8 mBW9uvEmpTGaJ4qOV83YYHyVA4xMuTO9ivrxhgE4dlY0rFEBVv5g9IKT3JyRpI1YW9 NhVjc/T1ubb6yDj8dA0KJaL+l37rTDRrAa6opxMo= Received: by mail-qt1-f172.google.com with SMTP id l22so7504442qtp.10; Fri, 06 Sep 2019 08:49:05 -0700 (PDT) X-Gm-Message-State: APjAAAV0vJIUhvJntZ2ZvXevj3MXhxXkwwrO97Q4vJIgksAAEt2MVbe9 4fjSQBuERe/1pdMhADPy00nd/aD0uy7VFgF+xQ== X-Google-Smtp-Source: APXvYqzOFUgh8GnB6rG6hXcILzhLec0cs9V0M4FXVh+YnJXdDppWGYwFW7NZzD11jYW/qoY7azAhk18Zu9nuUkLC+F4= X-Received: by 2002:ac8:100d:: with SMTP id z13mr3818851qti.224.1567784944824; Fri, 06 Sep 2019 08:49:04 -0700 (PDT) MIME-Version: 1.0 References: <20190823145356.6341-1-krzk@kernel.org> <20190823145356.6341-5-krzk@kernel.org> In-Reply-To: From: Rob Herring Date: Fri, 6 Sep 2019 16:48:53 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 5/9] dt-bindings: arm: samsung: Convert Exynos PMU bindings to json-schema To: Krzysztof Kozlowski Cc: Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Alessandro Zummo , Alexandre Belloni , =?UTF-8?Q?Pawe=C5=82_Chmiel?= , devicetree@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-samsung-soc , "linux-kernel@vger.kernel.org" , "open list:IIO SUBSYSTEM AND DRIVERS" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , notify@kernel.org, Arnd Bergmann , Olof Johansson , Marek Szyprowski , Tomasz Figa Content-Type: text/plain; charset="UTF-8" Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Tue, Sep 3, 2019 at 12:03 PM Krzysztof Kozlowski wrote: > > On Tue, 3 Sep 2019 at 10:25, Rob Herring wrote: > > > > On Tue, Sep 3, 2019 at 8:58 AM Krzysztof Kozlowski wrote: > > > > > > On Mon, 26 Aug 2019 at 13:54, Rob Herring wrote: > > > > > > > > On Fri, Aug 23, 2019 at 9:54 AM Krzysztof Kozlowski wrote: > > > > > > > > > > Convert Samsung Exynos Power Management Unit (PMU) bindings to DT schema > > > > > format using json-schema. > > > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > --- > > > > > .../devicetree/bindings/arm/samsung/pmu.txt | 72 -------------- > > > > > .../devicetree/bindings/arm/samsung/pmu.yaml | 93 +++++++++++++++++++ > > > > > 2 files changed, 93 insertions(+), 72 deletions(-) > > > > > delete mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt > > > > > create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > new file mode 100644 > > > > > index 000000000000..818c6f3488ef > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > @@ -0,0 +1,93 @@ > > > > > +# SPDX-License-Identifier: GPL-2.0 > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: http://devicetree.org/schemas/arm/samsung/pmu.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: Samsung Exynos SoC series Power Management Unit (PMU) > > > > > + > > > > > +maintainers: > > > > > + - Krzysztof Kozlowski > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + items: > > > > > + - enum: > > > > > + - samsung,exynos3250-pmu > > > > > + - samsung,exynos4210-pmu > > > > > + - samsung,exynos4412-pmu > > > > > + - samsung,exynos5250-pmu > > > > > + - samsung,exynos5260-pmu > > > > > + - samsung,exynos5410-pmu > > > > > + - samsung,exynos5420-pmu > > > > > + - samsung,exynos5433-pmu > > > > > + - samsung,exynos7-pmu > > > > > + - const: syscon > > > > > + > > > > > + reg: > > > > > + maxItems: 1 > > > > > + > > > > > + '#clock-cells': > > > > > + const: 1 > > > > > + > > > > > + clock-names: > > > > > + description: > > > > > + list of clock names for particular CLKOUT mux inputs > > > > > + # TODO: what is the maximum number of elements (mux inputs)? > > > > > + minItems: 1 > > > > > + maxItems: 32 > > > > > + items: > > > > > + - enum: > > > > > > > > This isn't correct as you are only defining possible names for the > > > > first item. Drop the '-' (making items a schema instead of a list) and > > > > then it applies to all. However, doing that will cause a meta-schema > > > > error which I need to fix to allow. Or if there's a small set of > > > > possibilities of number of inputs, you can list them under a 'oneOf' > > > > list. > > > > > > Mhmm, I cannot test it or I have an error in the schema. if I > > > understand correctly, this would be: > > > > > > clock-names: > > > description: > > > List of clock names for particular CLKOUT mux inputs > > > minItems: 1 > > > maxItems: 16 > > > items: > > > clkout0 > > > clkout1 > > > clkout2 > > > clkout3 > > > clkout4 > > > clkout5 > > > clkout6 > > > clkout7 > > > clkout8 > > > clkout9 > > > clkout10 > > > clkout11 > > > clkout12 > > > clkout13 > > > clkout14 > > > clkout15 > > > clkout16 > > > > > > Now it produces the error "ignoring, error in schema 'items'" but > > > maybe it is expected with current meta-schema? > > > > 'make dt_binding_check' will give more detailed errors. > > > > Are the inputs always contiguous 0-N? If so, you want: > > > > items: > > - const: clkout0 > > - const: clkout1 > > - const: clkout2 > > ... > > > > If you want to express any number and order of strings is valid, then you need: > > > > items: > > enum: > > - clkout0 > > - clkout1 > > - clkout2 > > > > Doing that is discouraged for bindings though. Currently, it will > > generate an error from the meta-schema, but we could change that. > > It's the second case. The inputs are not contiguous. Examples: > > system-controller { > compatible = "samsung,exynos3250-pmu", "syscon"; > clock-names = "clkout8"; > clocks = <&cmu CLK_FIN_PLL>; > } > > system-controller { > compatible = "samsung,exynos4412-pmu", "syscon"; > clock-names = "clkout0", "clkout1", "clkout2", "clkout3", > "clkout4", "clkout8", "clkout9"; > clocks = <&clock CLK_OUT_DMC>, <&clock CLK_OUT_TOP>, > <&clock CLK_OUT_LEFTBUS>, <&clock CLK_OUT_RIGHTBUS>, > <&clock CLK_OUT_CPU>, <&clock CLK_XXTI>, <&clock CLK_XUSBXTI>; > } > > The bindings never required any specific ordering. Also the driver > just go through all indices and parses them. > > Your second syntax fails: > Documentation/devicetree/bindings/arm/samsung/pmu.yaml: > properties:clock-names:items: {'enum': ['clkout0', 'clkout1', > 'clkout2', 'clkout3', 'clkout4', 'clkout5', 'clkout6', 'clkout7', > 'clkout8', 'clkout9', 'clkout10', 'clkout11', 'clkout12', 'clkout13', > 'clkout14', 'clkout15', 'clkout16']} is not of type 'array' Update dt-schema and try again. It should be allowed now. You'll also need to define minItems and maxItems though. Rob