From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8199FC4CECD for ; Tue, 17 Sep 2019 01:13:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E95320678 for ; Tue, 17 Sep 2019 01:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568682803; bh=0Jj0ktCFmYGyjaVUlwUqQ0RP1WWgHi1nZHfaZalsFFM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=hE9XwEk0c97BpC/+X3I8OcXiMXtj9bUDUqRKQl43TA/0I25o6af4EavMcqwvSHRBn aM42DzrZBc/j6BHi/sWp6juN3FartQzfMeHW2uLItVJmR/Y2RwRUxkIT/ukBT5scfQ 0TFL94Iyp7abIFMPOvjFaFe6f2iTAnwS/AFqQvvs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390962AbfIQBNT (ORCPT ); Mon, 16 Sep 2019 21:13:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:35164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390703AbfIQBNT (ORCPT ); Mon, 16 Sep 2019 21:13:19 -0400 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0497C214D9; Tue, 17 Sep 2019 01:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568682798; bh=0Jj0ktCFmYGyjaVUlwUqQ0RP1WWgHi1nZHfaZalsFFM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FMmkBmxC3EA5LqT65REpwgkPz7s0+QqiQ/TxvARVos0Yy1DLiMKIgifI+3O6POG3U 8VakYmZrGheycO9jVFO9Pukp4TEga1USGqocsEDE/hfexrYIMMJ9tOA1x+9MhtxQY8 QZ++CWByN9OMjaVWwNP2xia7PrHXr00ShaDYQYus= Received: by mail-qk1-f176.google.com with SMTP id q203so2123951qke.1; Mon, 16 Sep 2019 18:13:17 -0700 (PDT) X-Gm-Message-State: APjAAAXR/k/lxVtNchTYgWeb72SWVW+uHZ1qDcnFQfQZzCqkiJVh9k1A Ic9EcxyTefUDm/rvm2zR9kIFXbz4lYxpgnE7QQ== X-Google-Smtp-Source: APXvYqxh/EHVJtafQ7KBx5QHUfJw1ZTMbha75iR+Ijrlr48Fb1OqPt/etc8xe0M738IC1XA80mf/hiZEFWMElayn3fg= X-Received: by 2002:a37:be87:: with SMTP id o129mr1294180qkf.254.1568682797178; Mon, 16 Sep 2019 18:13:17 -0700 (PDT) MIME-Version: 1.0 References: <20190910104247.13142-1-biwen.li@nxp.com> In-Reply-To: <20190910104247.13142-1-biwen.li@nxp.com> From: Rob Herring Date: Mon, 16 Sep 2019 20:13:06 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v4,1/2] dt-bindings: rtc: pcf85263/pcf85363: add some properties To: Biwen Li Cc: Alessandro Zummo , Alexandre Belloni , Mark Rutland , Yang-Leo Li , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, Martin Fuzzey Content-Type: text/plain; charset="UTF-8" Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Tue, Sep 10, 2019 at 5:53 AM Biwen Li wrote: > > Add some properties for pcf85263/pcf85363 as follows: > - nxp,rtc-interrupt-type: integer type > - nxp,rtc-interrupt-output-pin: string type > - quartz-load-femtofarads: integer type > - nxp,quartz-drive-strength: integer type > - nxp,quartz-low-jitter: bool type > - wakeup-source: bool type > > Signed-off-by: Martin Fuzzey > Signed-off-by: Biwen Li > --- > Change in v4: > - Drop robust defines in include/dt-bindings/rtc/pcf85363.h > - Add nxp,rtc-interrupt-type property > - Replace interrupt-output-pin with nxp,rtc-interrupt-output-pin > > Change in v3: > - None > > Change in v2: > - Replace properties name > quartz-load-capacitance -> quartz-load-femtofarads > quartz-drive-strength -> nxp,quartz-drive-strength > quartz-low-jitter -> nxp,quartz-low-jitter > - Replace drive strength name > PCF85263_QUARTZDRIVE_NORMAL -> PCF85263_QUARTZDRIVE_100ko > PCF85263_QUARTZDRIVE_LOW -> PCF85263_QUARTZDRIVE_60ko > PCF85263_QUARTZDRIVE_HIGH -> PCF85263_QUARTZDRIVE_500ko > - Set default interrupt-output-pin as "INTA" > > .../devicetree/bindings/rtc/pcf85363.txt | 44 ++++++++++++++++++- > include/dt-bindings/rtc/pcf85363.h | 14 ++++++ > 2 files changed, 57 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/rtc/pcf85363.h > > diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt b/Documentation/devicetree/bindings/rtc/pcf85363.txt > index 94adc1cf93d9..fc1579463657 100644 > --- a/Documentation/devicetree/bindings/rtc/pcf85363.txt > +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt > @@ -8,10 +8,52 @@ Required properties: > Optional properties: > - interrupts: IRQ line for the RTC (not implemented). > > +- nxp,rtc-interrupt-type: integer property, represent the interrupt's > + type. Valid values are > + INT_PIE(periodic interrupt enable), > + INT_OIE(offset correction interrupt enable), > + INT_A1IE(alarm1 interrupt enable), > + INT_A2IE(alarm2 interrupt enable), > + INT_TSRIE(timestamp register interrupt enable) > + INT_BSIE(battery switch interrupt enable), > + INT_WDIE(WatchDog interrupt enable,and > + compose these values such as: INT_A1IE | INT_A2IE, > + but currently only support INT_A1IE, default value is INT_A1IE. > + The property and property nxp,rtc-interrupt-output-pin > + work together to generate some interrupts on some pins. > + > +- nxp,rtc-interrupt-output-pin: The interrupt output pin must be > + "INTA" or "INTB", default value is "INTA". The property and property > + nxp,rtc-interrupt-type work together to generate some interrupts on > + some pins. > + > +- quartz-load-femtofarads: The internal capacitor to select for the quartz, > + expressed in femto Farad (fF). Valid values are 6000, 7000 and 12500. > + Default value is 12500fF. > + > +- nxp,quartz-drive-strength: Drive strength for the quartz, > + expressed in kilo ohms (kOhm) Valid values are 60, 100 and 500. > + Default value is 100kOhm. This needs a unit as defined in property-units.txt. > + > +- nxp,quartz-low-jitter: Boolean property, if present enables low jitter mode > + which reduces jitter at the cost of increased power consumption. > + > +- wakeup-source: Boolean property, Please refer to > + Documentation/devicetree/bindings/power/wakeup-source.txt > + > Example: > > pcf85363: pcf85363@51 { > compatible = "nxp,pcf85363"; > reg = <0x51>; > -}; > > + interrupt-parent = <&gpio1>; > + interrupts = <18 IRQ_TYPE_EDGE_FALLING>; > + > + wakeup-source; > + nxp,rtc-interrupt-output-pin = "INTA"; > + nxp,rtc-interrupt-type = ; > + quartz-load-femtofarads = <12500>; > + nxp,quartz-drive-strength = <60>; > + nxp,quartz-low-jitter; > +}; > diff --git a/include/dt-bindings/rtc/pcf85363.h b/include/dt-bindings/rtc/pcf85363.h > new file mode 100644 > index 000000000000..6340bf2da8f5 > --- /dev/null > +++ b/include/dt-bindings/rtc/pcf85363.h > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _DT_BINDINGS_RTC_PCF85363_H > +#define _DT_BINDINGS_RTC_PCF85363_H > + > +/* Interrupt type */ > +#define INT_WDIE (1 << 0) > +#define INT_BSIE (1 << 1) > +#define INT_TSRIE (1 << 2) > +#define INT_A2IE (1 << 3) > +#define INT_A1IE (1 << 4) > +#define INT_OIE (1 << 5) > +#define INT_PIE (1 << 6) > + > +#endif /* _DT_BINDINGS_RTC_PCF85363_H */ > -- > 2.17.1 >