From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D15EC33CAE for ; Mon, 13 Jan 2020 07:57:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D6D302075B for ; Mon, 13 Jan 2020 07:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbgAMH5m (ORCPT ); Mon, 13 Jan 2020 02:57:42 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:40596 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728679AbgAMH5m (ORCPT ); Mon, 13 Jan 2020 02:57:42 -0500 Received: by mail-oi1-f195.google.com with SMTP id c77so7407076oib.7; Sun, 12 Jan 2020 23:57:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DFM30rCzTPD/hJIn8LUYKQwpr92u3LKGP51jLhCQjVY=; b=ZybdAP7tfsJ8wVSBAn+5hN+2T2a6q1UYre6YwHnw42rzXxSXxS5ZdaryVwia2SPWBX p+VMqRf2jBdMetOOuS+3ktLU4g4GvnaH6XuDGC0dP2WwHCsRLGK6OVSzwgnxkCDFYc4z hZFCHsRq19lqhq9bfa+5rWW2oGu8ymu/49pekjd5W6zTxx0V8qaVE20HsKcsAOCPm96x WGWo3EyCcJr7nMHYFTrW5pF0mRV7cTAWGgJRRg5HIggjfRsQ0ktKuvIznjatufkx2vII loS7+fkGvcOnp1ENOpw2fYsJ+LDC4eOkjIs3vqEA+d9di6yZeKG0d/UuQ2UqQ2yMZNbK IE6A== X-Gm-Message-State: APjAAAXR1wsGwj5vulfOONCyf5kzm81v0XYjxGd0XdNnWdsbJMdN8asQ M3UBnsCpCMN69Q1zQ4UwMriJ7wWa8NVmOnwMzBM= X-Google-Smtp-Source: APXvYqxULVjUkTLzZzNE8RwsGd03pA2wKpaS8gX8AGzJf6sEPx0G/vK4vcDHJVnM41bLpOC02QyfdCvc+cIVjxwostg= X-Received: by 2002:aca:5905:: with SMTP id n5mr12100117oib.54.1578902261273; Sun, 12 Jan 2020 23:57:41 -0800 (PST) MIME-Version: 1.0 References: <20200112171349.22268-1-geert@linux-m68k.org> <9286d81a883f4795176182fdb9e69bc19a8232c7.camel@perches.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 13 Jan 2020 08:57:30 +0100 Message-ID: Subject: Re: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed To: Joe Perches Cc: Alessandro Zummo , Alexandre Belloni , Akinobu Mita , linux-rtc@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Hi Joe, On Mon, Jan 13, 2020 at 8:41 AM Joe Perches wrote: > On Mon, 2020-01-13 at 08:25 +0100, Geert Uytterhoeven wrote: > > On Mon, Jan 13, 2020 at 7:36 AM Joe Perches wrote: > > > On Sun, 2020-01-12 at 18:13 +0100, Geert Uytterhoeven wrote: > > > > Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when > > > > no driver needs it. While the former can be moduler, the latter cannot, > > > > and thus becomes built-in. > > > > > > > > Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI > > > > from the RTC_I2C_AND_SPI helper to the individual drivers that depend on > > > > it. > > > > > > > > Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI > > > > for more information, but the latter does not select REGMAP_{I2C,SPI} > > > > itself, and defers that to the individual drivers, too. > > > > > > > > Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234") > > > > Signed-off-by: Geert Uytterhoeven > > > > --- > > > > Joe: When merging addresses, scripts/get_maintainer.pl replaces > > > > Alexandre's authoritative email address from MAINTAINERS by the > > > > obsolete address in the SoB-line of the commit referred to by the > > > > Fixes-line. > > > > > > Hi Geert > > > > > > What are you doing to get this changed output? > > > > scripts/get_maintainer.pl > > 0001-rtc-i2c-spi-Avoid-inclusion-of-REGMAP-support-when-n.patch > > > > > I get the same get_maintainer address output either way > > > with only with the 'blamed_fixes:' content added. > > > > Thanks, I can confirm it's fixed in next-20200110. > > With v5.5-rc6, it still gives the old addresss. > > Well, OK, get_maintainer is the same but there is a > different .mailmap in -next Indeed. However, I think the precedence should be MAINTAINERS > .mailmap > SoB in referenced commit instead of .mailmap > SoB in referenced commit > MAINTAINERS Do you agree? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds