Linux-RTC Archive on
 help / color / Atom feed
From: Geert Uytterhoeven <>
To: Kars de Jong <>
Cc: Alessandro Zummo <>,
	Alexandre Belloni <>,,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH] rtc: msm6242: Fix reading of 10-hour digit
Date: Mon, 18 Nov 2019 15:14:46 +0100
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, Nov 16, 2019 at 12:06 PM Kars de Jong <> wrote:
> The driver was reading the wrong register as the 10-hour digit due to
> a misplaced ')'. It was in fact reading the 1-second digit register due
> to this bug.
> Also remove the use of a magic number for the hour mask and use the define
> for it which was already present.
> Cc: Geert Uytterhoeven <>
> Tested-by: Kars de Jong <>
> Signed-off-by: Kars de Jong <>

Reviewed-by: Geert Uytterhoeven <>



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-16 11:05 Kars de Jong
2019-11-16 11:17 ` Kars de Jong
2019-11-18 14:14 ` Geert Uytterhoeven [this message]
2019-11-18 14:18 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RTC Archive on

Archives are clonable:
	git clone --mirror linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ \
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone