From: Anson Huang <anson.huang@nxp.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "a.zummo@towertech.it" <a.zummo@towertech.it>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
Andy Gross <andy.gross@linaro.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
"heiko@sntech.de" <heiko@sntech.de>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
"amit.kucheria@linaro.org" <amit.kucheria@linaro.org>,
"ezequiel@collabora.com" <ezequiel@collabora.com>,
"olof@lixom.net" <olof@lixom.net>,
"LW@KARO-electronics.de" <LW@KARO-electronics.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V4 2/4] rtc: add i.MX system controller RTC support
Date: Wed, 19 Dec 2018 09:37:44 +0000 [thread overview]
Message-ID: <DB3PR0402MB39167296BD1302130B537FD7F5BE0@DB3PR0402MB3916.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20181219085429.GJ19816@piout.net>
Hi, Alexandre
Best Regards!
Anson Huang
> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni@bootlin.com]
> Sent: 2018年12月19日 16:54
> To: Anson Huang <anson.huang@nxp.com>
> Cc: a.zummo@towertech.it; robh+dt@kernel.org; mark.rutland@arm.com;
> catalin.marinas@arm.com; will.deacon@arm.com; Aisheng Dong
> <aisheng.dong@nxp.com>; Andy Gross <andy.gross@linaro.org>;
> arnd@arndb.de; horms+renesas@verge.net.au; heiko@sntech.de;
> bjorn.andersson@linaro.org; enric.balletbo@collabora.com;
> amit.kucheria@linaro.org; ezequiel@collabora.com; olof@lixom.net;
> LW@KARO-electronics.de; shawnguo@kernel.org; linux-rtc@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V4 2/4] rtc: add i.MX system controller RTC support
>
> Hello,
>
> On 29/11/2018 01:50:11+0000, Anson Huang wrote:
> > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller
> > inside, the system controller is in charge of controlling power, clock
> > and secure rtc etc..
> >
> > This patch adds i.MX system controller RTC driver support, Linux
> > kernel has to communicate with system controller via MU (message unit)
> > IPC to set/get RTC time and other alarm functions, since the RTC set
> > time needs to be done in secure EL3 mode (required by system
> > controller firmware) and alarm functions needs to be done with general
> > MU IRQ handle, these depend on other components which are NOT ready,
> > so this patch ONLY enables the RTC time read.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > ---
> > ChangeLog:
> > V3->V4:
> > *remove unnecessary headfile included;
> > *fix potential memory currpution for the message responce;
> > *update the compatible string name to start with "fsl" instead of "nxp".
> > drivers/rtc/Kconfig | 6 +++
> > drivers/rtc/Makefile | 1 +
> > drivers/rtc/rtc-imx-sc.c | 98
> > ++++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 105 insertions(+)
> > create mode 100644 drivers/rtc/rtc-imx-sc.c
> >
>
> I applied it on my test branch and this makes sparc64-allyesconfig fail
> with:
>
> drivers/rtc/rtc-imx-sc.o: In function `imx_sc_rtc_read_time':
> rtc-imx-sc.c:(.text+0x34): undefined reference to `imx_scu_call_rpc'
> drivers/rtc/rtc-imx-sc.o: In function `imx_sc_rtc_probe':
> rtc-imx-sc.c:(.text+0x90): undefined reference to `imx_scu_get_handle'
Maybe there are some changes on basic support of imx scu driver, I will resend
a patch set later, thanks.
Anson.
>
>
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootl
> in.com&data=02%7C01%7Canson.huang%40nxp.com%7C72b147643a3f
> 44c258c208d6658f9cce%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C636808064818797711&sdata=%2Bl5jGXX6wBYbOg5Zalg4CyxyZKjUe
> uzRSQEKO9TJnRI%3D&reserved=0
next prev parent reply other threads:[~2018-12-19 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 1:49 [PATCH V4 0/4] Add i.MX system controller RTC driver Anson Huang
2018-11-29 1:50 ` [PATCH V4 1/4] dt-bindings: fsl: scu: add rtc binding Anson Huang
2018-12-10 22:22 ` Rob Herring
2018-11-29 1:50 ` [PATCH V4 2/4] rtc: add i.MX system controller RTC support Anson Huang
2018-12-19 8:54 ` Alexandre Belloni
2018-12-19 9:37 ` Anson Huang [this message]
2018-12-19 9:48 ` Aisheng Dong
2018-12-19 10:17 ` Alexandre Belloni
2018-12-19 10:12 ` Aisheng Dong
2018-11-29 1:50 ` [PATCH V4 3/4] defconfig: arm64: " Anson Huang
2018-11-29 1:50 ` [PATCH V4 4/4] ARM64: dts: imx: add i.MX8QXP " Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0402MB39167296BD1302130B537FD7F5BE0@DB3PR0402MB3916.eurprd04.prod.outlook.com \
--to=anson.huang@nxp.com \
--cc=LW@KARO-electronics.de \
--cc=a.zummo@towertech.it \
--cc=aisheng.dong@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amit.kucheria@linaro.org \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=horms+renesas@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).