From: Biwen Li <biwen.li@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: "a.zummo@towertech.it" <a.zummo@towertech.it>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
Leo Li <leoyang.li@nxp.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Martin Fuzzey <mfuzzey@parkeon.com>
Subject: RE: [EXT] Re: [1/2] dt-bindings: rtc: pcf85263/pcf85363: add some properties
Date: Tue, 3 Sep 2019 02:15:56 +0000 [thread overview]
Message-ID: <DB7PR04MB4490460F9C011289CE85A0028FB90@DB7PR04MB4490.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <5d6d1b79.1c69fb81.29f0d.e042@mx.google.com>
>
> Caution: EXT Email
>
> On Fri, Aug 30, 2019 at 05:17:19PM +0800, Biwen Li wrote:
> > Add some properties for pcf85263/pcf85363 as follows:
> > - interrupt-output-pin: string type
> > - quartz-load-capacitance: integer type
> > - quartz-drive-strength: integer type
> > - quartz-low-jitter: bool type
> > - wakeup-source: bool type
> >
> > Signed-off-by: Martin Fuzzey <mfuzzey@parkeon.com>
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > ---
> > .../devicetree/bindings/rtc/pcf85363.txt | 31
> +++++++++++++++++++
> > include/dt-bindings/rtc/pcf85363.h | 15 +++++++++
> > 2 files changed, 46 insertions(+)
> > create mode 100644 include/dt-bindings/rtc/pcf85363.h
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt
> > b/Documentation/devicetree/bindings/rtc/pcf85363.txt
> > index 94adc1cf93d9..d83359990bd7 100644
> > --- a/Documentation/devicetree/bindings/rtc/pcf85363.txt
> > +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt
> > @@ -8,10 +8,41 @@ Required properties:
> > Optional properties:
> > - interrupts: IRQ line for the RTC (not implemented).
> >
> > +- interrupt-output-pin: The interrupt output pin must be
> > + "NONE", "INTA" or "INTB", default value is "NONE"
> > +
> > +- quartz-load-capacitance: The internal capacitor to select for the quartz:
> > + PCF85263_QUARTZCAP_7pF [0]
> > + PCF85263_QUARTZCAP_6pF [1]
> > + PCF85263_QUARTZCAP_12p5pF [2] DEFAULT
>
> We have a common property for this. Use it.
Ok, I will replace it in v2.
>
> > +
> > +- quartz-drive-strength: Drive strength for the quartz:
> > + PCF85263_QUARTZDRIVE_NORMAL [0] DEFAULT
> > + PCF85263_QUARTZDRIVE_LOW [1]
> > + PCF85263_QUARTZDRIVE_HIGH [2]
> > +
> > +- quartz-low-jitter: Boolean property, if present enables low jitter
> > +mode
> > + which reduces jitter at the cost of increased power consumption.
>
> These 2 need vendor prefixes.
Okay, I will add vendor prefixes in v2.
>
> > +
> > +- wakeup-source: Boolean property, mark the chip as a wakeup source,
> > + independently of the availability of an IRQ line connected to the SoC.
> > + This is useful if the IRQ line is connected to a PMIC or other
> > +circuit
> > + that can power up the device rather than to a normal SOC interrupt.
> > +
> > Example:
> >
> > pcf85363: pcf85363@51 {
> > compatible = "nxp,pcf85363";
> > reg = <0x51>;
> > +
> > + interrupt-parent = <&gpio1>;
> > + interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
> > +
> > + #include <dt-bindings/rtc/pcf85363.h>
> > + wakeup-source;
> > + interrupt-output-pin = "INTA";
> > + quartz-load-capacitance = <PCF85363_QUARTZCAP_12p5pF>;
> > + quartz-drive-strength = <PCF85363_QUARTZDRIVE_LOW>;
> > + quartz-low-jitter;
> > };
> >
> > diff --git a/include/dt-bindings/rtc/pcf85363.h
> > b/include/dt-bindings/rtc/pcf85363.h
> > new file mode 100644
> > index 000000000000..2c06c28eb5ff
> > --- /dev/null
> > +++ b/include/dt-bindings/rtc/pcf85363.h
> > @@ -0,0 +1,15 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */ #ifndef
> > +_DT_BINDINGS_RTC_PCF85363_H #define
> _DT_BINDINGS_RTC_PCF85363_H
> > +
> > +/* Quartz capacitance */
> > +#define PCF85363_QUARTZCAP_7pF 0
> > +#define PCF85363_QUARTZCAP_6pF 1
> > +#define PCF85363_QUARTZCAP_12p5pF 2
> > +
> > +/* Quartz drive strength */
> > +#define PCF85363_QUARTZDRIVE_NORMAL 0
> > +#define PCF85363_QUARTZDRIVE_LOW 1
> > +#define PCF85363_QUARTZDRIVE_HIGH 2
> > +
> > +#endif /* _DT_BINDINGS_RTC_PCF85363_H */
> > --
> > 2.17.1
> >
prev parent reply other threads:[~2019-09-03 2:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 9:17 [1/2] dt-bindings: rtc: pcf85263/pcf85363: add some properties Biwen Li
2019-08-30 9:17 ` [2/2] rtc: pcf85263/pcf85363: support PM, wakeup device, improve performance Biwen Li
2019-08-30 9:44 ` [1/2] dt-bindings: rtc: pcf85263/pcf85363: add some properties Alexandre Belloni
2019-08-30 10:11 ` [EXT] " Biwen Li
2019-09-02 13:39 ` Rob Herring
2019-09-03 2:15 ` Biwen Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR04MB4490460F9C011289CE85A0028FB90@DB7PR04MB4490.eurprd04.prod.outlook.com \
--to=biwen.li@nxp.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mfuzzey@parkeon.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).