Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
From: Biwen Li <biwen.li@nxp.com>
To: Leo Li <leoyang.li@nxp.com>,
	"a.zummo@towertech.it" <a.zummo@towertech.it>,
	"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w
Date: Thu, 15 Aug 2019 04:14:51 +0000
Message-ID: <DB7PR04MB449054F05411CBDC935605F28FAC0@DB7PR04MB4490.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <VE1PR04MB66875AF7A38BF43351970EB08FAD0@VE1PR04MB6687.eurprd04.prod.outlook.com>

> > Subject: rtc: pcf85363/pcf85263: fix error that failed to run hwclock
> > -w
> >
> > Issue:
> >     # hwclock -w
> >     hwclock: RTC_SET_TIME: Invalid argument
> >
> > The patch fixes error when run command hwclock -w with rtc
> > pcf85363/pcf85263
> 
> Can you explain a little bit more in the commit message on how the changes fix
> the above issue?   It is not that clear just from the code.
1. Relative patch: https://lkml.org/lkml/2019/4/3/55 , this patch will always
check for unwritable registers, it will compare reg with max_register in regmap_writeable.

2. In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS is 0, max_regiter is 0x2f,
then reg will be equal to 0x30, '0x30 < 0x2f' is false,so regmap_writeable will return false.

> 
> >
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > ---
> >  drivers/rtc/rtc-pcf85363.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/rtc/rtc-pcf85363.c b/drivers/rtc/rtc-pcf85363.c
> > index a075e77617dc..3450d615974d 100644
> > --- a/drivers/rtc/rtc-pcf85363.c
> > +++ b/drivers/rtc/rtc-pcf85363.c
> > @@ -166,7 +166,12 @@ static int pcf85363_rtc_set_time(struct device
> > *dev, struct rtc_time *tm)
> >  	buf[DT_YEARS] = bin2bcd(tm->tm_year % 100);
> >
> >  	ret = regmap_bulk_write(pcf85363->regmap, CTRL_STOP_EN,
> > -				tmp, sizeof(tmp));
> > +				tmp, 2);
> > +	if (ret)
> > +		return ret;
> > +
> > +	ret = regmap_bulk_write(pcf85363->regmap, DT_100THS,
> > +				buf, sizeof(tmp) - 2);
> >  	if (ret)
> >  		return ret;
> >
> > --
> > 2.17.1


  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14  9:32 Biwen Li
2019-08-14 10:09 ` Alexandre Belloni
2019-08-15  4:20   ` [EXT] " Biwen Li
2019-08-14 18:39 ` Leo Li
2019-08-15  4:14   ` Biwen Li [this message]
2019-08-15 18:01     ` Leo Li
2019-08-16  2:40       ` Biwen Li

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR04MB449054F05411CBDC935605F28FAC0@DB7PR04MB4490.eurprd04.prod.outlook.com \
    --to=biwen.li@nxp.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org linux-rtc@archiver.kernel.org
	public-inbox-index linux-rtc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox