Re: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)

Re: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)

[Randy Dunlap]

On 7/17/20 4:40 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20200716:
> 
> New tree: init
> Changed tree: dmi (from quilt to git)
> 
> My fixes tree contains:
> 
>   dbf24e30ce2e ("device_cgroup: Fix RCU list debugging warning")
> 
> I revreted 3 commits from the powerpc tree due to reported run time
> problems.
> 
> The sound tree gained a semantic conflict against the dma-mapping tree.
> 
> The security tree still had its build failure for which I applied a patch.
> 
> The tip tree still had one build failure for which I reverted a commit.
> It also gained a conflict against the crypto tree
> 
> The kvm tree gained a conflict and a semantic conflict against the
> tip tree.
> 
> The dmaengine tree gained conflicts against the wireless-drivers-next
> and Linus' trees.
> 
> The pinctrl tree gained a build failure so I used the version from
> next-20200716.
> 
> The set_fs tree gained a conflict against the powerpc tree.
> 
> The init tree gained a conflict against the block tre.
> 
> The akpm-current tree gained conflicts against the crypto and tip trees.
> It also gained a build failure for which I applied a patch.
> 
> Non-merge commits (relative to Linus' tree): 8001
>  8717 files changed, 441636 insertions(+), 169176 deletions(-)
> 
> ----------------------------------------------------------------------------
> 
> I have created today's linux-next tree at
> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> (patches at http://www.kernel.org/pub/linux/kernel/next/ ).  If you
> are tracking the linux-next tree using git, you should not use "git pull"
> to do so as that will try to merge the new linux-next release with the
> old one.  You should use "git fetch" and checkout or reset to the new
> master.
> 
> You can see which trees have been included by looking in the Next/Trees
> file in the source.  There are also quilt-import.log and merge.log
> files in the Next directory.  Between each merge, the tree was built
> with a ppc64_defconfig for powerpc, an allmodconfig for x86_64, a
> multi_v7_defconfig for arm and a native build of tools/perf. After
> the final fixups (if any), I do an x86_64 modules_install followed by
> builds for x86_64 allnoconfig, powerpc allnoconfig (32 and 64 bit),
> ppc44x_defconfig, allyesconfig and pseries_le_defconfig and i386, sparc
> and sparc64 defconfig and htmldocs. And finally, a simple boot test
> of the powerpc pseries_le_defconfig kernel in qemu (with and without
> kvm enabled).
> 
> Below is a summary of the state of the merge.
> 
> I am currently merging 325 trees (counting Linus' and 83 trees of bug
> fix patches pending for the current merge release).
> 
> Stats about the size of the tree over time can be seen at
> http://neuling.org/linux-next-size.html .
> 
> Status of my local build tests will be at
> http://kisskb.ellerman.id.au/linux-next .  If maintainers want to give
> advice about cross compilers/configs that work, we are always open to add
> more builds.
> 
> Thanks to Randy Dunlap for doing many randconfig builds.  And to Paul
> Gortmaker for triage and bug fixes.
> 

on x86_64:
# CONFIG_WATCHDOG is not set

ld: drivers/rtc/rtc-ds1374.o: in function `ds1374_probe':
rtc-ds1374.c:(.text+0x736): undefined reference to `watchdog_init_timeout'
ld: rtc-ds1374.c:(.text+0x77e): undefined reference to `devm_watchdog_register_device'


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>

Re: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Hi Randy,

[Please trim your emails a bit more, thanks]

On Fri, 17 Jul 2020 09:49:05 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> on x86_64:
> # CONFIG_WATCHDOG is not set
> 
> ld: drivers/rtc/rtc-ds1374.o: in function `ds1374_probe':
> rtc-ds1374.c:(.text+0x736): undefined reference to `watchdog_init_timeout'
> ld: rtc-ds1374.c:(.text+0x77e): undefined reference to `devm_watchdog_register_device'

Caused by commit

  d3de4beb14a8 ("rtc: ds1374: wdt: Use watchdog core for watchdog part")

from the rtc tree.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)

[Johnson CH Chen (陳昭勳)]

Hi Stephen, 

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Saturday, July 18, 2020 9:39 AM
> To: Randy Dunlap <rdunlap@infradead.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing
> List <linux-kernel@vger.kernel.org>; linux-rtc@vger.kernel.org; Alessandro
> Zummo <a.zummo@towertech.it>; Alexandre Belloni
> <alexandre.belloni@bootlin.com>; Scott Wood <scottwood@freescale.com>;
> Johnson CH Chen (陳昭勳) <JohnsonCH.Chen@moxa.com>
> Subject: Re: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)
> 
> Hi Randy,
> 
> [Please trim your emails a bit more, thanks]
> 
> On Fri, 17 Jul 2020 09:49:05 -0700 Randy Dunlap <rdunlap@infradead.org>
> wrote:
> > on x86_64:
> > # CONFIG_WATCHDOG is not set
> >

Thanks for your information.

It seems RTC_DRV_DS1374_WDT should be depended on RTC_DRV_DS1374 && WATCHDOG_CORE. Otherwise error will happen if RTC_DRV_DS1374_WDT is enabled but WATCHDOG_CORE not. I'll put this into v5 if there are no other suggestions.

Should I add " Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>" into v5? So many thanks!

> > ld: drivers/rtc/rtc-ds1374.o: in function `ds1374_probe':
> > rtc-ds1374.c:(.text+0x736): undefined reference to
> `watchdog_init_timeout'
> > ld: rtc-ds1374.c:(.text+0x77e): undefined reference to
> `devm_watchdog_register_device'
> 
> Caused by commit
> 
>   d3de4beb14a8 ("rtc: ds1374: wdt: Use watchdog core for watchdog
> part")
> 
> from the rtc tree.
> --
> Cheers,
> Stephen Rothwell

Best regards,
Johnson

Re: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

Hi Johnson,

On Mon, 20 Jul 2020 03:46:15 +0000 Johnson CH Chen (陳昭勳) <JohnsonCH.Chen@moxa.com> wrote:
>
> > On Fri, 17 Jul 2020 09:49:05 -0700 Randy Dunlap <rdunlap@infradead.org>
> > wrote:  
> > > on x86_64:
> > > # CONFIG_WATCHDOG is not set
> > >  
> 
> Thanks for your information.
> 
> It seems RTC_DRV_DS1374_WDT should be depended on RTC_DRV_DS1374 && WATCHDOG_CORE. Otherwise error will happen if RTC_DRV_DS1374_WDT is enabled but WATCHDOG_CORE not. I'll put this into v5 if there are no other suggestions.
> 
> Should I add " Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>" into v5? So many thanks!

Probably "Reported-by: Randy Dunlap <rdunlap@infradead.org>" is more appropriate.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)

[Alexandre Belloni]

Hello,

On 17/07/2020 09:49:05-0700, Randy Dunlap wrote:
> on x86_64:
> # CONFIG_WATCHDOG is not set
> 
> ld: drivers/rtc/rtc-ds1374.o: in function `ds1374_probe':
> rtc-ds1374.c:(.text+0x736): undefined reference to `watchdog_init_timeout'
> ld: rtc-ds1374.c:(.text+0x77e): undefined reference to `devm_watchdog_register_device'
> 

Thanks, I fixed the CONFIG_WATCHDOG dependency now.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com