From: "Gervais, Francois" <FGervais@distech-controls.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Michael McCormick <michael.mccormick@enatel.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] rtc: pcf85063: add integrity check
Date: Fri, 23 Apr 2021 15:21:33 +0000 [thread overview]
Message-ID: <SN6PR01MB4269E5EDFCAAA1308AF3EE10F3459@SN6PR01MB4269.prod.exchangelabs.com> (raw)
In-Reply-To: <YH3zCjPBk/aRn/jg@piout.net>
>>> I'm not sure I get the use case because PCF85063_REG_CTRL2 should be
>>> initialized properly after the driver is probed anyway. The other two
>>> can be set from userspace once it detects the oscillator failure which
>>> would be better at deciding the policy anyway.
>>
>> Thank you for the feedback I think I understand now.
>>
>> We saw the reported problem on devices running kernel v5.4 which doesn't
>> have the common clock framework support and so PCF85063_REG_CTRL2
>> clkout was not initialized by the kernel and left at hardware default.
>>
>> I guess with CCF support, if PCF85063_REG_CTRL2 gets corrupted on
>> power application, on driver probe the clkout value will be set to 0b000
>> or some known default.
>>
>> I'm not familiar the CCF, do you know if it's the case that default values
>> will be set on boot?
>
> The CCF will disable any clocks that are not used on boot so the clock
> will be either used and configured or not used and disabled.
I see now, thank you for the feedback.
I changed the patch status to "Not Applicable" and archived it.
prev parent reply other threads:[~2021-04-23 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 17:49 [PATCH 1/1] rtc: pcf85063: add integrity check Francois Gervais
2021-04-16 22:05 ` Alexandre Belloni
2021-04-19 20:26 ` Gervais, Francois
2021-04-19 21:15 ` Alexandre Belloni
2021-04-23 15:21 ` Gervais, Francois [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR01MB4269E5EDFCAAA1308AF3EE10F3459@SN6PR01MB4269.prod.exchangelabs.com \
--to=fgervais@distech-controls.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=michael.mccormick@enatel.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).