From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Frieder Schrempf <frieder@fris.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Alessandro Zummo <a.zummo@towertech.it>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 0/7] Enable backup switch mode on RTCs via devicetree
Date: Wed, 1 Feb 2023 17:15:26 +0100 [thread overview]
Message-ID: <Y9qQHpySbrFcBB0P@mail.local> (raw)
In-Reply-To: <20230201143431.863784-1-frieder@fris.de>
Hello,
You can't do that, this breaks an important use case and it is the
reason why I didn't use device tree in the beginning. What is wrong with
setting BSM from userspace? You will anyway have to set the time and
date from userspace for it to be saved.
On 01/02/2023 15:34:22+0100, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> Some RTC devices like the RV3028 have BSM disabled as factory default.
> This makes the RTC quite useless if it is expected to preserve the
> time on hardware that has a battery-buffered supply for the RTC.
>
> Let boards that have a buffered supply for the RTC force the BSM to the
> desired value via devicetree by setting the 'backup-switch-mode' property.
>
> That way the RTC on the boards work as one would expect them to do without
> any per-board intervention through userspace tools to enable BSM.
>
> Frieder Schrempf (7):
> dt-bindings: rtc: Move RV3028 to separate binding file
> dt-bindings: rtc: Add backup-switch-mode property
> dt-bindings: rtc: microcrystal,rv3032: Add backup-switch-mode property
> rtc: Move BSM defines to separate header for DT usage
> rtc: class: Support setting backup switch mode from devicetree
> arm64: dts: imx8mm-kontron: Remove useless trickle-diode-disable from
> RTC node
> arm64: dts: imx8mm-kontron: Enable backup switch mode for RTC on OSM-S
> module
>
> .../bindings/rtc/microcrystal,rv3028.yaml | 60 +++++++++++++++++++
> .../devicetree/bindings/rtc/rtc.yaml | 7 +++
> .../devicetree/bindings/rtc/trivial-rtc.yaml | 2 -
> .../dts/freescale/imx8mm-kontron-osm-s.dtsi | 3 +-
> drivers/rtc/class.c | 14 +++++
> include/dt-bindings/rtc/rtc.h | 11 ++++
> include/uapi/linux/rtc.h | 6 +-
> 7 files changed, 95 insertions(+), 8 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml
> create mode 100644 include/dt-bindings/rtc/rtc.h
>
> --
> 2.39.1
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-02-01 16:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 14:34 [PATCH 0/7] Enable backup switch mode on RTCs via devicetree Frieder Schrempf
2023-02-01 14:34 ` [PATCH 1/7] dt-bindings: rtc: Move RV3028 to separate binding file Frieder Schrempf
2023-02-01 20:10 ` Rob Herring
2023-02-02 9:10 ` Krzysztof Kozlowski
2023-02-02 10:17 ` Frieder Schrempf
2023-02-01 14:34 ` [PATCH 2/7] dt-bindings: rtc: Add backup-switch-mode property Frieder Schrempf
2023-02-01 14:34 ` [PATCH 3/7] dt-bindings: rtc: microcrystal,rv3032: " Frieder Schrempf
2023-02-01 14:34 ` [PATCH 4/7] rtc: Move BSM defines to separate header for DT usage Frieder Schrempf
2023-02-02 23:22 ` kernel test robot
2023-02-01 14:34 ` [PATCH 5/7] rtc: class: Support setting backup switch mode from devicetree Frieder Schrempf
2023-02-01 16:15 ` Alexandre Belloni [this message]
2023-02-01 16:26 ` [PATCH 0/7] Enable backup switch mode on RTCs via devicetree Frieder Schrempf
2023-02-13 9:18 ` Frieder Schrempf
2023-03-06 13:27 ` Frieder Schrempf
2023-03-22 13:14 ` Frieder Schrempf
2023-03-22 22:19 ` Alexandre Belloni
2023-03-28 7:10 ` Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9qQHpySbrFcBB0P@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=frieder@fris.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).