From: Rob Herring <robh@kernel.org>
To: Navin Sankar Velliangiri <navin@linumiz.com>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, a.zummo@towertech.it,
alexandre.belloni@bootlin.com
Subject: Re: [PATCH] rtc: bq32000: Add TI BQ32002 compatible
Date: Tue, 31 Aug 2021 14:04:40 -0500 [thread overview]
Message-ID: <YS59SDh1/mkpBpEJ@robh.at.kernel.org> (raw)
In-Reply-To: <20210831074922.273809-1-navin@linumiz.com>
On Tue, Aug 31, 2021 at 01:19:22PM +0530, Navin Sankar Velliangiri wrote:
> The TI BQ32002 is software compatible with the TI BQ32000,
> add DT compatible entries
>
> Signed-off-by: Navin Sankar Velliangiri <navin@linumiz.com>
> ---
> Documentation/devicetree/bindings/rtc/ti,bq32000.yaml | 11 +++++++++++
> drivers/rtc/rtc-bq32k.c | 2 ++
> 2 files changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml b/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
> index bf9c1c4ddb7e..2ddf1cc097d8 100644
> --- a/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
> +++ b/Documentation/devicetree/bindings/rtc/ti,bq32000.yaml
> @@ -15,6 +15,7 @@ allOf:
> properties:
> compatible:
> const: ti,bq32000
> + const: ti,bq32002
'enum' is what you want here.
>
> reg:
> const: 0x68
> @@ -35,6 +36,16 @@ required:
>
> additionalProperties: false
>
> +if:
> + properties:
> + compatible:
> + items:
Use 'contains'
> + - const: ti,bq32002
> +then:
> + properties:
> + trickle-resistor-ohms: false
> + trickle-diode-disable: false
> +
> examples:
> - |
> i2c {
> diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c
> index 2235c968842d..a167a6afdc7e 100644
> --- a/drivers/rtc/rtc-bq32k.c
> +++ b/drivers/rtc/rtc-bq32k.c
> @@ -307,12 +307,14 @@ static int bq32k_remove(struct i2c_client *client)
>
> static const struct i2c_device_id bq32k_id[] = {
> { "bq32000", 0 },
> + { "bq32002", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(i2c, bq32k_id);
>
> static const __maybe_unused struct of_device_id bq32k_of_match[] = {
> { .compatible = "ti,bq32000" },
> + { .compatible = "ti,bq32002" },
> { }
> };
> MODULE_DEVICE_TABLE(of, bq32k_of_match);
> --
> 2.32.0
>
>
prev parent reply other threads:[~2021-08-31 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 7:49 [PATCH] rtc: bq32000: Add TI BQ32002 compatible Navin Sankar Velliangiri
2021-08-31 14:02 ` Rob Herring
2021-08-31 19:04 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS59SDh1/mkpBpEJ@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=navin@linumiz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).