From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Will McVicker <willmcvicker@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Lee Jones <lee.jones@linaro.org>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH v1 4/4] rtc: change HAVE_S3C_RTC default config logic
Date: Mon, 20 Sep 2021 22:05:09 +0200 [thread overview]
Message-ID: <YUjpdcm3eUH7QmAZ@piout.net> (raw)
In-Reply-To: <20210920190350.3860821-5-willmcvicker@google.com>
On 20/09/2021 19:03:49+0000, Will McVicker wrote:
> Switches the default config logic of HAVE_S3C_RTC to use "default y if
> (ARCH_EXYNOS && RTC_CLASS)" versus having ARCH_EXYNOS directly select
> it. This provides vendors flexibility to disable the config if desired
> or modularize it in the presence of a generic kernel.
>
> Verified this change doesn't impact the .config.
>
> Signed-off-by: Will McVicker <willmcvicker@google.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> arch/arm64/Kconfig.platforms | 1 -
> drivers/rtc/Kconfig | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index a884e5da8b0f..f9f829aab511 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -91,7 +91,6 @@ config ARCH_BRCMSTB
>
> config ARCH_EXYNOS
> bool "ARMv8 based Samsung Exynos SoC family"
> - select HAVE_S3C_RTC if RTC_CLASS
> select PINCTRL
> select PM_GENERIC_DOMAINS if PM
> help
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index e1bc5214494e..40afdb37d2a5 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1406,6 +1406,7 @@ config RTC_DRV_OMAP
>
> config HAVE_S3C_RTC
> bool
> + default y if (ARCH_EXYNOS && RTC_CLASS)
> help
> This will include RTC support for Samsung SoCs. If
> you want to include RTC support for any machine, kindly
> --
> 2.33.0.464.g1972c5931b-goog
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-09-20 20:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 19:03 [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs Will McVicker
2021-09-20 19:03 ` [PATCH v1 4/4] rtc: change HAVE_S3C_RTC default config logic Will McVicker
2021-09-20 20:05 ` Alexandre Belloni [this message]
2021-09-21 7:36 ` Krzysztof Kozlowski
2021-09-21 7:08 ` [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs Lee Jones
2021-09-21 7:19 ` Krzysztof Kozlowski
2021-09-21 7:22 ` Krzysztof Kozlowski
2021-09-21 8:11 ` Lee Jones
2021-09-21 8:25 ` Krzysztof Kozlowski
2021-09-21 8:41 ` Lee Jones
2021-09-25 2:17 ` Saravana Kannan
2021-09-27 8:08 ` Krzysztof Kozlowski
2021-09-27 8:16 ` Geert Uytterhoeven
2021-09-27 18:07 ` Saravana Kannan
2021-09-27 19:54 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUjpdcm3eUH7QmAZ@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=will@kernel.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).