From: Heiner Kallweit <hkallweit1@gmail.com>
To: Aditya Pakki <pakki001@umn.edu>
Cc: kjlu@umn.edu, Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: rv8803: Check return value of rv8803_write_reg
Date: Thu, 27 Dec 2018 23:31:47 +0100 [thread overview]
Message-ID: <ab4c081a-82d7-4a50-5c2a-4dbb4ba79223@gmail.com> (raw)
In-Reply-To: <20181227202856.27408-1-pakki001@umn.edu>
On 27.12.2018 21:28, Aditya Pakki wrote:
> In rv8803_handle_irq, rv8803_write_reg can return a failed return
> value when attempting to write to the bus. The fix checks the output
> and throws a dev_warn notifying of the failure.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/rtc/rtc-rv8803.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
You seem to submit the same type of changes throughout very
different subsystems. And you do it w/o thinking and testing.
If you would have looked at rv8803_write_reg() you would have
seen that it prints an error in case of failure. So your
patch achieves nothing.
You got David Miller upset already and it looks like you
want to achieve the same with other maintainers too.
I'd strongly suggest that you stop sending patches until
you better understand the kernel code.
next prev parent reply other threads:[~2018-12-27 22:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 20:28 [PATCH] rtc: rv8803: Check return value of rv8803_write_reg Aditya Pakki
2018-12-27 22:31 ` Heiner Kallweit [this message]
[not found] ` <CAK8KejrntOUb7Q2MrPR6mYDKyHKc=pzO5hOYv=ZfLaP_xg0Zsw@mail.gmail.com>
2018-12-27 23:43 ` Heiner Kallweit
2018-12-28 0:46 ` Alexandre Belloni
2018-12-28 0:43 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab4c081a-82d7-4a50-5c2a-4dbb4ba79223@gmail.com \
--to=hkallweit1@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).