From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB33C31E4B for ; Fri, 14 Jun 2019 12:35:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DB5220850 for ; Fri, 14 Jun 2019 12:35:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ocmOFEN8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727792AbfFNMfS (ORCPT ); Fri, 14 Jun 2019 08:35:18 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:35745 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727544AbfFNMfS (ORCPT ); Fri, 14 Jun 2019 08:35:18 -0400 Received: by mail-lj1-f196.google.com with SMTP id x25so2259007ljh.2; Fri, 14 Jun 2019 05:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1kNA1FB4w/lkcMPFwJQ6UiFI1ZjIBIZGglQjoe4iAUs=; b=ocmOFEN8JsrpnDaEcsGswFmg310y4igtpJoHbSyYKbYtP6eA3pxzE6/IguqrLmKbtd enkJhHXrJmfUV01ZITcnbS+84TpSh1Kx5x9ITe2nuQzhfrzzdZZFT7ErtcnFxtNIfGEx FCzgRkGkr1fHeJUJqe1Tp90kFSalyxEdofvBYrwwBIYe7BVdEx7Yk6nj2k4i20B6DyQ+ iNfKcNwL2n16CaQN7Siy+oAAxlh4d/SuV0EF9gV/fNaN2Etf3OQOFczonG8jyUIRgjXg 70ByDAETbX1TbRfg+V+EKC8nkWWdRHM1+aP188aA2C7ZwVkXiEoKb+j3k9i9TH8ANPd9 uXKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1kNA1FB4w/lkcMPFwJQ6UiFI1ZjIBIZGglQjoe4iAUs=; b=E37fyv//A8uW5W4M9gFVWN7PMTMB6UnUmGHwskIt2Vfsufc8lONa5rIG3td5JJ52aD nStPqcZ3OpX60LycXGEd2iHGpM8Lkr1bQC5lfynj3I45v4kmyMbFMhQY2oDRbYNOM0AC Ox4druzBOZTTbT0JKSe5bG7dV0qYYZztWT6W+HmzbtzN3XtZWicxEtCQgsAnLQ+sLbwF LUWHjSGwHjtKCSxQAkWtbZeLml2Q4RqTY75C3lAkjXiotWcKPGLIBcHjxZrZRUAFh7SJ wN3rm5MIeykihbCuyrv7lDhImPOpSaOtp/4U+wSShkk6EFIguXuwCNkrH+Z4t6TmuU7I +E1w== X-Gm-Message-State: APjAAAUzG2861rSjRsnBYKxUWjC8LgUTVjr6iA0hW5s1saipdWq+wlJo MXfzBEiFqafDcW1GNlmYtDk4STKa X-Google-Smtp-Source: APXvYqwh4OFKtZvWP7uzgjbU+/ho8VXj0IhWKKKDVkMhRs9y/U3uxnjJ0rLmPYrR+aBTHXTly4uUAQ== X-Received: by 2002:a2e:9b10:: with SMTP id u16mr4040443lji.231.1560515715977; Fri, 14 Jun 2019 05:35:15 -0700 (PDT) Received: from [192.168.2.145] (ppp91-79-162-197.pppoe.mtu-net.ru. [91.79.162.197]) by smtp.googlemail.com with ESMTPSA id q2sm462739lfj.25.2019.06.14.05.35.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jun 2019 05:35:15 -0700 (PDT) Subject: Re: [PATCH 2/2] rtc: tegra: Implement suspend clock source To: Thierry Reding , Daniel Lezcano , Thomas Gleixner , Alessandro Zummo , Alexandre Belloni Cc: Jonathan Hunter , linux-tegra@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190614104747.19712-1-thierry.reding@gmail.com> <20190614104747.19712-2-thierry.reding@gmail.com> From: Dmitry Osipenko Message-ID: Date: Fri, 14 Jun 2019 15:35:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190614104747.19712-2-thierry.reding@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org 14.06.2019 13:47, Thierry Reding пишет: > From: Thierry Reding > > The suspend clock source for Tegra210 and earlier is currently > implemented in the Tegra timer driver. However, the suspend clock source > code accesses registers that are part of the RTC hardware block, so both > can step on each others' toes. In practice this isn't an issue, but > there is no reason why the RTC driver can't implement the clock source, > so move the code over to the tegra-rtc driver. > > Signed-off-by: Thierry Reding > --- [snip] > +static struct tegra_rtc_info *to_tegra_rtc(struct clocksource *clksrc) > +{ > + return container_of(clksrc, struct tegra_rtc_info, clksrc); > +} Shouldn't hurt to inline this function explicitly because I assume that it won't get inlined with a certain kernel configurations, like with enabled ftracing for example.