From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
Andrew Lunn <andrew@lunn.ch>,
tbm@cyrius.com, Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org
Subject: Re: TS-219 RTC issue with Debian Buster
Date: Tue, 23 Jul 2019 22:07:10 +0200 [thread overview]
Message-ID: <d633b585-2e66-3143-29c6-418517869d6b@hartkopp.net> (raw)
In-Reply-To: <20190723193443.bqcbrxalng554u76@pengutronix.de>
Hello Uwe,
On 23.07.19 21:34, Uwe Kleine-König wrote:
> On Tue, Jul 23, 2019 at 09:21:06PM +0200, Oliver Hartkopp wrote:
>> I think I already solved the problem, see here:
>> https://marc.info/?l=linux-arm-kernel&m=156390875629259&w=2
>
> IMHO the right fix is teach hwclock to handle your rtc correctly.
> Changing the driver from =m to =y is only a workaround.
Agreed.
> Maybe also using the time stuff from systemd instead of hwclock will
> help^Wwork around your problem (not sure though).
>
> Also I wonder why the ioctl to enable UIE doesn't fail if the driver set
> .uie_unsupported (but I didn't look closely).
Right. When executing the ioctl(4, RTC_UIE_ON) syscall it just get's
stuck and the select() timeout captures the call after 10 seconds.
I would have expected that ioctl(4, RTC_UIE_ON) returns with some
-EINVAL or -ENOTSUPP value.
I'm not sure if hwclock needs the trigger for precision reasons:
https://github.com/karelzak/util-linux/blob/master/sys-utils/hwclock.c#L276
... or if this can be omitted.
>> Will file a Debian bug for it ...
>
> Not sure this will have success. These were switched from =y to =m
> because the kernel images got to big.
> (https://salsa.debian.org/kernel-team/linux/commit/c55043a43eaacb9f876dabd71273b084cb024441)
Too late ;-)
I will just wait for the answer.
Best regards,
Oliver
prev parent reply other threads:[~2019-07-23 20:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <99a8e2cc-61a2-3b43-0d72-6f001cffe572@hartkopp.net>
2019-07-23 19:06 ` TS-219 RTC issue with Debian Buster Uwe Kleine-König
2019-07-23 19:21 ` Oliver Hartkopp
2019-07-23 19:34 ` Uwe Kleine-König
2019-07-23 20:07 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d633b585-2e66-3143-29c6-418517869d6b@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=tbm@cyrius.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).