Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
Cc: "mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
	"a.zummo@towertech.it" <a.zummo@towertech.it>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>
Subject: Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask
Date: Tue, 5 Nov 2019 18:13:07 +0000
Message-ID: <da654ce1fc62ae4e4a5e1f79b68a0d64353cba4a.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20191105165723.GD8309@piout.net>

Hello Alexandre,

I'd expect the BD71828 support to still take a while. I don't expect it
to land in next kernel release. I'd prefer getting this fix in now (and
I hope it might also get merged to earlier releases by the 'fixes'
tag). So if it's not a problem for you then please apply this fix now -
I can rebase the BD71828 support when this fix is out :)

Br,
	Matti Vaittinen

On Tue, 2019-11-05 at 17:57 +0100, Alexandre Belloni wrote:
> On 05/11/2019 17:53:18+0100, Alexandre Belloni wrote:
> > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > When RTC is used in 24H mode (and it is by this driver) the
> > > maximum
> > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > > 
> > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM
> > > bd70528 RTC")
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com
> > > >
> > > ---
> > >  include/linux/mfd/rohm-bd70528.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > Applied, thanks.
> > 
> 
> Actually, is there any point in doing that since "rtc: bd70528 add
> BD71828 support" will conflict with it and correct the issue anyway?
> 


  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 11:47 Matti Vaittinen
2019-11-05 16:53 ` Alexandre Belloni
2019-11-05 16:57   ` Alexandre Belloni
2019-11-05 18:13     ` Vaittinen, Matti [this message]
2019-11-07 10:59   ` Lee Jones
2019-11-07 11:28     ` Alexandre Belloni
2019-11-07 17:38       ` Alexandre Belloni
2019-11-07 11:46     ` Vaittinen, Matti

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da654ce1fc62ae4e4a5e1f79b68a0d64353cba4a.camel@fi.rohmeurope.com \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git