From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C156C04EB8 for ; Mon, 10 Dec 2018 18:34:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E55F92082F for ; Mon, 10 Dec 2018 18:34:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="DJ3yK8zG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E55F92082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rtc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726614AbeLJSeN (ORCPT ); Mon, 10 Dec 2018 13:34:13 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:34813 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726798AbeLJSeN (ORCPT ); Mon, 10 Dec 2018 13:34:13 -0500 Received: by mail-wm1-f66.google.com with SMTP id y185so7253200wmd.1 for ; Mon, 10 Dec 2018 10:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4XjguLCPmvqXsinOMfhdCLLALm7XQdUdXNpo9tOI29g=; b=DJ3yK8zGABKESeslMVjfrtrMynZBbErrQSUyhyZQPwB7EMYNDGT99pWGzmIMQB90mo Mc2RRSrtU42GwddxD2UIZV9cNSGfjMWPy5bd4tQ8tQo/T2YmQ5j+7MQGCZHv1B4IrSim oOJVRyEl9ii6Qmw1MWJt+ipTSYZUbNRN+zNpc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4XjguLCPmvqXsinOMfhdCLLALm7XQdUdXNpo9tOI29g=; b=JIiDGWhwVWfUO7w5JUMK0wiJK50zmiICdShJQPvKe1HQj59p5EbZ/ULXP5tDtUJMd/ sPMvHImEemPTMQS4KPwbjW6czcHY/6O4WCBAlSx2Q3qtfQQWofLzEISwDN8T5VNr34PB Pcl9NkbwKsSnFMZjCLjD8yuupcuQFH7LmsdhfL+nIlquGQf7vMNyIX7g5VHfIyFDq2wr SImLf4fIteU9JJxaMETLAo+eqAU9fSnekRTs3jmiRGV6BekC0AoH1G056fRpJlydyE/E JA8M+qcAPMwn4d1PwLcNtXsJC8pyU+51ruSoPo2H/Qc+HkCDmDnaCVO3Ae4EOdTBt0BT WOHw== X-Gm-Message-State: AA+aEWYTf/jRbhhm6BGPMMTo/12tKaZTXBuwKGnbHyh058Pjm97yplrc tV88dyj1sJIZ/Uxrb9xsYCy6OoW3Vwk= X-Google-Smtp-Source: AFSGD/X9pb8vQsgrzrn2pdjPLhdofjYg0RuWVIgD0bimS5z5h1/Z2G7gk80IXKJkEmaOBDG3wx6T0g== X-Received: by 2002:a1c:dc02:: with SMTP id t2mr5231203wmg.78.1544466851525; Mon, 10 Dec 2018 10:34:11 -0800 (PST) Received: from [192.168.86.29] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id 202sm18521983wmt.8.2018.12.10.10.34.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Dec 2018 10:34:10 -0800 (PST) Subject: Re: [PATCH v2] nvmem: check invalid number of bytes in nvmem_{read,write}() To: Biju Das Cc: Simon Horman , Geert Uytterhoeven , Chris Paterson , Alexandre Belloni , Alessandro Zummo , Fabrizio Castro , linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <1544455701-5720-1-git-send-email-biju.das@bp.renesas.com> From: Srinivas Kandagatla Message-ID: Date: Mon, 10 Dec 2018 18:34:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1544455701-5720-1-git-send-email-biju.das@bp.renesas.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-rtc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 10/12/18 15:28, Biju Das wrote: > + /* Stop the user from writing */ > + if (offset >= nvmem->size) > + return -ENOSPC; > + This should be "return -EFBIG" to make utilities like dd or sh happy. Look at 38b0774c0598c ("nvmem: core: return EFBIG on out-of-range write") for more info. other than that, patch looks fine to me! --srini