From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 6/6] dt-bindings: soc: amlogic: update sysctrl clock-controller subnode type
Date: Mon, 13 Feb 2023 12:00:07 +0100 [thread overview]
Message-ID: <f18230c9-7c9b-9e59-993f-24d40b74ba9d@linaro.org> (raw)
In-Reply-To: <20230209-b4-amlogic-bindings-convert-take2-v1-6-c4fe9049def9@linaro.org>
On 09/02/2023 14:41, Neil Armstrong wrote:
> Since the clock controllers are now documented define the right ref
> for the clock-controller subnodes and fill up the example node.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> index 672eabd90c09..57eae355f1b9 100644
> --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> @@ -43,6 +43,10 @@ allOf:
> - amlogic,meson-gx-hhi-sysctrl
> - amlogic,meson-axg-hhi-sysctrl
> then:
> + properties:
> + clock-controller:
> + $ref: /schemas/clock/amlogic,gxbb-clkc.yaml#
You just added this binding. I don't understand the split.
> +
> required:
> - power-controller
>
> @@ -53,6 +57,10 @@ allOf:
> - amlogic,meson-gx-ao-sysctrl
> - amlogic,meson-axg-ao-sysctrl
> then:
> + properties:
> + clock-controller:
> + $ref: /schemas/clock/amlogic,gxbb-aoclkc.yaml#
> +
> required:
> - pinctrl
>
> @@ -81,7 +89,12 @@ examples:
> compatible = "amlogic,meson-gx-hhi-sysctrl", "simple-mfd", "syscon";
> reg = <0 0x400>;
>
> - clock-controller { };
> + clock-controller {
> + compatible = "amlogic,gxbb-clkc";
> + #clock-cells = <1>;
> + clocks = <&xtal>;
> + clock-names = "xtal";
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-13 11:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 13:41 [PATCH 0/6] dt-bindings: second batch of dt-schema conversions for Amlogic Meson bindings Neil Armstrong
2023-02-09 13:41 ` [PATCH 1/6] dt-bindings: rtc: convert rtc-meson-vrtc.txt to dt-schema Neil Armstrong
2023-02-11 20:10 ` Martin Blumenstingl
2023-02-13 10:49 ` Krzysztof Kozlowski
2023-02-09 13:41 ` [PATCH 2/6] dt-bindings: soc: amlogic: convert clk-measure.txt " Neil Armstrong
2023-02-11 20:13 ` Martin Blumenstingl
2023-02-13 10:54 ` Krzysztof Kozlowski
2023-02-09 13:41 ` [PATCH 3/6] dt-bindings: soc: amlogic: document System Control registers Neil Armstrong
2023-02-11 20:25 ` Martin Blumenstingl
2023-02-13 10:59 ` Krzysztof Kozlowski
2023-02-09 13:41 ` [PATCH 4/6] dt-bindings: soc: amlogic: convert amlogic,gxbb-clkc.txt to dt-schema Neil Armstrong
2023-02-13 11:01 ` Krzysztof Kozlowski
2023-02-09 13:41 ` [PATCH 5/6] dt-bindings: soc: amlogic: convert amlogic,gxbb-aoclkc.txt " Neil Armstrong
2023-02-13 11:05 ` Krzysztof Kozlowski
2023-02-09 13:41 ` [PATCH 6/6] dt-bindings: soc: amlogic: update sysctrl clock-controller subnode type Neil Armstrong
2023-02-13 11:00 ` Krzysztof Kozlowski [this message]
2023-02-13 11:03 ` Neil Armstrong
2023-02-13 11:06 ` Krzysztof Kozlowski
2023-03-06 8:39 ` (subset) [PATCH 0/6] dt-bindings: second batch of dt-schema conversions for Amlogic Meson bindings Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f18230c9-7c9b-9e59-993f-24d40b74ba9d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).