From: Kirill Kapranov <kirill.kapranov@compulab.co.il>
To: Pavel Machek <pavel@denx.de>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
phdm@macqel.be, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] rtc:abx80x: Enable xt digital calibration
Date: Fri, 9 Apr 2021 19:56:43 +0300 [thread overview]
Message-ID: <f18afc2d-a098-0577-12e2-e3f1c0805c45@compulab.co.il> (raw)
In-Reply-To: <20210409104617.GB10988@amd>
Hi Pavel,
Thank you very much for pointing out the issues.
I redesign all the code deeply, as Alexandre Belloni suggested [1], and
the lines you have mentioned are to be fixed too.
Unfortunately, it takes more time than I supposed.
Thank you again!
--
Best Regards,
Kirill Kapranov
Software Engineer
CompuLab Ltd.
[1] https://marc.info/?l=linux-rtc&m=161696606727215&w=2
On 4/9/21 1:46 PM, Pavel Machek wrote:
> Hi!
>
>> The XT digital calibration feature allows to improve the RTC accuracy,
>> using a Distributed Digital Calibration function.
>> See ch. 5.9.1 of AB08XX Series Ultra Low Power RTC IC User's Guide
>> https://abracon.com/realtimeclock/AB08XX-Application-Manual.pdf
>>
>> Signed-off-by: Kirill Kapranov <kirill.kapranov@compulab.co.il>
>> ---
>> drivers/rtc/rtc-abx80x.c | 145 +++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 145 insertions(+)
>
>
>>
>> +static const int xt_freq_nom = 32768000; //Nominal XT frequency 32 kHz in mHz
>
> C-style comment?
>
> is it 32 kHz or 32.768 kHz?
>
>> +{
>> + int retval;
>> + long Adj;
>
> Adj -> adj.
>
>> +
>> +static DEVICE_ATTR_WO(xt_frequency);
>
> You are adding new user interface, you sould add documentation.
>
> Best regards,
> Pavel
>
>
--
Best Regards,
Kirill Kapranov
Software Engineer
CompuLab Ltd.
Tel.: (+972) 48-290-100.Ext 227
Cel.: (+972) 53-9332508
next prev parent reply other threads:[~2021-04-09 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 21:02 [PATCH 0/4] rtc:abx80x: Enable distributed digital calibration Kirill Kapranov
2021-03-28 21:02 ` [PATCH 1/4] dt-bindings: rtc: abracon,abx80x: Add sqw property Kirill Kapranov
2021-03-28 21:02 ` [PATCH 2/4] rtc: abx80x: Enable SQW output Kirill Kapranov
2021-03-29 0:34 ` kernel test robot
2021-03-29 6:19 ` Dan Carpenter
2021-03-30 15:28 ` Kirill Kapranov
2021-03-28 21:02 ` [PATCH 3/4] dt-bindings: rtc: abracon,abx80x: Add xt-frequency property Kirill Kapranov
2021-03-28 21:02 ` [PATCH 4/4] rtc:abx80x: Enable xt digital calibration Kirill Kapranov
2021-04-09 10:46 ` Pavel Machek
2021-04-09 16:56 ` Kirill Kapranov [this message]
2021-03-28 21:14 ` [PATCH 0/4] rtc:abx80x: Enable distributed " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f18afc2d-a098-0577-12e2-e3f1c0805c45@compulab.co.il \
--to=kirill.kapranov@compulab.co.il \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=pavel@denx.de \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).