From: Valentin Schneider <valentin.schneider@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] rtc: pl031: fix set_alarm by adding back call to alarm_irq_enable
Date: Tue, 14 Jul 2020 16:04:08 +0100 [thread overview]
Message-ID: <jhjo8oijfyv.mognet@arm.com> (raw)
In-Reply-To: <20200714124556.20294-1-sudeep.holla@arm.com>
On 14/07/20 13:45, Sudeep Holla wrote:
> Commit c8ff5841a90b ("rtc: pl031: switch to rtc_time64_to_tm/rtc_tm_to_time64")
> seemed to have accidentally removed the call to pl031_alarm_irq_enable
> from pl031_set_alarm while switching to 64-bit apis.
>
> Let us add back the same to get the set alarm functionality back.
>
> Fixes: c8ff5841a90b ("rtc: pl031: switch to rtc_time64_to_tm/rtc_tm_to_time64")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Thanks for looking into this!
CONFIG_TEST_SUSPEND with test_suspend=mem now behaves correctly (i.e. comes
back out of suspend), and
$ rtcwake -d /dev/rtc0 -s 2 -m no
shows an increase in RTC interrupts (which remains at 0 before this patch).
Tested-by: Valentin Schneider <valentin.schneider@arm.com>
> ---
> drivers/rtc/rtc-pl031.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c
> index 40d7450a1ce4..c6b89273feba 100644
> --- a/drivers/rtc/rtc-pl031.c
> +++ b/drivers/rtc/rtc-pl031.c
> @@ -275,6 +275,7 @@ static int pl031_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
> struct pl031_local *ldata = dev_get_drvdata(dev);
>
> writel(rtc_tm_to_time64(&alarm->time), ldata->base + RTC_MR);
> + pl031_alarm_irq_enable(dev, alarm->enabled);
>
> return 0;
> }
next prev parent reply other threads:[~2020-07-14 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 12:45 [PATCH] rtc: pl031: fix set_alarm by adding back call to alarm_irq_enable Sudeep Holla
2020-07-14 15:04 ` Valentin Schneider [this message]
2020-07-16 9:28 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhjo8oijfyv.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).