From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Hendrik Brueckner <brueckner@linux.ibm.com>,
Valentin Vidic <vvidic@valentin-vidic.from.hr>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
Philipp Kern <pkern@debian.org>,
Benjamin Zimmermann <dave@oss.volkswagen.com>,
debian-s390@lists.debian.org,
Peter Oberparleiter <oberpar@linux.ibm.com>
Subject: Re: [PATCH v2] s390/sclp_vt220: Fix console name to match device
Date: Wed, 28 Apr 2021 16:44:38 +0200 [thread overview]
Message-ID: <80735c89-a18a-5910-4e0c-f27eaa513578@de.ibm.com> (raw)
In-Reply-To: <20210428133836.GD21939@linux.ibm.com>
On 28.04.21 15:38, Hendrik Brueckner wrote:
> Hi Valentin,
>
> I just had the chance to look into this console topic yesterday.
>
> On Tue, Apr 27, 2021 at 09:40:10PM +0200, Valentin Vidic wrote:
>> Console name reported in /proc/consoles:
>>
>> ttyS1 -W- (EC p ) 4:65
>
> It is been a while ago when working on consoles. However, consoles are
> typically devices without having a device node associated. There is special
> handling for /dev/console wrt. to the preferred console in the tty layer.
>
> A console device might be associated with a tty device but this is not a
> requirement. For example, consider the net console that streams console
> messages thru UDP and is not associated with a tty.
>
> Because console and tty are different devices, names can also be different
> which is, unfortunately, the case on s390.
another example is the ttyS0 console which is called sclp_line0 as a tty.
Doesnt the debian installer thus also fails when running in an LPAR?
It might still be a good idea to actually change the console name for the
ascii console as you patch does.
> Therefore my suggestion here is not derive the tty device from the name
> of the console, but rather looking at the associated tty being reported
> as major minor number in /proc/console.
So yes we should definitely try to fix the installer program as well. All other
distros seem to handle this case fine.
>
>>
>> does not match the char device name:
>>
>> crw--w---- 1 root root 4, 65 May 17 12:18 /dev/ttysclp0
>
> In the example above, 4:65 excactly ends up in /dev/ttysclp0.
>
> I am also in contact with Christian and thanks to him to try this out
> internally. At least, there are options to bring this forward and let's
> figure out what the best solution will be.
>
> Thanks and kind regards,
> Hendrik
>
h
next prev parent reply other threads:[~2021-04-28 14:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 18:16 [PATCH] s390/sclp_vt220: Fix console name to match device Valentin Vidic
2020-05-20 5:25 ` Christian Borntraeger
2020-05-20 7:07 ` Valentin Vidić
2020-05-20 7:14 ` Christian Borntraeger
2020-05-20 8:04 ` Valentin Vidić
2021-04-27 19:40 ` [PATCH v2] " Valentin Vidic
2021-04-28 12:39 ` Christian Borntraeger
2021-04-28 13:38 ` Hendrik Brueckner
2021-04-28 14:44 ` Christian Borntraeger [this message]
2021-04-28 16:13 ` Valentin Vidić
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80735c89-a18a-5910-4e0c-f27eaa513578@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=brueckner@linux.ibm.com \
--cc=dave@oss.volkswagen.com \
--cc=debian-s390@lists.debian.org \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=pkern@debian.org \
--cc=vvidic@valentin-vidic.from.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).