From: Pierre Morel <pmorel@linux.ibm.com>
To: Niklas Schnelle <schnelle@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
iommu@lists.linux.dev
Cc: linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
hca@linux.ibm.com, gor@linux.ibm.com,
gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
svens@linux.ibm.com, joro@8bytes.org, will@kernel.org,
robin.murphy@arm.com, jgg@nvidia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] s390/pci: remove unused bus_next field from struct zpci_dev
Date: Mon, 26 Sep 2022 11:23:39 +0200 [thread overview]
Message-ID: <8ba5cee2-5e5c-6b73-3ac7-56e78e432698@linux.ibm.com> (raw)
In-Reply-To: <e0754578-1735-5811-0533-19ef0c6be2b0@linux.ibm.com>
On 9/26/22 11:17, Pierre Morel wrote:
>
>
> On 9/22/22 11:52, Niklas Schnelle wrote:
>> This field was added in commit 44510d6fa0c0 ("s390/pci: Handling
>> multifunctions") but is an unused remnant of an earlier version where
>> the devices on the virtual bus were connected in a linked list instead
>> of a fixed 256 entry array of pointers.
>>
>> It is also not used for the list of busses as that is threaded through
>> struct zpci_bus not through struct zpci_dev.
>>
>> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
>
> Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
>
>
Also couldn't it be detached of the series and posted on its own?
>> ---
>> arch/s390/include/asm/pci.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/s390/include/asm/pci.h b/arch/s390/include/asm/pci.h
>> index 7b4cdadbc023..108e732d7b14 100644
>> --- a/arch/s390/include/asm/pci.h
>> +++ b/arch/s390/include/asm/pci.h
>> @@ -117,7 +117,6 @@ struct zpci_bus {
>> struct zpci_dev {
>> struct zpci_bus *zbus;
>> struct list_head entry; /* list of all zpci_devices,
>> needed for hotplug, etc. */
>> - struct list_head bus_next;
>> struct kref kref;
>> struct hotplug_slot hotplug_slot;
>
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2022-09-26 9:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 9:52 [PATCH v2 0/3] iommu/s390: Fixes related to repeat attach_dev calls Niklas Schnelle
2022-09-22 9:52 ` [PATCH v2 1/3] iommu/s390: Fix duplicate domain attachments Niklas Schnelle
2022-09-22 14:33 ` Jason Gunthorpe
2022-09-26 9:00 ` Niklas Schnelle
2022-09-26 13:46 ` Jason Gunthorpe
2022-09-27 16:33 ` Niklas Schnelle
2022-09-27 16:56 ` Jason Gunthorpe
2022-09-28 8:58 ` Niklas Schnelle
2022-09-28 13:32 ` Jason Gunthorpe
2022-09-29 7:47 ` Niklas Schnelle
2022-09-26 13:29 ` Niklas Schnelle
2022-09-26 13:51 ` Jason Gunthorpe
2022-09-27 16:24 ` Niklas Schnelle
2022-09-27 16:40 ` Jason Gunthorpe
2022-09-22 9:52 ` [PATCH v2 2/3] s390/pci: remove unused bus_next field from struct zpci_dev Niklas Schnelle
2022-09-26 9:17 ` Pierre Morel
2022-09-26 9:23 ` Pierre Morel [this message]
2022-09-26 13:41 ` Niklas Schnelle
2022-09-22 9:52 ` [PATCH v2 3/3] iommu/s390: Get rid of s390_domain_device Niklas Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ba5cee2-5e5c-6b73-3ac7-56e78e432698@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=robin.murphy@arm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).