From: "Tian, Kevin" <kevin.tian@intel.com>
To: Eric Farman <farman@linux.ibm.com>, "hch@lst.de" <hch@lst.de>
Cc: "akrowiak@linux.ibm.com" <akrowiak@linux.ibm.com>,
"jjherne@linux.ibm.com" <jjherne@linux.ibm.com>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"kwankhede@nvidia.com" <kwankhede@nvidia.com>,
"vneethv@linux.ibm.com" <vneethv@linux.ibm.com>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"Wang, Zhi A" <zhi.a.wang@intel.com>,
"Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [RFC PATCH] vfio/ccw: Move mdev stuff out of struct subchannel
Date: Sat, 27 Aug 2022 10:08:02 +0000 [thread overview]
Message-ID: <BN9PR11MB5276AAB235D64F61EFB19BB48C749@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <0ee29bd6583f17f0ee4ec0769fa50e8ea6703623.camel@linux.ibm.com>
> From: Eric Farman <farman@linux.ibm.com>
> Sent: Thursday, August 18, 2022 9:24 PM
>
> On Thu, 2022-08-18 at 06:53 +0000, Tian, Kevin wrote:
> > Hi, Eric,
> >
> > > From: Eric Farman
> > > Sent: Tuesday, July 26, 2022 11:37 PM
> > >
> > > --- a/drivers/s390/cio/vfio_ccw_private.h
> > > +++ b/drivers/s390/cio/vfio_ccw_private.h
> > > @@ -111,6 +111,10 @@ struct vfio_ccw_private {
> > > struct eventfd_ctx *req_trigger;
> > > struct work_struct io_work;
> > > struct work_struct crw_work;
> > > +
> > > + struct mdev_parent parent;
> > > + struct mdev_type mdev_type;
> > > + struct mdev_type *mdev_types[1];
> > > } __aligned(8);
> > >
> >
> > IMHO creating a separate structure to encapsulate parent related
> > information is far cleaner than mixing both mdev and parent into
> > one structure.
> >
> > mdev and parent have different life cycles. mdev is between
> > mdev probe/remove while parent is between css probe/remove.
>
> I don't disagree with any of that. My point with the suggested patch
> was a way to get this working without disrupting the cio's subchannel
> (which is used for many non-mdev things).
ok
>
> Un-mixing the mdev from the parent stuff wouldn't be impossible, but
> requires consideration I haven't had the bandwidth to do (which is why
> the cleanup you reference below was dropped from later versions of that
> series [3]).
>
Could you help take a look at [1] which introduces a workaround for ccw
so struct device can be introduced to vfio_device now instead of being
blocked by this un-mixing task?
[1] https://lore.kernel.org/lkml/20220827171037.30297-14-kevin.tian@intel.com/
next prev parent reply other threads:[~2022-08-27 10:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-09 4:54 simplify the mdev interface v6 Christoph Hellwig
2022-07-09 4:54 ` [PATCH 01/14] drm/i915/gvt: fix a memory leak in intel_gvt_init_vgpu_types Christoph Hellwig
2022-07-09 4:54 ` [PATCH 02/14] drm/i915/gvt: simplify vgpu configuration management Christoph Hellwig
2022-07-09 4:54 ` [PATCH 03/14] vfio/mdev: make mdev.h standalone includable Christoph Hellwig
2022-07-19 17:03 ` Jason J. Herne
2022-07-09 4:54 ` [PATCH 04/14] vfio/mdev: embedd struct mdev_parent in the parent data structure Christoph Hellwig
2022-07-09 4:54 ` [PATCH 05/14] vfio/mdev: simplify mdev_type handling Christoph Hellwig
2022-07-20 20:47 ` Eric Farman
2022-07-09 4:54 ` [PATCH 06/14] vfio/mdev: remove mdev_from_dev Christoph Hellwig
2022-07-09 4:54 ` [PATCH 07/14] vfio/mdev: unexport mdev_bus_type Christoph Hellwig
2022-07-09 4:54 ` [PATCH 08/14] vfio/mdev: remove mdev_parent_dev Christoph Hellwig
2022-07-09 4:54 ` [PATCH 09/14] vfio/mdev: remove mtype_get_parent_dev Christoph Hellwig
2022-07-09 4:54 ` [PATCH 10/14] vfio/mdev: consolidate all the device_api sysfs into the core code Christoph Hellwig
2022-07-09 4:54 ` [PATCH 11/14] vfio/mdev: consolidate all the name " Christoph Hellwig
2022-07-09 4:54 ` [PATCH 12/14] vfio/mdev: consolidate all the available_instance " Christoph Hellwig
2022-07-09 4:54 ` [PATCH 13/14] vfio/mdev: consolidate all the description " Christoph Hellwig
2022-07-09 4:54 ` [PATCH 14/14] vfio/mdev: add mdev available instance checking to the core Christoph Hellwig
2022-07-19 2:00 ` Eric Farman
2022-07-19 14:48 ` Christoph Hellwig
2022-07-18 5:43 ` simplify the mdev interface v6 Christoph Hellwig
2022-07-18 21:33 ` Alex Williamson
2022-07-19 0:22 ` Zhenyu Wang
2022-07-19 2:01 ` Eric Farman
2022-07-19 14:49 ` Christoph Hellwig
2022-07-19 15:26 ` Alex Williamson
2022-07-19 17:49 ` Eric Farman
2022-07-20 2:41 ` Eric Farman
2022-07-20 5:06 ` Christoph Hellwig
2022-07-26 15:37 ` [RFC PATCH] vfio/ccw: Move mdev stuff out of struct subchannel Eric Farman
2022-07-26 17:48 ` Christoph Hellwig
2022-07-26 18:03 ` Eric Farman
2022-08-18 6:53 ` Tian, Kevin
2022-08-18 13:24 ` Eric Farman
2022-08-27 10:08 ` Tian, Kevin [this message]
2022-07-20 12:14 ` simplify the mdev interface v6 Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5276AAB235D64F61EFB19BB48C749@BN9PR11MB5276.namprd11.prod.outlook.com \
--to=kevin.tian@intel.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=farman@linux.ibm.com \
--cc=hch@lst.de \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jgg@nvidia.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
--cc=yi.l.liu@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).