From: "Liu, Yi L" <yi.l.liu@intel.com>
To: Nicolin Chen <nicolinc@nvidia.com>, Jon Pan-Doh <pandoh@google.com>
Cc: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"Tian, Kevin" <kevin.tian@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"lulu@redhat.com" <lulu@redhat.com>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"Xu, Terrence" <terrence.xu@intel.com>,
"Hao, Xudong" <xudong.hao@intel.com>,
"Zhao, Yan Y" <yan.y.zhao@intel.com>,
"Jiang, Yanting" <yanting.jiang@intel.com>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>
Subject: RE: [PATCH v8 16/24] iommufd/device: Add iommufd_access_detach() API
Date: Wed, 29 Mar 2023 02:24:28 +0000 [thread overview]
Message-ID: <DS0PR11MB7529F70B9C0E17D02890C91CC3899@DS0PR11MB7529.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ZCMNzMV0DTOQEdgH@Asurada-Nvidia>
> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Tuesday, March 28, 2023 11:55 PM
>
> On Mon, Mar 27, 2023 at 07:23:57PM -0700, Jon Pan-Doh wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On 2023/3/27 02:40, Yi Liu wrote:
> > > diff --git a/drivers/iommu/iommufd/iommufd_private.h
> b/drivers/iommu/iommufd/iommufd_private.h
> > > index 2e6e8e217cce..ec2ce3ef187d 100644
> > > --- a/drivers/iommu/iommufd/iommufd_private.h
> > > +++ b/drivers/iommu/iommufd/iommufd_private.h
> > > @@ -263,6 +263,8 @@ struct iommufd_access {
> > > struct iommufd_object obj;
> > > struct iommufd_ctx *ictx;
> > > struct iommufd_ioas *ioas;
> > > + struct iommufd_ioas *ioas_unpin;
> > > + struct mutex ioas_lock;
> > > const struct iommufd_access_ops *ops;
> > > void *data;
> > > unsigned long iova_alignment;
> >
> > I think you may need to initialize ioas_lock. I got lockdep warnings running
> > iommufd selftests against this patch. Those went away when I added
> mutex_init().
> >
> > ---
> > drivers/iommu/iommufd/device.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iommu/iommufd/device.c
> b/drivers/iommu/iommufd/device.c
> > index f0522d80919d..0eaae60f3537 100644
> > --- a/drivers/iommu/iommufd/device.c
> > +++ b/drivers/iommu/iommufd/device.c
> > @@ -474,6 +474,7 @@ iommufd_access_create(struct iommufd_ctx *ictx,
> > iommufd_ctx_get(ictx);
> > iommufd_object_finalize(ictx, &access->obj);
> > *id = access->obj.id;
> > + mutex_init(&access->ioas_lock);
> > return access;
> > }
> > EXPORT_SYMBOL_NS_GPL(iommufd_access_create, IOMMUFD);
> > --
> > 2.40.0.348.gf938b09366-goog
>
> Yes... I think I lost that when splitting the changes.
>
> Yi, can you help add this in the next version?
Sure. 😊
Regards,
Yi Liu
next prev parent reply other threads:[~2023-03-29 2:24 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 9:40 [PATCH v8 00/24] Add vfio_device cdev for iommufd support Yi Liu
2023-03-27 9:40 ` [PATCH v8 01/24] vfio: Allocate per device file structure Yi Liu
2023-03-27 9:40 ` [PATCH v8 02/24] vfio: Refine vfio file kAPIs for KVM Yi Liu
2023-03-27 9:40 ` [PATCH v8 03/24] vfio: Remove vfio_file_is_group() Yi Liu
2023-03-30 23:50 ` Jason Gunthorpe
2023-03-27 9:40 ` [PATCH v8 04/24] vfio: Accept vfio device file in the KVM facing kAPI Yi Liu
2023-03-27 9:40 ` [PATCH v8 05/24] kvm/vfio: Rename kvm_vfio_group to prepare for accepting vfio device fd Yi Liu
2023-03-27 9:40 ` [PATCH v8 06/24] kvm/vfio: Accept vfio device file from userspace Yi Liu
2023-03-27 9:40 ` [PATCH v8 07/24] vfio: Pass struct vfio_device_file * to vfio_device_open/close() Yi Liu
2023-03-27 9:40 ` [PATCH v8 08/24] vfio: Block device access via device fd until device is opened Yi Liu
2023-03-28 21:33 ` Alex Williamson
2023-03-29 2:23 ` Liu, Yi L
2023-03-27 9:40 ` [PATCH v8 09/24] vfio: Add cdev_device_open_cnt to vfio_group Yi Liu
2023-03-27 9:40 ` [PATCH v8 10/24] vfio: Make vfio_device_open() single open for device cdev path Yi Liu
2023-03-30 23:52 ` Jason Gunthorpe
2023-03-27 9:40 ` [PATCH v8 11/24] vfio: Make vfio_device_first_open() to accept NULL iommufd for noiommu Yi Liu
2023-03-30 23:56 ` Jason Gunthorpe
2023-03-27 9:40 ` [PATCH v8 12/24] vfio-iommufd: Move noiommu support out of vfio_iommufd_bind() Yi Liu
2023-03-27 9:40 ` [PATCH v8 13/24] vfio-iommufd: Split bind/attach into two steps Yi Liu
2023-03-27 9:40 ` [PATCH v8 14/24] vfio: Record devid in vfio_device_file Yi Liu
2023-03-27 9:40 ` [PATCH v8 15/24] vfio-iommufd: Add detach_ioas support for physical VFIO devices Yi Liu
2023-03-27 9:40 ` [PATCH v8 16/24] iommufd/device: Add iommufd_access_detach() API Yi Liu
2023-03-28 2:23 ` Jon Pan-Doh
2023-03-28 15:54 ` Nicolin Chen
2023-03-29 2:24 ` Liu, Yi L [this message]
2023-03-27 9:40 ` [PATCH v8 17/24] vfio-iommufd: Add detach_ioas support for emulated VFIO devices Yi Liu
2023-03-27 9:40 ` [PATCH v8 18/24] vfio: Determine noiommu in vfio_device registration Yi Liu
2023-03-28 6:36 ` Tian, Kevin
2023-03-27 9:40 ` [PATCH v8 19/24] vfio: Name noiommu vfio_device with "noiommu-" prefix Yi Liu
2023-03-28 6:37 ` Tian, Kevin
2023-03-27 9:40 ` [PATCH v8 20/24] vfio: Add cdev for vfio_device Yi Liu
2023-03-29 19:57 ` Alex Williamson
2023-03-30 5:35 ` Liu, Yi L
2023-03-27 9:40 ` [PATCH v8 21/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD Yi Liu
2023-03-29 21:00 ` Alex Williamson
2023-03-29 23:22 ` Jason Gunthorpe
2023-03-30 12:52 ` Liu, Yi L
2023-03-30 12:59 ` Jason Gunthorpe
2023-03-30 7:09 ` Liu, Yi L
2023-03-30 11:52 ` Jason Gunthorpe
2023-03-30 12:53 ` Liu, Yi L
2023-03-27 9:40 ` [PATCH v8 22/24] vfio: Add VFIO_DEVICE_AT[DE]TACH_IOMMUFD_PT Yi Liu
2023-03-29 21:19 ` Alex Williamson
2023-03-30 13:02 ` Liu, Yi L
2023-03-27 9:40 ` [PATCH v8 23/24] vfio: Compile group optionally Yi Liu
2023-03-29 21:51 ` Alex Williamson
2023-03-30 13:06 ` Liu, Yi L
2023-03-27 9:40 ` [PATCH v8 24/24] docs: vfio: Add vfio device cdev description Yi Liu
2023-03-29 22:47 ` Alex Williamson
2023-03-29 22:57 ` Alex Williamson
2023-03-30 13:11 ` Liu, Yi L
2023-03-27 17:48 ` [PATCH v8 00/24] Add vfio_device cdev for iommufd support Nicolin Chen
2023-03-31 3:10 ` Jiang, Yanting
2023-03-31 5:01 ` Jiang, Yanting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DS0PR11MB7529F70B9C0E17D02890C91CC3899@DS0PR11MB7529.namprd11.prod.outlook.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=pandoh@google.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=terrence.xu@intel.com \
--cc=xudong.hao@intel.com \
--cc=yan.y.zhao@intel.com \
--cc=yanting.jiang@intel.com \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).