* [PATCH] s390: cio: Return -EFAULT if copy_to_user() fails
@ 2021-03-01 12:01 Wang Qing
2021-03-01 13:13 ` Heiko Carstens
0 siblings, 1 reply; 4+ messages in thread
From: Wang Qing @ 2021-03-01 12:01 UTC (permalink / raw)
To: Cornelia Huck, Eric Farman, Halil Pasic, Vineeth Vijayan,
Peter Oberparleiter, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, linux-s390, kvm, linux-kernel
Cc: Wang Qing
The copy_to_user() function returns the number of bytes remaining to be
copied, but we want to return -EFAULT if the copy doesn't complete.
Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/s390/cio/vfio_ccw_ops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/cio/vfio_ccw_ops.c b/drivers/s390/cio/vfio_ccw_ops.c
index 68106be..557d0b8
--- a/drivers/s390/cio/vfio_ccw_ops.c
+++ b/drivers/s390/cio/vfio_ccw_ops.c
@@ -543,7 +543,7 @@ static ssize_t vfio_ccw_mdev_ioctl(struct mdev_device *mdev,
if (ret)
return ret;
- return copy_to_user((void __user *)arg, &info, minsz);
+ return copy_to_user((void __user *)arg, &info, minsz) ? -EFAULT : 0;
}
case VFIO_DEVICE_GET_REGION_INFO:
{
@@ -561,7 +561,7 @@ static ssize_t vfio_ccw_mdev_ioctl(struct mdev_device *mdev,
if (ret)
return ret;
- return copy_to_user((void __user *)arg, &info, minsz);
+ return copy_to_user((void __user *)arg, &info, minsz) ? -EFAULT : 0;
}
case VFIO_DEVICE_GET_IRQ_INFO:
{
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] s390: cio: Return -EFAULT if copy_to_user() fails
2021-03-01 12:01 [PATCH] s390: cio: Return -EFAULT if copy_to_user() fails Wang Qing
@ 2021-03-01 13:13 ` Heiko Carstens
2021-03-01 18:07 ` Eric Farman
0 siblings, 1 reply; 4+ messages in thread
From: Heiko Carstens @ 2021-03-01 13:13 UTC (permalink / raw)
To: Wang Qing
Cc: Cornelia Huck, Eric Farman, Halil Pasic, Vineeth Vijayan,
Peter Oberparleiter, Vasily Gorbik, Christian Borntraeger,
linux-s390, kvm, linux-kernel
On Mon, Mar 01, 2021 at 08:01:33PM +0800, Wang Qing wrote:
> The copy_to_user() function returns the number of bytes remaining to be
> copied, but we want to return -EFAULT if the copy doesn't complete.
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
> drivers/s390/cio/vfio_ccw_ops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] s390: cio: Return -EFAULT if copy_to_user() fails
2021-03-01 13:13 ` Heiko Carstens
@ 2021-03-01 18:07 ` Eric Farman
2021-03-01 19:56 ` Heiko Carstens
0 siblings, 1 reply; 4+ messages in thread
From: Eric Farman @ 2021-03-01 18:07 UTC (permalink / raw)
To: Heiko Carstens, Wang Qing
Cc: Cornelia Huck, Halil Pasic, Vineeth Vijayan, Peter Oberparleiter,
Vasily Gorbik, Christian Borntraeger, linux-s390, kvm,
linux-kernel
On 3/1/21 8:13 AM, Heiko Carstens wrote:
> On Mon, Mar 01, 2021 at 08:01:33PM +0800, Wang Qing wrote:
>> The copy_to_user() function returns the number of bytes remaining to be
>> copied, but we want to return -EFAULT if the copy doesn't complete.
>>
>> Signed-off-by: Wang Qing <wangqing@vivo.com>
>> ---
>> drivers/s390/cio/vfio_ccw_ops.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Applied, thanks!
>
There's a third copy_to_user() call in this same routine, that deserves
the same treatment. I'll get that fixup applied.
Thanks,
Eric
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] s390: cio: Return -EFAULT if copy_to_user() fails
2021-03-01 18:07 ` Eric Farman
@ 2021-03-01 19:56 ` Heiko Carstens
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Carstens @ 2021-03-01 19:56 UTC (permalink / raw)
To: Eric Farman
Cc: Wang Qing, Cornelia Huck, Halil Pasic, Vineeth Vijayan,
Peter Oberparleiter, Vasily Gorbik, Christian Borntraeger,
linux-s390, kvm, linux-kernel
On Mon, Mar 01, 2021 at 01:07:26PM -0500, Eric Farman wrote:
>
>
> On 3/1/21 8:13 AM, Heiko Carstens wrote:
> > On Mon, Mar 01, 2021 at 08:01:33PM +0800, Wang Qing wrote:
> > > The copy_to_user() function returns the number of bytes remaining to be
> > > copied, but we want to return -EFAULT if the copy doesn't complete.
> > >
> > > Signed-off-by: Wang Qing <wangqing@vivo.com>
> > > ---
> > > drivers/s390/cio/vfio_ccw_ops.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Applied, thanks!
>
> There's a third copy_to_user() call in this same routine, that deserves the
> same treatment. I'll get that fixup applied.
Thanks a lot - I actually realized that there was a third one, but
blindly assumed that the other patch addressed that (for which the
original broken commit e06670c5fe3b ("s390: vfio-ap: implement
VFIO_DEVICE_GET_INFO ioctl") got an amazing number of eight tags ;))
I'll keep your patch as a seperate one, since it fixes a different
upstream patch.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-01 20:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 12:01 [PATCH] s390: cio: Return -EFAULT if copy_to_user() fails Wang Qing
2021-03-01 13:13 ` Heiko Carstens
2021-03-01 18:07 ` Eric Farman
2021-03-01 19:56 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).