From: Greg KH <gregkh@linuxfoundation.org>
To: Adrian Catangiu <acatan@amazon.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
linux-s390@vger.kernel.org, graf@amazon.com,
rdunlap@infradead.org, arnd@arndb.de, ebiederm@xmission.com,
rppt@kernel.org, 0x7f454c46@gmail.com, borntraeger@de.ibm.com,
Jason@zx2c4.com, jannh@google.com, w@1wt.eu, colmmacc@amazon.com,
luto@kernel.org, tytso@mit.edu, ebiggers@kernel.org,
dwmw@amazon.co.uk, bonzini@gnu.org, sblbir@amazon.com,
raduweis@amazon.com, corbet@lwn.net, mst@redhat.com,
mhocko@kernel.org, rafael@kernel.org, pavel@ucw.cz,
mpe@ellerman.id.au, areber@redhat.com, ovzxemul@gmail.com,
avagin@gmail.com, ptikhomirov@virtuozzo.com, gil@azul.com,
asmehra@redhat.com, dgunigun@redhat.com, vijaysun@ca.ibm.com,
oridgar@gmail.com, ghammer@redhat.com
Subject: Re: [PATCH v6 1/2] drivers/misc: sysgenid: add system generation id driver
Date: Mon, 22 Feb 2021 10:53:06 +0100 [thread overview]
Message-ID: <YDN/AvsplZ7R8OTR@kroah.com> (raw)
In-Reply-To: <1613986886-29493-2-git-send-email-acatan@amazon.com>
On Mon, Feb 22, 2021 at 11:41:25AM +0200, Adrian Catangiu wrote:
> The driver also generates a `SYSGENID=%u` uevent containing the new
> system generation counter/id value every time it changes. Unlike the
> filesystem interface, the uevent has no synchronization guarantees
> therefore it should not be used by any sensitive system components.
No, please no. It is not ok to start sending random uevents all the
time to userspace for individual drivers like this. Especially for a
misc device.
As you say "has no synchromization guarantees", then why use it at all?
Please drop it.
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-22 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 9:41 [PATCH v6 0/2] System Generation ID driver and VMGENID backend Adrian Catangiu
2021-02-22 9:41 ` [PATCH v6 1/2] drivers/misc: sysgenid: add system generation id driver Adrian Catangiu
2021-02-22 9:53 ` Greg KH [this message]
2021-02-22 9:41 ` [PATCH v6 2/2] drivers/virt: vmgenid: add vm " Adrian Catangiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDN/AvsplZ7R8OTR@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=0x7f454c46@gmail.com \
--cc=Jason@zx2c4.com \
--cc=acatan@amazon.com \
--cc=areber@redhat.com \
--cc=arnd@arndb.de \
--cc=asmehra@redhat.com \
--cc=avagin@gmail.com \
--cc=bonzini@gnu.org \
--cc=borntraeger@de.ibm.com \
--cc=colmmacc@amazon.com \
--cc=corbet@lwn.net \
--cc=dgunigun@redhat.com \
--cc=dwmw@amazon.co.uk \
--cc=ebiederm@xmission.com \
--cc=ebiggers@kernel.org \
--cc=ghammer@redhat.com \
--cc=gil@azul.com \
--cc=graf@amazon.com \
--cc=jannh@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhocko@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=oridgar@gmail.com \
--cc=ovzxemul@gmail.com \
--cc=pavel@ucw.cz \
--cc=ptikhomirov@virtuozzo.com \
--cc=qemu-devel@nongnu.org \
--cc=raduweis@amazon.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=sblbir@amazon.com \
--cc=tytso@mit.edu \
--cc=vijaysun@ca.ibm.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).