From: Alan Stern <stern@rowland.harvard.edu>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error
Date: Sun, 11 Oct 2020 20:27:09 -0400 [thread overview]
Message-ID: <20201012002709.GA614913@rowland.harvard.edu> (raw)
In-Reply-To: <20201011205008.24369-1-sudipm.mukherjee@gmail.com>
On Sun, Oct 11, 2020 at 09:50:08PM +0100, Sudip Mukherjee wrote:
> Add a comment explaining why find_tt() will not return error even though
> find_tt() is checking for NULL and other errors.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
> drivers/usb/host/ehci-sched.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
> index 6dfb242f9a4b..0f85aa9b2fb1 100644
> --- a/drivers/usb/host/ehci-sched.c
> +++ b/drivers/usb/host/ehci-sched.c
> @@ -244,6 +244,12 @@ static void reserve_release_intr_bandwidth(struct ehci_hcd *ehci,
>
> /* FS/LS bus bandwidth */
> if (tt_usecs) {
> + /*
> + * find_tt() will not return any error here as we have
> + * already called find_tt() before calling this function
> + * and checked for any error return. The previous call
> + * would have created the data structure.
> + */
> tt = find_tt(qh->ps.udev);
> if (sign > 0)
> list_add_tail(&qh->ps.ps_list, &tt->ps_list);
> @@ -1337,6 +1343,12 @@ static void reserve_release_iso_bandwidth(struct ehci_hcd *ehci,
> }
> }
>
> + /*
> + * find_tt() will not return any error here as we have
> + * already called find_tt() before calling this function
> + * and checked for any error return. The previous call
> + * would have created the data structure.
> + */
> tt = find_tt(stream->ps.udev);
> if (sign > 0)
> list_add_tail(&stream->ps.ps_list, &tt->ps_list);
Acked-by: Alan Stern <stern@rowland.harvard.edu>
next prev parent reply other threads:[~2020-10-12 0:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 20:50 [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error Sudip Mukherjee
2020-10-12 0:27 ` Alan Stern [this message]
2020-10-12 14:11 ` [linux-safety] " Lukas Bulwahn
2020-10-12 14:57 ` Alan Stern
2020-10-12 15:10 ` Lukas Bulwahn
2020-10-12 15:18 ` Greg Kroah-Hartman
2020-10-12 18:25 ` Lukas Bulwahn
2020-10-13 5:23 ` Greg Kroah-Hartman
2020-10-13 5:37 ` Lukas Bulwahn
2020-10-13 6:36 ` Greg Kroah-Hartman
2020-10-13 7:16 ` Lukas Bulwahn
2020-10-13 7:35 ` Greg Kroah-Hartman
2020-10-13 8:02 ` Lukas Bulwahn
2020-10-13 8:24 ` Sudip Mukherjee
2020-10-13 8:36 ` Lukas Bulwahn
2020-10-12 16:00 ` Alan Stern
2020-10-12 18:17 ` Lukas Bulwahn
2020-10-13 5:21 ` Greg Kroah-Hartman
2020-10-13 5:41 ` Lukas Bulwahn
2020-10-12 15:24 ` Sudip Mukherjee
2020-10-12 18:49 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012002709.GA614913@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=linux-usb@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).