On Mon, Nov 16, 2020 at 04:54:07PM +0000, Sudip Mukherjee wrote: > Coccinelle suggested using PTR_ERR_OR_ZERO() and looking at the code, > we can use PTR_ERR_OR_ZERO() instead of checking IS_ERR() and then > doing 'return 0'. > > Signed-off-by: Sudip Mukherjee > --- > drivers/pci/controller/pci-tegra.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) This has been proposed multiple times in the past and Bjorn and I have agreed every time that this is not an improvement, so sorry, but NAK. Thierry -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#172): https://lists.elisa.tech/g/linux-safety/message/172 Mute This Topic: https://lists.elisa.tech/mt/78296400/5278000 Group Owner: linux-safety+owner@lists.elisa.tech Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-