[linux-safety] [PATCH] parse-sublevel-option.h : Add new line and license identifier

[linux-safety] [PATCH] parse-sublevel-option.h : Add new line and license identifier

[Nghia Le]

Add the new line at the end of file and add SPDX license identifier GPL-2.0, thus removing warning while running checkpatch.pl script

Signed-off-by: Nghia Le <nghialm78@gmail.com>
---
 tools/perf/util/parse-sublevel-options.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
index 9b9efcc2aaad..bb44b5af2963 100644
--- a/tools/perf/util/parse-sublevel-options.h
+++ b/tools/perf/util/parse-sublevel-options.h
@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
 #ifndef _PERF_PARSE_SUBLEVEL_OPTIONS_H
 #define _PERF_PARSE_SUBLEVEL_OPTIONS_H
 
@@ -8,4 +10,5 @@ struct sublevel_option {
 
 int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
 
-#endif
\ No newline at end of file
+#endif
+
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#240): https://lists.elisa.tech/g/linux-safety/message/240
Mute This Topic: https://lists.elisa.tech/mt/84977020/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [linux-safety] [PATCH] parse-sublevel-option.h : Add new line and license identifier

[Lukas Bulwahn]

On Wed, Aug 18, 2021 at 7:01 PM Nghia Le <nghialm78@gmail.com> wrote:
>
> Add the new line at the end of file and add SPDX license identifier GPL-2.0, thus removing warning while running checkpatch.pl script
>
> Signed-off-by: Nghia Le <nghialm78@gmail.com>

Did you run checkpatch.pl on your own patch? What did it report?

> ---
>  tools/perf/util/parse-sublevel-options.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
> index 9b9efcc2aaad..bb44b5af2963 100644
> --- a/tools/perf/util/parse-sublevel-options.h
> +++ b/tools/perf/util/parse-sublevel-options.h
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +

Do you understand the legal implications of adding this annotation?
Are you among the authors to make this statement with sufficient
confidence?

It seems awkward to just annotate one file here, probably it is much
better to have one commit that adds this annotation to all files in
tools/perf/ if you are sure that this is all licensed GPL-2.0.

>  #ifndef _PERF_PARSE_SUBLEVEL_OPTIONS_H
>  #define _PERF_PARSE_SUBLEVEL_OPTIONS_H
>
> @@ -8,4 +10,5 @@ struct sublevel_option {
>
>  int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
>
> -#endif
> \ No newline at end of file
> +#endif
> +

Now, you are adding an empty new line to this file. Can you create a
patch that ends with #endif and a newline instead? That seems much
more common throughout the whole kernel tree.

Good luck, we are anxiously waiting for your patch v2.

Lukas


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#241): https://lists.elisa.tech/g/linux-safety/message/241
Mute This Topic: https://lists.elisa.tech/mt/84977020/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [linux-safety] [PATCH] parse-sublevel-option.h : Add new line and license identifier

[Nghia Le]

[-- Attachment #1: Type: text/plain, Size: 3034 bytes --]

On Thu, Aug 19, 2021 at 12:11 AM Lukas Bulwahn <lukas.bulwahn@gmail.com>
wrote:

> On Wed, Aug 18, 2021 at 7:01 PM Nghia Le <nghialm78@gmail.com> wrote:
> >
> > Add the new line at the end of file and add SPDX license identifier
> GPL-2.0, thus removing warning while running checkpatch.pl script
> >
> > Signed-off-by: Nghia Le <nghialm78@gmail.com>
>
> Did you run checkpatch.pl on your own patch? What did it report?
>

  I  will add report in the PATCH v2

> ---
> >  tools/perf/util/parse-sublevel-options.h | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/parse-sublevel-options.h
> b/tools/perf/util/parse-sublevel-options.h
> > index 9b9efcc2aaad..bb44b5af2963 100644
> > --- a/tools/perf/util/parse-sublevel-options.h
> > +++ b/tools/perf/util/parse-sublevel-options.h
> > @@ -1,3 +1,5 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +
>
> Do you understand the legal implications of adding this annotation?
> Are you among the authors to make this statement with sufficient
> confidence?
>
> It seems awkward to just annotate one file here, probably it is much
> better to have one commit that adds this annotation to all files in
> tools/perf/ if you are sure that this is all licensed GPL-2.0.
>

  Thanks for your comment. Originally, I had two reasons to add license
identifier
  1. To remove the warning, I referred lots of header file in the same
folder /tools/perf/util and
      and many of them have license identifier with SPDX is GPL-2.0. Then I
thought we can apply for file which
      doesn't have identifier explicitly
  2. I also refer the topic with long conversation while Greg K-H mentioned
about add SPDX for file without license
      identifier:
https://patchwork.kernel.org/project/xfs/patch/20171107020607.GA26910@magnolia/

   However, I totally agree with you that it is quite complicated in terms
of legal implication and I am not confident enough
   to change it at the moment. Hence, I will keep it as original version

>  #ifndef _PERF_PARSE_SUBLEVEL_OPTIONS_H
> >  #define _PERF_PARSE_SUBLEVEL_OPTIONS_H
> >
> > @@ -8,4 +10,5 @@ struct sublevel_option {
> >
> >  int perf_parse_sublevel_options(const char *str, struct sublevel_option
> *opts);
> >
> > -#endif
> > \ No newline at end of file
> > +#endif
> > +
>
> Now, you are adding an empty new line to this file. Can you create a
> patch that ends with #endif and a newline instead? That seems much
> more common throughout the whole kernel tree.
>

    I will update in PATCH v2

Good luck, we are anxiously waiting for your patch v2.
>
> Lukas
>
    Thank you for your detailed comments

Nghia Le


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#242): https://lists.elisa.tech/g/linux-safety/message/242
Mute This Topic: https://lists.elisa.tech/mt/84977020/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5411 bytes --]