From: "Lukas Bulwahn" <lukas.bulwahn@gmail.com>
To: Nghia Le <nghialm78@gmail.com>
Cc: linux-safety@lists.elisa.tech
Subject: Re: [linux-safety] [PATCH v2] parse-sublevel-options.h : Add missing newline
Date: Thu, 19 Aug 2021 12:16:27 +0200 [thread overview]
Message-ID: <CAKXUXMxy2mm2OZjHE6u262B_pHPV+k3pmJK2iTqvzq=YY1MKpA@mail.gmail.com> (raw)
In-Reply-To: <20210819100451.87747-1-nghialm78@gmail.com>
For the subject line: the prefix should probably be "tools: perf:
...", but not "parse-sublevel-options.h:". Use git log --oneline
tools/perf to find the most common convention for commits to
tools/perf.
On Thu, Aug 19, 2021 at 12:05 PM Nghia Le <nghialm78@gmail.com> wrote:
>
> Add missing newline at the end of file, thus removing relevant warning
> reported by checkpatch.pl
>
You can just write "checkpatch" instead of checkpatch.pl. And end your
sentences with ".".
Always run checkpatch.pl on your patch. But there is no need to add
the checkpatch report in the commit message.
> Checkpatch.pl reported for patch as below:
>
> total: 0 errors, 0 warnings, 6 lines checked
>
> v2-0001-parse-sublevel-options.h-Add-missing-newline.patch has no obvious
> style problems and is ready for submission.
>
> Signed-off-by: Nghia Le <nghialm78@gmail.com>
> ---
> tools/perf/util/parse-sublevel-options.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
> index 9b9efcc2aaad..578b18ef03bb 100644
> --- a/tools/perf/util/parse-sublevel-options.h
> +++ b/tools/perf/util/parse-sublevel-options.h
> @@ -8,4 +8,4 @@ struct sublevel_option {
>
> int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
>
> -#endif
> \ No newline at end of file
> +#endif
Change looks good now. I suggest you send a patch v3 here and if that
is all good, it is probably ready for the general mailing list.
Lukas
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#244): https://lists.elisa.tech/g/linux-safety/message/244
Mute This Topic: https://lists.elisa.tech/mt/84993288/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2021-08-19 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 10:04 [linux-safety] [PATCH v2] parse-sublevel-options.h : Add missing newline Nghia Le
2021-08-19 10:16 ` Lukas Bulwahn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKXUXMxy2mm2OZjHE6u262B_pHPV+k3pmJK2iTqvzq=YY1MKpA@mail.gmail.com' \
--to=lukas.bulwahn@gmail.com \
--cc=linux-safety@lists.elisa.tech \
--cc=nghialm78@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).