From: "대인기/Tizen Platform Lab(SR)/삼성전자" <inki.dae@samsung.com>
To: "'Jagan Teki'" <jagan@amarulasolutions.com>,
"'Andrzej Hajda'" <andrzej.hajda@intel.com>,
"'Marek Szyprowski'" <m.szyprowski@samsung.com>,
"'Neil Armstrong'" <neil.armstrong@linaro.org>,
"'Marek Vasut'" <marex@denx.de>,
"'Maxime Ripard'" <mripard@kernel.org>
Cc: "'Seung-Woo Kim'" <sw0312.kim@samsung.com>,
"'Kyungmin Park'" <kyungmin.park@samsung.com>,
"'Frieder Schrempf'" <frieder.schrempf@kontron.de>,
"'Tim Harvey'" <tharvey@gateworks.com>,
"'Adam Ford'" <aford173@gmail.com>,
"'Matteo Lisi'" <matteo.lisi@engicam.com>,
<dri-devel@lists.freedesktop.org>,
<linux-samsung-soc@vger.kernel.org>,
"'linux-amarula'" <linux-amarula@amarulasolutions.com>
Subject: RE: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge
Date: Mon, 6 Mar 2023 14:24:28 +0900 [thread overview]
Message-ID: <000001d94feb$ef651bb0$ce2f5310$@samsung.com> (raw)
In-Reply-To: <20230303145138.29233-1-jagan@amarulasolutions.com>
Hi Jagan,
> -----Original Message-----
> From: Jagan Teki <jagan@amarulasolutions.com>
> Sent: Friday, March 3, 2023 11:51 PM
> To: Andrzej Hajda <andrzej.hajda@intel.com>; Inki Dae <inki.dae@samsung.com>;
> Marek Szyprowski <m.szyprowski@samsung.com>; Neil Armstrong
> <neil.armstrong@linaro.org>; Marek Vasut <marex@denx.de>; Maxime Ripard
> <mripard@kernel.org>
> Cc: Seung-Woo Kim <sw0312.kim@samsung.com>; Kyungmin Park
> <kyungmin.park@samsung.com>; Frieder Schrempf <frieder.schrempf@kontron.de>;
> Tim Harvey <tharvey@gateworks.com>; Adam Ford <aford173@gmail.com>; Matteo
> Lisi <matteo.lisi@engicam.com>; dri-devel@lists.freedesktop.org; linux-
> samsung-soc@vger.kernel.org; linux-amarula <linux-
> amarula@amarulasolutions.com>; Jagan Teki <jagan@amarulasolutions.com>
> Subject: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge
>
> This series supports common bridge support for Samsung MIPI DSIM
> which is used in Exynos and i.MX8MM SoC's.
>
> The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus.
>
> Inki Dae: please note that this series added on top of exynos-drm-next
> since few exynos dsi changes are not been part of drm-misc-next.
> Request you to pick these via exynos-drm-next, or let me know if you
> have any comments?
Seems some issue Marek found on testing. If fixed then I will try to pick this
patch series up.
To Andrzej, Neil, Robert and Laurent.
Could you give me any comment to below patch,
[drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge] :
https://www.spinics.net/lists/dri-devel/msg385731.html
If you could kindly provide me with an Acked-by or Signed-off-by after review,
it would greatly assist me in picking up this patch series for upstream.
Thanks,
Inki Dae
>
> Patch 0001 - 0002: find child DSI bridge and panel
>
> Patch 0003 - 0004: optional PHY, PMS_P offset
>
> Patch 0005 : introduce hw_type
>
> Patch 0006 : fixing host init
>
> Patch 0007 : atomic_check
>
> Patch 0008 : input_bus_flags
>
> Patch 0009 : atomic_get_input_bus_fmts
>
> Patch 0010 - 0011: component vs bridge
>
> Patch 0012 : DSIM bridge
>
> Patch 0013 - 0014: i.MX8M Mini/Nano
>
> Patch 0015 - 0016: i.MX8M Plus
>
> Changes for v15:
> - drop drm_of helpers
> - re-added find DSI bridge/Panel helper in dsim
> - collect RB from Marek V
> - fixed leading underscore in function names
> - commit messages updated
> - rebased on exynos-drm-next
>
> Changes for v13:
> - remove devm call for DSI panel or bridge finding
> - rebased on drm-misc-next
>
> Changes for v12:
> - collect RB from Marek V
> - add te_irq_handler hook
> - fix comments from Marek V
> - update atomic_get_input_bus_fmts logic
>
> Changes for v11:
> - collect RB from Frieder Schrempf
> - collect ACK from Rob
> - collect ACK from Robert
> - fix BIT macro replacements
> - fix checkpatch --strict warnings
> - fix unneeded commit text
> - drop extra lines
>
> Changes for v10:
> - rebase on drm-misc-next
> - add drm_of_dsi_find_panel_or_bridge
> - add devm_drm_of_dsi_get_bridge
> - fix host initialization (Thanks to Marek Szyprowski)
> - rearrange the tiny patches for easy to review
> - update simple names for enum hw_type
> - add is_hw_exynos macro
> - rework on commit messages
>
> Changes for v9:
> - rebase on drm-misc-next
> - drop drm bridge attach fix for Exynos
> - added prepare_prev_first flag
> - added pre_enable_prev_first flag
> - fix bridge chain order for exynos
> - added fix for Exynos host init for first DSI transfer
> - added MEDIA_BUS_FMT_FIXED
> - return MEDIA_BUS_FMT_RGB888_1X24 output_fmt if supported output_fmt
> list is unsupported.
> - added MEDIA_BUS_FMT_YUYV10_1X20
> - added MEDIA_BUS_FMT_YUYV12_1X24
>
> Changes for v8:
> * fixed comment lines
> * fixed commit messages
> * fixed video mode bits
> * collect Marek Ack
> * fixed video mode bit names
> * update input formats logic
> * added imx8mplus support
>
> Changes for v7:
> * fix the drm bridge attach chain for exynos drm dsi driver
> * fix the hw_type checking logic
>
> Changes for v6:
> * handle previous bridge for exynos dsi while attaching bridge
>
> Changes for v5:
> * bridge changes to support multi-arch
> * updated and clear commit messages
> * add hw_type via plat data
> * removed unneeded quirk
> * rebased on linux-next
>
> Changes for v4:
> * include Inki Dae in MAINTAINERS
> * remove dsi_driver probe in exynos_drm_drv to support multi-arch build
> * update init handling to ensure host init done on first cmd transfer
>
> Changes for v3:
> * fix the mult-arch build
> * fix dsi host init
> * updated commit messages
>
> Changes for v2:
> * fix bridge handling
> * fix dsi host init
> * correct the commit messages
>
> Tested in Engicam i.Core MX8M Mini SoM.
>
> Repo:
> https://protect2.fireeye.com/v1/url?k=ba7a5cbf-dbf1498c-ba7bd7f0-000babff9bb7-
> 64eb01b9825d1cad&q=1&e=55e2423e-1b57-4c22-a4a8-
> 3dfcebdd3d9d&u=https%3A%2F%2Fgithub.com%2Fopenedev%2Fkernel%2Ftree%2Fimx8mm-
> dsi-v15
>
> v13:
> https://lore.kernel.org/all/20230227113925.875425-1-
> jagan@amarulasolutions.com/
>
> Any inputs?
> Jagan.
>
> Jagan Teki (14):
> drm: exynos: dsi: Drop explicit call to bridge detach
> drm: exynos: dsi: Lookup OF-graph or Child node devices
> drm: exynos: dsi: Mark PHY as optional
> drm: exynos: dsi: Add platform PLL_P (PMS_P) offset
> drm: exynos: dsi: Introduce hw_type platform data
> drm: exynos: dsi: Add atomic check
> drm: exynos: dsi: Add input_bus_flags
> drm: exynos: dsi: Add atomic_get_input_bus_fmts
> drm: exynos: dsi: Consolidate component and bridge
> drm: exynos: dsi: Add host helper for te_irq_handler
> drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge
> dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support
> drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support
> dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support
>
> Marek Szyprowski (1):
> drm: exynos: dsi: Handle proper host initialization
>
> Marek Vasut (1):
> drm: bridge: samsung-dsim: Add i.MX8M Plus support
>
> .../bindings/display/exynos/exynos_dsim.txt | 2 +
> MAINTAINERS | 9 +
> drivers/gpu/drm/bridge/Kconfig | 12 +
> drivers/gpu/drm/bridge/Makefile | 1 +
> drivers/gpu/drm/bridge/samsung-dsim.c | 1965 +++++++++++++++++
> drivers/gpu/drm/exynos/Kconfig | 1 +
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1817 +--------------
> include/drm/bridge/samsung-dsim.h | 115 +
> 8 files changed, 2190 insertions(+), 1732 deletions(-)
> create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c
> create mode 100644 include/drm/bridge/samsung-dsim.h
>
> --
> 2.25.1
next prev parent reply other threads:[~2023-03-06 5:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230303145219eucas1p218c2e302e41464432627c8ac074302f8@eucas1p2.samsung.com>
2023-03-03 14:51 ` [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge Jagan Teki
2023-03-03 14:51 ` [PATCH v15 01/16] drm: exynos: dsi: Drop explicit call to bridge detach Jagan Teki
2023-03-03 16:39 ` Marek Vasut
2023-03-03 14:51 ` [PATCH v15 02/16] drm: exynos: dsi: Lookup OF-graph or Child node devices Jagan Teki
2023-03-03 16:41 ` Marek Vasut
2023-03-03 14:51 ` [PATCH v15 03/16] drm: exynos: dsi: Mark PHY as optional Jagan Teki
2023-03-03 14:51 ` [PATCH v15 04/16] drm: exynos: dsi: Add platform PLL_P (PMS_P) offset Jagan Teki
2023-03-03 14:51 ` [PATCH v15 05/16] drm: exynos: dsi: Introduce hw_type platform data Jagan Teki
2023-03-03 14:51 ` [PATCH v15 06/16] drm: exynos: dsi: Handle proper host initialization Jagan Teki
2023-03-03 14:51 ` [PATCH v15 07/16] drm: exynos: dsi: Add atomic check Jagan Teki
2023-03-03 14:51 ` [PATCH v15 08/16] drm: exynos: dsi: Add input_bus_flags Jagan Teki
2023-03-03 15:00 ` Maxime Ripard
2023-03-03 15:02 ` Maxime Ripard
2023-03-03 14:51 ` [PATCH v15 09/16] drm: exynos: dsi: Add atomic_get_input_bus_fmts Jagan Teki
2023-03-03 14:51 ` [PATCH v15 10/16] drm: exynos: dsi: Consolidate component and bridge Jagan Teki
2023-03-03 14:51 ` [PATCH v15 11/16] drm: exynos: dsi: Add host helper for te_irq_handler Jagan Teki
2023-03-03 14:51 ` [PATCH v15 13/16] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support Jagan Teki
2023-03-03 14:51 ` [PATCH v15 14/16] drm: bridge: samsung-dsim: Add " Jagan Teki
2023-03-03 14:51 ` [PATCH v15 15/16] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support Jagan Teki
2023-03-03 14:51 ` [PATCH v15 16/16] drm: bridge: samsung-dsim: Add " Jagan Teki
[not found] ` <20230303145138.29233-13-jagan@amarulasolutions.com>
2023-03-03 15:08 ` [PATCH v15 12/16] drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge Maxime Ripard
2023-03-03 15:11 ` Jagan Teki
2023-03-03 22:26 ` [PATCH v15 00/16] drm: Add Samsung MIPI " Marek Szyprowski
2023-03-04 18:59 ` Jagan Teki
2023-03-06 11:02 ` Marek Szyprowski
2023-03-06 17:24 ` Jagan Teki
2023-03-06 22:41 ` Marek Szyprowski
2023-03-07 7:55 ` Jagan Teki
2023-03-07 9:22 ` Jagan Teki
2023-03-07 10:44 ` Marek Szyprowski
2023-03-06 5:24 ` 대인기/Tizen Platform Lab(SR)/삼성전자 [this message]
2023-03-06 8:48 ` Jagan Teki
2023-03-14 0:31 ` Fabio Estevam
[not found] ` <CAAQKjZM66M6wgtoBmAcQifq8LgBUos0bZfbTkRBqnOb7E-05tQ@mail.gmail.com>
2023-03-23 15:34 ` Fabio Estevam
2023-03-27 14:08 ` Neil Armstrong
[not found] ` <CAAQKjZPmYcdUphP9w7i_O65rhXwsw2rCxAnDJ1JG73-RuLP4UQ@mail.gmail.com>
2023-03-28 7:53 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d94feb$ef651bb0$ce2f5310$@samsung.com' \
--to=inki.dae@samsung.com \
--cc=aford173@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frieder.schrempf@kontron.de \
--cc=jagan@amarulasolutions.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=marex@denx.de \
--cc=matteo.lisi@engicam.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sw0312.kim@samsung.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).