From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Kukjin Kim'" <kgene@kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: "'Marek Szyprowski'" <m.szyprowski@samsung.com>,
"'Bartlomiej Zolnierkiewicz'" <b.zolnierkie@samsung.com>,
"'Sylwester Nawrocki'" <snawrocki@kernel.org>,
"'Chanwoo Choi'" <cw00.choi@samsung.com>,
"'Pankaj Dubey'" <pankaj.dubey@samsung.com>
Subject: RE: [PATCH 1/4] arm64: dts: exynos: Add PWM interrupts on Exynos7
Date: Tue, 30 Jun 2020 20:54:28 +0530 [thread overview]
Message-ID: <001101d64ef2$8f824620$ae86d260$@samsung.com> (raw)
In-Reply-To: <20200629204442.17336-1-krzk@kernel.org>
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 30 June 2020 02:15
> To: Rob Herring <robh+dt@kernel.org>; Kukjin Kim <kgene@kernel.org>;
> Krzysztof Kozlowski <krzk@kernel.org>; devicetree@vger.kernel.org;
linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>; Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com>; Sylwester Nawrocki <snawrocki@kernel.org>;
> Alim Akhtar <alim.akhtar@samsung.com>; Chanwoo Choi
> <cw00.choi@samsung.com>; Pankaj Dubey <pankaj.dubey@samsung.com>
> Subject: [PATCH 1/4] arm64: dts: exynos: Add PWM interrupts on Exynos7
>
> Add required interrupts to PWM node on Exynos7. This fixes DT schema
> warning:
>
> pwm@136c0000: 'interrupts' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Not tested
> ---
> arch/arm64/boot/dts/exynos/exynos7.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> index f590891efe25..523547b3d539 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -581,6 +581,11 @@
> pwm: pwm@136c0000 {
> compatible = "samsung,exynos4210-pwm";
> reg = <0x136c0000 0x100>;
> + interrupts = <GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 445 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 446 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 447 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 448 IRQ_TYPE_LEVEL_HIGH>;
PWM IRQs are from 449 ~ 453 for PWM[0] ~ PWM[4] on this SoC.
444 ~ 447 are for HSI2C and 448 is for ADC.
Please see the exynos7.dtsi
Also drivers/pwm/pwm-samsung.c does not uses interrupt at all, still we need
interrupts property to be added here?
> samsung,pwm-outputs = <0>, <1>, <2>, <3>;
> #pwm-cells = <3>;
> clocks = <&clock_peric0 PCLK_PWM>;
> --
> 2.17.1
next prev parent reply other threads:[~2020-06-30 15:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200629205534epcas5p33eb7cbdff4aee986d2e509e0c79cf952@epcas5p3.samsung.com>
2020-06-29 20:44 ` [PATCH 1/4] arm64: dts: exynos: Add PWM interrupts on Exynos7 Krzysztof Kozlowski
2020-06-29 20:44 ` [PATCH 2/4] arm64: dts: exynos: Remove generic arm,armv8-pmuv3 compatible Krzysztof Kozlowski
2020-06-29 20:44 ` [PATCH 3/4] arm64: dts: exynos: Align DMA controller bus node name with dtschema Krzysztof Kozlowski
2020-06-30 7:34 ` Marek Szyprowski
2020-07-02 6:01 ` Krzysztof Kozlowski
2020-06-29 20:44 ` [PATCH 4/4] ARM: " Krzysztof Kozlowski
2020-06-30 15:24 ` Alim Akhtar [this message]
2020-07-02 6:00 ` [PATCH 1/4] arm64: dts: exynos: Add PWM interrupts on Exynos7 'Krzysztof Kozlowski'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001101d64ef2$8f824620$ae86d260$@samsung.com' \
--to=alim.akhtar@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).