RE: [PATCH v4 15/16] scsi: ufs: ufs-exynos: introduce exynosauto v9 virtual host

From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Avri Altman'" <Avri.Altman@wdc.com>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>,
	"'James E . J . Bottomley'" <jejb@linux.ibm.com>,
	"'Martin K . Petersen'" <martin.petersen@oracle.com>,
	"'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>
Cc: "'Bean Huo'" <beanhuo@micron.com>,
	"'Bart Van Assche'" <bvanassche@acm.org>,
	"'Adrian Hunter'" <adrian.hunter@intel.com>, <hch@infradead.org>,
	"'Can Guo'" <cang@codeaurora.org>,
	"'Jaegeuk Kim'" <jaegeuk@kernel.org>,
	"'Jaehoon Chung'" <jh80.chung@samsung.com>,
	"'Gyunghoon Kwon'" <goodjob.kwon@samsung.com>,
	"'Sowon Na'" <sowon.na@samsung.com>,
	<linux-samsung-soc@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
	"'Kiwoong Kim'" <kwmad.kim@samsung.com>
Subject: RE: [PATCH v4 15/16] scsi: ufs: ufs-exynos: introduce exynosauto v9 virtual host
Date: Fri, 15 Oct 2021 21:13:38 +0900	[thread overview]
Message-ID: <001c01d7c1be$16180960$42481c20$@samsung.com> (raw)
In-Reply-To: <DM6PR04MB6575717817EDD8C549F2D539FCB89@DM6PR04MB6575.namprd04.prod.outlook.com>

> > +static int exynosauto_ufs_vh_link_startup_notify(struct ufs_hba *hba,
> > +                                                enum
> > +ufs_notify_change_status status) {
> > +       if (status == POST_CHANGE) {
> > +               ufshcd_set_link_active(hba);
> > +               ufshcd_set_ufs_dev_active(hba);
> > +               hba->wlun_dev_clr_ua = true;
> wlun_dev_clr_ua no longer exists - needs rebase

I found the commit. I'll remove this next patch.

> 
> > +       }
> > +
> > +       return 0;
> > +}
> > +
> > +static int exynosauto_ufs_vh_wait_ph_ready(struct ufs_hba *hba) {
> > +       u32 mbox;
> > +       ktime_t start, stop;
> > +
> > +       start = ktime_get();
> > +       stop = ktime_add(start, ms_to_ktime(PH_READY_TIMEOUT_MS));
> > +
> > +       do {
> > +               mbox = ufshcd_readl(hba, PH2VH_MBOX);
> > +               if ((mbox & MH_MSG_MASK) == MH_MSG_PH_READY)
> > +                       return 0;
> Maybe add a comment here that the mbox protocol will be defined later.

Put some comments with TODO: tag.

Best Regards,
Chanho Park