From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>
Cc: "'Alim Akhtar'" <alim.akhtar@samsung.com>,
"'James E . J . Bottomley'" <jejb@linux.ibm.com>,
"'Martin K . Petersen'" <martin.petersen@oracle.com>,
"'Can Guo'" <cang@codeaurora.org>,
"'Jaegeuk Kim'" <jaegeuk@kernel.org>,
"'Kiwoong Kim'" <kwmad.kim@samsung.com>,
"'Avri Altman'" <avri.altman@wdc.com>,
"'Adrian Hunter'" <adrian.hunter@intel.com>,
"'Christoph Hellwig'" <hch@infradead.org>,
"'Bart Van Assche'" <bvanassche@acm.org>,
"'jongmin jeong'" <jjmin.jeong@samsung.com>,
"'Gyunghoon Kwon'" <goodjob.kwon@samsung.com>,
<linux-samsung-soc@vger.kernel.org>, <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH 13/15] scsi: ufs: ufs-exynos: support exynosauto v9 ufs driver
Date: Tue, 13 Jul 2021 21:07:13 +0900 [thread overview]
Message-ID: <009b01d777df$9da09c40$d8e1d4c0$@samsung.com> (raw)
In-Reply-To: <CAJKOXPfJOGz7WhCk4HPtDh0=13gy0q=r5isLNkKz+yetAshAfw@mail.gmail.com>
> > +/* FSYS UFS Sharability */
>
> Sharability -> Shareability
Typo. I'll correct it next patchset.
>
> > +#define UFS_WR_SHARABLE BIT(2)
> > +#define UFS_RD_SHARABLE BIT(1)
> > +#define UFS_SHARABLE (UFS_WR_SHARABLE | UFS_RD_SHARABLE)
> > +#define UFS_SHARABILITY_OFFSET 0x710
> > +
> > enum {
> > UNIPRO_L1_5 = 0,/* PHY Adapter */
> > UNIPRO_L2, /* Data Link */
> > @@ -151,6 +158,80 @@ static int exynos7_ufs_drv_init(struct device *dev,
> struct exynos_ufs *ufs)
> > return 0;
> > }
> >
> > +static int exynosauto_ufs_drv_init(struct device *dev, struct
> > +exynos_ufs *ufs) {
> > + struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr;
> > +
> > + /* IO Coherency setting */
> > + if (ufs->sysreg) {
> > + return regmap_update_bits(ufs->sysreg,
> UFS_SHARABILITY_OFFSET,
> > + UFS_SHARABLE, UFS_SHARABLE);
> > + }
> > +
> > + attr->tx_dif_p_nsec = 3200000;
> > +
> > + return 0;
> > +}
> > +
> > +static int exynosauto_ufs_pre_link(struct exynos_ufs *ufs) {
> > + struct ufs_hba *hba = ufs->hba;
> > + int i;
> > +
> > + ufshcd_dme_set(hba, UIC_ARG_MIB(0x200), 0x40);
> > + for_each_ufs_rx_lane(ufs, i) {
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x12, i),
> > + DIV_ROUND_UP(NSEC_PER_SEC, ufs->mclk_rate));
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x11, i), 0x0);
> > +
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x1b, i), 0x2);
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x1c, i), 0x8a);
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x1d, i), 0xa3);
> > +
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x1b, i), 0x2);
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x1c, i), 0x8a);
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x1d, i), 0xa3);
> > +
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x2f, i), 0x79);
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x84, i), 0x1);
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x25, i), 0xf6);
> > + }
> > +
> > + for_each_ufs_tx_lane(ufs, i) {
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0xaa, i),
> > + DIV_ROUND_UP(NSEC_PER_SEC, ufs->mclk_rate));
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0xa9, i), 0x02);
> > +
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0xab, i), 0x8);
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0xac, i), 0x22);
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0xad, i), 0x8);
> > +
> > + ufshcd_dme_set(hba, UIC_ARG_MIB_SEL(0x04, i), 0x1);
> > + }
> > +
> > + ufshcd_dme_set(hba, UIC_ARG_MIB(0x200), 0x0);
> > +
> > + ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0x0);
> > +
> > + ufshcd_dme_set(hba, UIC_ARG_MIB(0xa011), 0x8000);
> > +
> > + return 0;
> > +}
> > +
> > +static int exynosauto_ufs_pre_pwr_change(struct exynos_ufs *ufs,
> > + struct ufs_pa_layer_attr
> > +*pwr) {
> > + struct ufs_hba *hba = ufs->hba;
> > +
> > + /* PACP_PWR_req and delivered to the remote DME */
> > + ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA0), 12000);
> > + ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA1), 32000);
> > + ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA2), 16000);
> > +
> > + return 0;
> > +}
> > +
>
> No need for double line.
Will be fixed as well. :)
>
> > +
> > static int exynos7_ufs_pre_link(struct exynos_ufs *ufs) {
> > struct ufs_hba *hba = ufs->hba; @@ -1305,6 +1386,20 @@ static
> > struct exynos_ufs_uic_attr exynos7_uic_attr = {
> > .pa_dbg_option_suite = 0x30103,
> > };
> >
> > +static struct exynos_ufs_drv_data exynosauto_ufs_drvs = {
> > + .uic_attr = &exynos7_uic_attr,
> > + .quirks = UFSHCD_QUIRK_PRDT_BYTE_GRAN |
> > + UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR |
> > + UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR |
> > + UFSHCD_QUIRK_SKIP_DEF_UNIPRO_TIMEOUT_SETTING,
> > + .opts = EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL |
> > + EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR |
> > + EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX,
> > + .drv_init = exynosauto_ufs_drv_init,
> > + .pre_link = exynosauto_ufs_pre_link,
> > + .pre_pwr_change = exynosauto_ufs_pre_pwr_change,
> > +};
> > +
> > static struct exynos_ufs_drv_data exynos_ufs_drvs = {
> > .uic_attr = &exynos7_uic_attr,
> > .quirks = UFSHCD_QUIRK_PRDT_BYTE_GRAN |
> > @@ -1330,6 +1425,8 @@ static struct exynos_ufs_drv_data
> > exynos_ufs_drvs = { static const struct of_device_id
> exynos_ufs_of_match[] = {
> > { .compatible = "samsung,exynos7-ufs",
> > .data = &exynos_ufs_drvs },
> > + { .compatible = "samsung,exynosautov9-ufs",
> > + .data = &exynosauto_ufs_drvs },
>
> This compatible is not documented. It seems that no one document exynos7-
> ufs but that's not an excuse. :)
Hmm. Let me check whether I can add ufs-exynos.yaml.
Best Regards,
Chanho Park
next prev parent reply other threads:[~2021-07-13 12:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210709065721epcas2p46f7aae35571c10f233b71a6381214419@epcas2p4.samsung.com>
2021-07-09 6:56 ` [PATCH 00/15] introduce exynosauto v9 ufs driver Chanho Park
[not found] ` <CGME20210709065746epcas2p10d43898e863a873594f81f4a5a4f0ef2@epcas2p1.samsung.com>
2021-07-09 6:56 ` [PATCH 01/15] scsi: ufs: add quirk to handle broken UIC command Chanho Park
[not found] ` <CGME20210709065746epcas2p2f353983bbc64c1a21571fda2be59df34@epcas2p2.samsung.com>
2021-07-09 6:56 ` [PATCH 02/15] scsi: ufs: add quirk to enable host controller without interface configuration Chanho Park
2021-07-13 18:10 ` Alim Akhtar
2021-07-14 3:26 ` Chanho Park
[not found] ` <CGME20210709065746epcas2p47985fa3c33297a36d772fb9d45f30972@epcas2p4.samsung.com>
2021-07-09 6:56 ` [PATCH 03/15] scsi: ufs: ufs-exynos: change pclk available max value Chanho Park
2021-07-13 18:18 ` Alim Akhtar
[not found] ` <CGME20210709065746epcas2p26f07099abcb946400ff2777fd9df975d@epcas2p2.samsung.com>
2021-07-09 6:57 ` [PATCH 04/15] scsi: ufs: ufs-exynos: simplify drv_data retrieval Chanho Park
2021-07-13 18:59 ` Alim Akhtar
[not found] ` <CGME20210709065746epcas2p4cd871004fa034dace5046a8acf1d1b96@epcas2p4.samsung.com>
2021-07-09 6:57 ` [PATCH 05/15] scsi: ufs: ufs-exynos: get sysreg regmap for io-coherency Chanho Park
[not found] ` <CGME20210709065746epcas2p1367527fd1299b15fc339876281cb8af1@epcas2p1.samsung.com>
2021-07-09 6:57 ` [PATCH 06/15] scsi: ufs: ufs-exynos: add refclkout_stop control Chanho Park
2021-07-14 1:41 ` Alim Akhtar
[not found] ` <CGME20210709065746epcas2p20094c97a7abfd7704c30ca6bac04f924@epcas2p2.samsung.com>
2021-07-09 6:57 ` [PATCH 07/15] scsi: ufs: ufs-exynos: add setup_clocks callback Chanho Park
[not found] ` <CGME20210709065746epcas2p1b3e10cef9024d2092b019bddd7580256@epcas2p1.samsung.com>
2021-07-09 6:57 ` [PATCH 08/15] scsi: ufs: ufs-exynos: correct timeout value setting registers Chanho Park
[not found] ` <CGME20210709065746epcas2p35975dfa47363d0ea792988047f83a0ae@epcas2p3.samsung.com>
2021-07-09 6:57 ` [PATCH 09/15] scsi: ufs: ufs-exynos: support custom version of ufs_hba_variant_ops Chanho Park
[not found] ` <CGME20210709065747epcas2p2e966883390d1e77a43a897eae9ef0ad3@epcas2p2.samsung.com>
2021-07-09 6:57 ` [PATCH 10/15] scsi: ufs: ufs-exynos: add EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR option Chanho Park
[not found] ` <CGME20210709065747epcas2p11576f5bd85eb2d99ae24a7241869a2f9@epcas2p1.samsung.com>
2021-07-09 6:57 ` [PATCH 11/15] scsi: ufs: ufs-exynos: factor out priv data init Chanho Park
[not found] ` <CGME20210709065747epcas2p284a0f5eac2e46bf03283b7a7363616c4@epcas2p2.samsung.com>
2021-07-09 6:57 ` [PATCH 12/15] scsi: ufs: ufs-exynos: add pre/post_hce_enable drv callbacks Chanho Park
[not found] ` <CGME20210709065747epcas2p483ee186906567e9e61a2a2c10209fc79@epcas2p4.samsung.com>
2021-07-09 6:57 ` [PATCH 13/15] scsi: ufs: ufs-exynos: support exynosauto v9 ufs driver Chanho Park
2021-07-13 10:57 ` Krzysztof Kozlowski
2021-07-13 12:07 ` Chanho Park [this message]
2021-07-13 12:11 ` Alim Akhtar
2021-07-16 15:03 ` Rob Herring
[not found] ` <CGME20210709065747epcas2p10c59e097d9770fc02134cb0545c9de4f@epcas2p1.samsung.com>
2021-07-09 6:57 ` [PATCH 14/15] scsi: ufs: ufs-exynos: multi-host configuration for exynosauto Chanho Park
2021-08-03 16:57 ` Bean Huo
2021-08-03 23:35 ` Chanho Park
[not found] ` <CGME20210709065747epcas2p37d1d2fc1ce5b582b71fa5187099d1801@epcas2p3.samsung.com>
2021-07-09 6:57 ` [PATCH 15/15] scsi: ufs: ufs-exynos: introduce exynosauto v9 virtual host Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009b01d777df$9da09c40$d8e1d4c0$@samsung.com' \
--to=chanho61.park@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=goodjob.kwon@samsung.com \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jjmin.jeong@samsung.com \
--cc=krzk@kernel.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).