From: Sylwester Nawrocki <snawrocki@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Pankaj Dubey <pankaj.dubey@samsung.com>
Subject: Re: [PATCH 1/3] ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats
Date: Mon, 29 Jun 2020 21:50:26 +0200 [thread overview]
Message-ID: <03a23289-1188-db77-6c38-a7dddeac183c@kernel.org> (raw)
In-Reply-To: <20200629193338.29540-1-krzk@kernel.org>
Hi Krzysztof,
On 6/29/20 21:33, Krzysztof Kozlowski wrote:
> Remove the simple-bus compatible from a regulators node because its
> children do not have any unit addresses. This fixes DTC warning:
>
> Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm/boot/dts/exynos4210-trats.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
> index 3d791db6095c..cec413ee4490 100644
> --- a/arch/arm/boot/dts/exynos4210-trats.dts
> +++ b/arch/arm/boot/dts/exynos4210-trats.dts
> @@ -31,8 +31,6 @@
> };
>
> regulators {
> - compatible = "simple-bus";
I think you would also need to remove the 'regulators' node altogether,
otherwise with your change the subnodes below won't get parsed and the
regulators will not get registered.
> vemmc_reg: regulator-0 {
> compatible = "regulator-fixed";
> regulator-name = "VMEM_VDD_2.8V";
>
--
Thanks,
Sylwester
next prev parent reply other threads:[~2020-06-29 19:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 19:33 [PATCH 1/3] ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats Krzysztof Kozlowski
2020-06-29 19:33 ` [RFT 2/3] arm64: dts: exynos: Add unit address to soc node on Exynos5433 Krzysztof Kozlowski
2020-06-30 10:09 ` Marek Szyprowski
2020-07-07 6:45 ` Krzysztof Kozlowski
2020-06-29 19:33 ` [RFT 3/3] arm64: dts: exynos: Add unit address to soc node and move thermal zones on Exynos7 Krzysztof Kozlowski
2020-07-07 6:46 ` Krzysztof Kozlowski
2020-06-29 19:50 ` Sylwester Nawrocki [this message]
2020-06-29 20:46 ` [PATCH 1/3] ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03a23289-1188-db77-6c38-a7dddeac183c@kernel.org \
--to=snawrocki@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).