From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Henrik Grimler <henrik@grimler.se>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
alim.akhtar@samsung.com, m.szyprowski@samsung.com,
jenneron@protonmail.com, markuss.broks@gmail.com,
martin.juecker@gmail.com, virag.david003@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v3 1/2] ARM: dts: exynos: replace mshc0 alias with mmc-ddr-1_8v property
Date: Sun, 12 Mar 2023 17:31:48 +0100 [thread overview]
Message-ID: <08baf8d8-d93d-780e-6b17-9485ccb5350a@linaro.org> (raw)
In-Reply-To: <20230227193819.30133-2-henrik@grimler.se>
On 27/02/2023 20:38, Henrik Grimler wrote:
> Previously, the mshc0 alias has been necessary so that
> MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA are set for mshc_0/mmc_0.
> However, these capabilities should be described in the device tree so
> that we do not have to rely on the alias.
>
> The property mmc-ddr-1_8v replaces MMC_CAP_1_8V_DDR, while bus_width =
> <8>, which is already set for all the mshc0/mmc0 nodes, replaces
> MMC_CAP_8_BIT_DATA.
>
> Also cleanup and sort (but keep status property at top) some of the
status is rather the last property
> nodes while we are modifying them.
Don't mix cleanups with any other changes.
>
> Signed-off-by: Henrik Grimler <henrik@grimler.se>
> ---
> Changes since v2:
> * Set mmc-ddr-1_8v in device trees for mshc_0/mmc_0
>
> arch/arm/boot/dts/exynos3250-artik5.dtsi | 15 ++++++-------
> arch/arm/boot/dts/exynos3250-monk.dts | 19 ++++++++---------
> arch/arm/boot/dts/exynos3250-rinato.dts | 21 ++++++++-----------
> arch/arm/boot/dts/exynos3250.dtsi | 3 ---
> arch/arm/boot/dts/exynos4210-i9100.dts | 5 ++---
> arch/arm/boot/dts/exynos4210-origen.dts | 3 ++-
> arch/arm/boot/dts/exynos4210-trats.dts | 3 ++-
> .../boot/dts/exynos4210-universal_c210.dts | 3 ++-
> arch/arm/boot/dts/exynos4412-itop-elite.dts | 4 ++++
> .../boot/dts/exynos4412-itop-scp-core.dtsi | 17 +++++++++------
> arch/arm/boot/dts/exynos4412-midas.dtsi | 17 ++++++++-------
> .../boot/dts/exynos4412-odroid-common.dtsi | 16 +++++++-------
> arch/arm/boot/dts/exynos4412-origen.dts | 12 +++++------
> arch/arm/boot/dts/exynos4412-p4note.dtsi | 17 ++++++++-------
> arch/arm/boot/dts/exynos4412.dtsi | 1 -
> arch/arm/boot/dts/exynos5250-arndale.dts | 1 +
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 1 +
> arch/arm/boot/dts/exynos5250-snow-common.dtsi | 1 +
> arch/arm/boot/dts/exynos5250-spring.dts | 1 +
> arch/arm/boot/dts/exynos5250.dtsi | 4 ----
> arch/arm/boot/dts/exynos5260-xyref5260.dts | 11 +++++-----
> arch/arm/boot/dts/exynos5410-odroidxu.dts | 1 +
> arch/arm/boot/dts/exynos5410-smdk5410.dts | 1 +
> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 1 +
> .../dts/exynos5420-galaxy-tab-common.dtsi | 1 +
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 1 +
> arch/arm/boot/dts/exynos5420-smdk5420.dts | 1 +
> arch/arm/boot/dts/exynos5420.dtsi | 3 ---
> .../boot/dts/exynos5422-odroidxu3-common.dtsi | 1 +
> arch/arm/boot/dts/exynos5422-samsung-k3g.dts | 1 +
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
> 31 files changed, 100 insertions(+), 87 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
> index 0ac3f284fbb8..794cbf579316 100644
> --- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
> +++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
> @@ -315,19 +315,20 @@ buck5_reg: BUCK5 {
> };
>
> &mshc_0 {
> - non-removable;
> + status = "okay";> + bus-width = <8>;
> cap-mmc-highspeed;
> card-detect-delay = <200>;
> - vmmc-supply = <&ldo12_reg>;
> clock-frequency = <100000000>;
> max-frequency = <100000000>;
> + mmc-ddr-1_8v;
> + non-removable;
> + pinctrl-0 = <&sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8>;
> + pinctrl-names = "default";
> samsung,dw-mshc-ciu-div = <1>;
> - samsung,dw-mshc-sdr-timing = <0 1>;
> samsung,dw-mshc-ddr-timing = <1 2>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8>;
> - bus-width = <8>;
> - status = "okay";
> + samsung,dw-mshc-sdr-timing = <0 1>;
> + vmmc-supply = <&ldo12_reg>;
It is impossible to review what happenned here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-12 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 19:38 [PATCH v3 0/2] ARM: dts: add mmc aliases for Exynos devices Henrik Grimler
2023-02-27 19:38 ` [PATCH v3 1/2] ARM: dts: exynos: replace mshc0 alias with mmc-ddr-1_8v property Henrik Grimler
2023-03-12 16:31 ` Krzysztof Kozlowski [this message]
2023-03-13 20:28 ` Henrik Grimler
2023-02-27 19:38 ` [PATCH v3 2/2] ARM: dts: exynos: add mmc aliases Henrik Grimler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08baf8d8-d93d-780e-6b17-9485ccb5350a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=jenneron@protonmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=markuss.broks@gmail.com \
--cc=martin.juecker@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=virag.david003@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).