From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Xiang wangx <wangxiang@cdjrlc.com>
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: s3c2410: Delete unneeded variable: "ret"
Date: Thu, 16 Sep 2021 12:52:36 +0200 [thread overview]
Message-ID: <0d1a0027-e74d-9f07-3b96-372b5ca14ae3@canonical.com> (raw)
In-Reply-To: <20210916103718.29956-1-wangxiang@cdjrlc.com>
On 16/09/2021 12:37, Xiang wangx wrote:
> variable: "ret" defined but not used in function "i2c_s3c_irq_nextbyte"
>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index b49a1b170bb2..6df85b23156c 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -385,7 +385,6 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
> {
> unsigned long tmp;
> unsigned char byte;
> - int ret = 0;
>
> switch (i2c->state) {
>
> @@ -548,7 +547,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
> tmp &= ~S3C2410_IICCON_IRQPEND;
> writel(tmp, i2c->regs + S3C2410_IICCON);
> out:
> - return ret;
> + return 0;
Change is okay but I would go step further - made the function return
void(). None of the callers check for return so no functionality is lost.
Best regards,
Krzysztof
prev parent reply other threads:[~2021-09-16 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 10:37 [PATCH] i2c: s3c2410: Delete unneeded variable: "ret" Xiang wangx
2021-09-16 10:52 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d1a0027-e74d-9f07-3b96-372b5ca14ae3@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=wangxiang@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).