From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 2/4] phy: exynos5: Remove duplicated defines of PHY register defines Date: Tue, 14 Mar 2017 15:37:03 +0100 Message-ID: <10362020.XmlhBa7gD6@amdc3058> References: <20170311182534.13345-1-krzk@kernel.org> <20170311182534.13345-3-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: In-reply-to: <20170311182534.13345-3-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski Cc: Kishon Vijay Abraham I , Kukjin Kim , Javier Martinez Canillas , Lee Jones , Sylwester Nawrocki , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org On Saturday, March 11, 2017 08:25:32 PM Krzysztof Kozlowski wrote: > Phy drivers access PMU region through regmap provided by exynos-pmu > driver. However there is no need to duplicate defines for PMU > registers. Instead just use whatever is defined in exynos-regs-pmu.h. > > This reduces number of defines and allows removal of one header. exynos5-pmu.h goes away in patch #4 > Suggested-by: Marek Szyprowski > Signed-off-by: Krzysztof Kozlowski > Acked-by: Lee Jones Reviewed-by: Bartlomiej Zolnierkiewicz > --- > drivers/phy/phy-exynos-dp-video.c | 1 + > drivers/phy/phy-exynos5-usbdrd.c | 1 + > include/linux/mfd/syscon/exynos5-pmu.h | 27 --------------------------- > include/linux/soc/samsung/exynos-regs-pmu.h | 8 ++++++++ > 4 files changed, 10 insertions(+), 27 deletions(-) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics