From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 1/4] phy: exynos4: Remove duplicated defines of PHY register defines Date: Tue, 14 Mar 2017 15:33:51 +0100 Message-ID: <12641153.bQdFckdOQG@amdc3058> References: <20170311182534.13345-1-krzk@kernel.org> <20170311182534.13345-2-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20170311182534.13345-2-krzk@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Krzysztof Kozlowski Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Javier Martinez Canillas , Kukjin Kim , Sylwester Nawrocki , Lee Jones , linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org On Saturday, March 11, 2017 08:25:31 PM Krzysztof Kozlowski wrote: > Phy drivers access PMU region through regmap provided by exynos-pmu > driver. However there is no need to duplicate defines for PMU > registers. Instead just use whatever is defined in exynos-regs-pmu.h. > > Additionally MIPI PHY registers for Exynos5433 start from the same > address as Exynos4 and Exynos5250 so re-use existing defines. > > This reduces number of defines and allows removal of one header file. > > Suggested-by: Marek Szyprowski > Signed-off-by: Krzysztof Kozlowski > Acked-by: Lee Jones Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics