From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-arm-kernel@axis.com
Cc: nsekhar@ti.com
Subject: Re: [PATCH v2 2/7] PCI: dwc: dra7xx: Populate cpu_addr_fixup ops
Date: Tue, 7 Mar 2017 11:12:36 +0000 [thread overview]
Message-ID: <14c771fd-f225-338b-3b1a-255df0e0b278@synopsys.com> (raw)
In-Reply-To: <1488880372-7390-3-git-send-email-kishon@ti.com>
Às 9:52 AM de 3/7/2017, Kishon Vijay Abraham I escreveu:
> Populate cpu_addr_fixup ops to extract the least 28 bits of the
> corresponding cpu address.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/pci/dwc/pci-dra7xx.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 0984baf..07c45ec 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -88,6 +88,11 @@ static inline void dra7xx_pcie_writel(struct dra7xx_pcie *pcie, u32 offset,
> writel(value, pcie->base + offset);
> }
>
> +static u64 dra7xx_pcie_cpu_addr_fixup(u64 pci_addr)
> +{
> + return pci_addr & DRA7XX_CPU_TO_BUS_ADDR;
> +}
> +
> static int dra7xx_pcie_link_up(struct dw_pcie *pci)
> {
> struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci);
> @@ -152,11 +157,6 @@ static void dra7xx_pcie_host_init(struct pcie_port *pp)
> struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci);
>
> - pp->io_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->mem_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->cfg0_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->cfg1_base &= DRA7XX_CPU_TO_BUS_ADDR;
> -
> dw_pcie_setup_rc(pp);
>
> dra7xx_pcie_establish_link(dra7xx);
> @@ -329,6 +329,7 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> }
>
> static const struct dw_pcie_ops dw_pcie_ops = {
> + .cpu_addr_fixup = dra7xx_pcie_cpu_addr_fixup,
> .link_up = dra7xx_pcie_link_up,
> };
>
>
Simpler, no doubt.
Acked-By: Joao Pinto <jpinto@synopsys.com>
next prev parent reply other threads:[~2017-03-07 11:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 9:52 [PATCH v2 0/7] PCI: dwc: miscellaneous fixes and cleanups Kishon Vijay Abraham I
2017-03-07 9:52 ` [PATCH v2 1/7] PCI: dwc: designware: Add new *ops* for cpu addr fixup Kishon Vijay Abraham I
2017-03-07 11:11 ` Joao Pinto
2017-03-07 9:52 ` [PATCH v2 2/7] PCI: dwc: dra7xx: Populate cpu_addr_fixup ops Kishon Vijay Abraham I
2017-03-07 11:12 ` Joao Pinto [this message]
2017-03-07 9:52 ` [PATCH v2 3/7] PCI: dwc: artpec6: " Kishon Vijay Abraham I
2017-03-07 11:12 ` Joao Pinto
2017-03-07 9:52 ` [PATCH v2 4/7] PCI: dwc: all: Modify dbi accessors to take dbi_base as argument Kishon Vijay Abraham I
2017-03-07 11:34 ` Joao Pinto
2017-03-07 9:52 ` [PATCH v2 5/7] PCI: dwc: all: Modify dbi accessors to access data of 4/2/1 bytes Kishon Vijay Abraham I
2017-03-07 11:18 ` Joao Pinto
2017-03-07 11:23 ` Kishon Vijay Abraham I
2017-03-07 9:52 ` [PATCH v2 6/7] PCI: dwc: designware: Modify _unroll() to _ob_unroll() Kishon Vijay Abraham I
2017-03-07 9:52 ` [PATCH v2 7/7] PCI: dwc: dra7xx: Push request_irq call to the bottom of probe Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14c771fd-f225-338b-3b1a-255df0e0b278@synopsys.com \
--to=joao.pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).