From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65276C433E1 for ; Wed, 12 Aug 2020 07:57:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CEEB206B5 for ; Wed, 12 Aug 2020 07:57:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597219030; bh=tyXmsvrm0Da55C+UKk25Av4LOuZ0ELKK1/IGS0pFcns=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=OjUcnmOOEqOHg8iNWiNy/esBgz2CD3iub0U2nqyd2HoN25I0aqLkCaUhiobcf9Jfb 7WY27LpYqJOmScnyJD/xH0+EjBJrzUWIZnS8Xr3mBAKRE9TB7/HgE7qSUPZJSMTU7p v+kqetQouAnOQXcTbEum3KuCa9S8Uki5uWuo4ab0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbgHLH5J (ORCPT ); Wed, 12 Aug 2020 03:57:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:37460 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726618AbgHLH5H (ORCPT ); Wed, 12 Aug 2020 03:57:07 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 337FF206B2; Wed, 12 Aug 2020 07:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597219027; bh=tyXmsvrm0Da55C+UKk25Av4LOuZ0ELKK1/IGS0pFcns=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=0MYa+c6HTbguXG56M12pgmwH/XlpMlZpbNLLN/qXwbbQuFXWvC1iZ1mGHxwhpwN3h nSnSMWoqGKor9xoqqgbMW1bzpyVss/jKG+FW+ZsKcjjM6Y1lldl2DXnMFoUb8K3lMW CUoU4yU2EX5I5cHAQJWFA5AZg7W97T69JFzgYEq8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200804192654.12783-2-krzk@kernel.org> References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-2-krzk@kernel.org> Subject: Re: [PATCH v2 01/13] clk: samsung: s3c64xx: declare s3c64xx_clk_init() in shared header From: Stephen Boyd Cc: Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao To: Alexandre Torgue , Arnd Bergmann , Catalin Marinas , Chanwoo Choi , Guenter Roeck , Krzysztof Kozlowski , Kukjin Kim , Kyungmin Park , Maxime Coquelin , Michael Turquette , Russell King , Simtec Linux Team , Sylwester Nawrocki , Tomasz Figa , Will Deacon , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-watchdog@vger.kernel.org, patches@opensource.cirrus.com Date: Wed, 12 Aug 2020 00:57:06 -0700 Message-ID: <159721902609.33733.3673741521313105196@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Quoting Krzysztof Kozlowski (2020-08-04 12:26:42) > The s3c64xx_clk_init() is defined and used by the clk-s3c64xx driver and > also used in the mach-s3c64xx machine code. Move the declaration to a > header to fix W=3D1 build warning: >=20 > drivers/clk/samsung/clk-s3c64xx.c:391:13: warning: no previous protot= ype for 's3c64xx_clk_init' [-Wmissing-prototypes] > 391 | void __init s3c64xx_clk_init(struct device_node *np, unsigned= long xtal_f, >=20 > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Tomasz Figa >=20 > --- Reviewed-by: Stephen Boyd